Project

General

Profile

feature request #8688

Make OriginalSourceBase.cdmSource visible in TaxEditor

Added by Andreas Müller about 1 year ago. Updated 9 months ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
11/15/2019
Due date:
% Done:

100%

Severity:
major

Description

The field OriginalSourceBase.cdmSource is usually filled during aggregations (for now). Therefore it does not need to be editable but the result should be visible to be able to distinguish and recognize sources.

Possible open questions related: do we want to have a new subclass for OriginalSourceBase which only handles CdmLink-Sources. This subclass does not need to show all other fields (citation, id, namespace as these are probably never used). Or can we distinguish which fields to show simply by the result of (osb.cdmSource == null)? => moved to: #8778


Related issues

Related to Edit - feature request #8686: Support CdmLink sources in bibliography Closed 11/15/2019
Related to Edit - bug #8687: Description page must show all DescriptionElement subclasses New 11/15/2019
Related to Edit - feature request #8724: Allow OriginalSource to link to Taxon Closed 11/27/2019
Related to Edit - feature request #8778: Have explicit subclass for CdmSourceLink sources New 12/17/2019
Copied to Edit - feature request #8777: Make visiblity of CDM Source configurable New 12/17/2019

Associated revisions

Revision 5d945a6e (diff)
Added by Patrick Plitzner 12 months ago

fix #8688 Make OriginalSourceBase.cdmSource visible in TaxEditor

Revision 27c58d84 (diff)
Added by Katja Luther 10 months ago

ref #8688: show only titleCache for IdentifiableEntities

History

#1 Updated by Andreas Müller about 1 year ago

  • Target version changed from Unassigned CDM tickets to Release 5.12

Please decide who could be assignee. It would be nice to have it soon.

#2 Updated by Andreas Müller about 1 year ago

#3 Updated by Andreas Müller about 1 year ago

  • Related to bug #8687: Description page must show all DescriptionElement subclasses added

#4 Updated by Patrick Plitzner 12 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#5 Updated by Patrick Plitzner 12 months ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

Current implementation shows the titleCache if it is an IdentifiableEntity. It shows the UUID if it is a CdmBase. Otherwise it calls object.toString().

#6 Updated by Andreas Müller 12 months ago

#7 Updated by Andreas Müller 12 months ago

#8 Updated by Andreas Müller 12 months ago

  • Description updated (diff)

#9 Updated by Andreas Müller 12 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

The current solution shows titleCache+uuid for identifiable entities. This is too much. For now we need only the titleCache. Please remove uuid (it is needed only for non-identifiable entities.

Also there seems to be an extra empty line at the end which is not needed.

#10 Updated by Andreas Müller 12 months ago

#11 Updated by Katja Luther 11 months ago

  • Target version changed from Release 5.12 to Release 5.13

#12 Updated by Katja Luther 10 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

now only titleCache (for identifiable entities) or uuid (for cdmBase objects) is shown

#13 Updated by Andreas Müller 9 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 100

I can't test for CdmBase as there is no class implementing the ICdmSource interface yet which is not identifiable.

I tested for Taxon and it worked as expected.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)