feature request #8686
Support CdmLink sources in bibliography
100%
Description
OriginalSourceBase has the new attribute cdmSource. In original source this can exist instead of citation. Currently it always links to DescriptionBase.
Original sources need to support this field as link to the according description. This should be similar to implement as sources with citation as both classes Reference and DescriptionBase to have a titleCache which is used for the link as text. Instead of linking to the reference page we now link to the description page.
Note: it looks like currently sources with null citation are not shown in bibliography this needs to be adapted as cdmlink sources should not have a citation.
Related issues
Associated revisions
ref #8686 showing CdmLink sources - initial implementation, needs improvement
ref #8686 fixing refactoring bug
ref #8686 removing linebreaks from description labels and simlifying render_cdm_description()
ref #8686 adding support for Taxon CdmLinks in "Bibliography"
ref #8686 removing fragment from link
History
#1 Updated by Andreas Müller almost 2 years ago
- Related to feature request #8673: Allow OriginalSource to link to other CDM objects added
#2 Updated by Andreas Müller almost 2 years ago
- Priority changed from New to Highest
#3 Updated by Andreas Müller almost 2 years ago
- Related to bug #8687: Description page must show all DescriptionElement subclasses added
#4 Updated by Andreas Müller almost 2 years ago
- Related to feature request #8688: Make OriginalSourceBase.cdmSource visible in TaxEditor added
#5 Updated by Andreas Kohlbecker almost 2 years ago
- Status changed from New to In Progress
#6 Updated by Andreas Müller almost 2 years ago
- Related to feature request #8724: Allow OriginalSource to link to Taxon added
#7 Updated by Andreas Müller almost 2 years ago
Support for link to taxa has been added in #8724. So we need to check or implement that also links to taxa are handled correctly.
#8 Updated by Andreas Müller almost 2 years ago
Further more there is a discussion if links to taxa should be direct links from the description(element) to the taxon. But this might be another ticket.
#9 Updated by Andreas Kohlbecker almost 2 years ago
Andreas Müller wrote:
Support for link to taxa has been added in #8724. So we need to check or implement that also links to taxa are handled correctly.
this has been implemented by cdm-dataportal|fec3fd41
#10 Updated by Andreas Kohlbecker almost 2 years ago
- Status changed from In Progress to Resolved
- Assignee changed from Andreas Kohlbecker to Andreas Müller
- % Done changed from 0 to 50
Note: The links to the taxa are having a fragment which directly focuses on the "Aggregation Description"
As far as I see, this ticket is solved completely. We have discussed the possibility to place the CdmSource in a separate pseudo feature block, but this is another story and should therefore be handled in a separate ticket. -> #8768
#11 Updated by Andreas Kohlbecker almost 2 years ago
- Related to task #8768: DISCUSS: place CdmLinks in a separate pseudo feature block? added
#12 Updated by Andreas Müller almost 2 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Andreas Kohlbecker
Andreas Kohlbecker wrote:
Note: The links to the taxa are having a fragment which directly focuses on the "Aggregation Description"
Linking to the fragment is dangerous as it presupposes that the link should go to the "aggregated description". This is not always the case. E.g. when using the link to a taxon for a distribution aggregation it is the wrong place. And there might be further links to taxa in future for which it may not be correct.
So I think we should remove the fragment. Or we need to do it more sophisticated (see were the link comes from etc.), but I don't know if it is worth doing this now. There are other priorities.
#13 Updated by Andreas Müller almost 2 years ago
An example could be shown here: http://test.e-taxonomy.eu/dataportal/preview/caryophyllales_spp/cdm_dataportal/taxon/a2f10926-c5db-42b5-ac8c-6ab704e1ed07#aggregation_descriptions but this will be removed soon
#14 Updated by Andreas Kohlbecker almost 2 years ago
- Status changed from Feedback to Closed
- % Done changed from 50 to 100
fragment removed from links - closing ticket.
