Project

General

Profile

feature request #8686

Support CdmLink sources in bibliography

Added by Andreas Müller 9 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
11/15/2019
Due date:
% Done:

100%

Severity:
critical

Description

OriginalSourceBase has the new attribute cdmSource. In original source this can exist instead of citation. Currently it always links to DescriptionBase.

Original sources need to support this field as link to the according description. This should be similar to implement as sources with citation as both classes Reference and DescriptionBase to have a titleCache which is used for the link as text. Instead of linking to the reference page we now link to the description page.

Note: it looks like currently sources with null citation are not shown in bibliography this needs to be adapted as cdmlink sources should not have a citation.


Related issues

Related to Edit - feature request #8673: Allow OriginalSource to link to other CDM objects Closed 11/09/2019
Related to Edit - bug #8687: Description page must show all DescriptionElement subclasses New 11/15/2019
Related to Edit - feature request #8688: Make OriginalSourceBase.cdmSource visible in TaxEditor Closed 11/15/2019
Related to Edit - feature request #8724: Allow OriginalSource to link to Taxon Closed 11/27/2019
Related to Edit - task #8768: DISCUSS: place CdmLinks in a separate pseudo feature block? New 12/13/2019

Associated revisions

Revision b6f0e806 (diff)
Added by Andreas Kohlbecker 9 months ago

ref #8673 extend initstrategy by cdmSource for ref #8686

Revision fe3a5674 (diff)
Added by Andreas Kohlbecker 9 months ago

ref #8686 showing CdmLink sources - initial implementation, needs improvement

Revision 9078b9c6 (diff)
Added by Andreas Kohlbecker 9 months ago

ref #8686 fixing refactoring bug

Revision ab025781 (diff)
Added by Andreas Kohlbecker 9 months ago

ref #8686 removing linebreaks from description labels and simlifying render_cdm_description()

Revision fec3fd41 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #8686 adding support for Taxon CdmLinks in "Bibliography"

Revision cbe9b085 (diff)
Added by Andreas Kohlbecker 7 months ago

ref #8686 removing fragment from link

History

#1 Updated by Andreas Müller 9 months ago

#2 Updated by Andreas Müller 9 months ago

  • Priority changed from New to Highest

#3 Updated by Andreas Müller 9 months ago

  • Related to bug #8687: Description page must show all DescriptionElement subclasses added

#4 Updated by Andreas Müller 9 months ago

#5 Updated by Andreas Kohlbecker 9 months ago

  • Status changed from New to In Progress

#6 Updated by Andreas Müller 8 months ago

#7 Updated by Andreas Müller 8 months ago

Support for link to taxa has been added in #8724. So we need to check or implement that also links to taxa are handled correctly.

#8 Updated by Andreas Müller 8 months ago

Further more there is a discussion if links to taxa should be direct links from the description(element) to the taxon. But this might be another ticket.

#9 Updated by Andreas Kohlbecker 8 months ago

Andreas Müller wrote:

Support for link to taxa has been added in #8724. So we need to check or implement that also links to taxa are handled correctly.

this has been implemented by cdm-dataportal|fec3fd41

#10 Updated by Andreas Kohlbecker 8 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 0 to 50

Note: The links to the taxa are having a fragment which directly focuses on the "Aggregation Description"

As far as I see, this ticket is solved completely. We have discussed the possibility to place the CdmSource in a separate pseudo feature block, but this is another story and should therefore be handled in a separate ticket. -> #8768

#11 Updated by Andreas Kohlbecker 8 months ago

  • Related to task #8768: DISCUSS: place CdmLinks in a separate pseudo feature block? added

#12 Updated by Andreas Müller 8 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Andreas Kohlbecker wrote:

Note: The links to the taxa are having a fragment which directly focuses on the "Aggregation Description"

Linking to the fragment is dangerous as it presupposes that the link should go to the "aggregated description". This is not always the case. E.g. when using the link to a taxon for a distribution aggregation it is the wrong place. And there might be further links to taxa in future for which it may not be correct.
So I think we should remove the fragment. Or we need to do it more sophisticated (see were the link comes from etc.), but I don't know if it is worth doing this now. There are other priorities.

#14 Updated by Andreas Kohlbecker 7 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 50 to 100

fragment removed from links - closing ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)