Project

General

Profile

feature request #8677

Add distribution aggregation to set subtree menu

Added by Andreas Müller 3 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
11/12/2019
Due date:
% Done:

100%

Severity:
major

Description

There is a new long running task "DisributionAggregation" which runs on a TaxonNodeFilter (#8651 and others). It should be available through the "Set for subtree menu", then open the configurator to configure and run the aggregation.

This is more or less a duplicate for #6352. Also have a look there for decisions to be made and problem descriptions.


Related issues

Related to Edit - feature request #5176: TransmissionEngineDistribution can run on selected taxa Closed 09/01/2015
Related to Edit - feature request #2625: [E+M Overview] Data aggregation functionalities for E+M (TransmissionEngine) Resolved 08/18/2014
Related to Edit - feature request #6352: Add Transmission Engine trigger to Admin menu Duplicate 01/20/2017
Related to Edit - feature request #6337: simple web ui to trigger the transmission engine distribution Rejected 01/17/2017
Related to Edit - task #8679: Further unify description aggregation methods In Progress 11/13/2019
Copied to Edit - task #8811: Open issues for "Add distribution aggregation to set subtree menu" New 01/16/2020

Associated revisions

Revision 26cfae1e (diff)
Added by Katja Luther 3 months ago

ref #8677: use uuid list instead of namedArea list in DistributionAggregationConfig

Revision 44ba5690 (diff)
Added by Katja Luther 3 months ago

ref #8677: add distribution aggregation as long running task to editor

Revision 68362152 (diff)
Added by Katja Luther 3 months ago

ref #8677: add distribution aggregation as long running task to editor - continue

Revision ff7c0745 (diff)
Added by Katja Luther 3 months ago

ref #8677: use changes DistributionAggregationConfig in controller

Revision 515150ac (diff)
Added by Katja Luther 3 months ago

ref #8677: revert a change of last commit

Revision f084efb4 (diff)
Added by Katja Luther 3 months ago

ref #8677: layout issues in aggregation dialog

Revision f67d22e7 (diff)
Added by Katja Luther 3 months ago

ref #8677: layout issues

Revision 26024c71 (diff)
Added by Katja Luther 3 months ago

ref #8677: layout issues - continue

Revision 70946cb4 (diff)
Added by Katja Luther 3 months ago

ref #8677: layout and labeling in aggregation config wizard

Revision 629035f4 (diff)
Added by Katja Luther 3 months ago

ref #8677: getNamedAreaDTO

Revision 25a98c3f (diff)
Added by Katja Luther 3 months ago

ref #8677: getNamedAreaDTO

Revision ef976e5a (diff)
Added by Katja Luther 3 months ago

ref #8677: set default selections, sort combos and other smaller issues

Revision c274b9cc (diff)
Added by Katja Luther 3 months ago

ref #8677: smaller issues

Revision 5373a0e9 (diff)
Added by Katja Luther 3 months ago

ref #8677: fix wrong type

Revision 724c463a (diff)
Added by Katja Luther 3 months ago

ref #8677: correct enabling and disabling of elements

Revision e6b6fbe5 (diff)
Added by Andreas Müller 3 months ago

ref #8677 minor tooltip changes

Revision cbf13384 (diff)
Added by Katja Luther 3 months ago

ref #8677: rank combo contains rank of selected taxon

History

#1 Updated by Andreas Müller 3 months ago

#2 Updated by Andreas Müller 3 months ago

  • Related to feature request #2625: [E+M Overview] Data aggregation functionalities for E+M (TransmissionEngine) added

#3 Updated by Andreas Müller 3 months ago

#4 Updated by Andreas Müller 3 months ago

  • Description updated (diff)

#5 Updated by Andreas Müller 3 months ago

  • Tags changed from transmission-engine-distribution to transmission-engine-distribution, euro+med, cichorieae

#6 Updated by Andreas Müller 3 months ago

#7 Updated by Katja Luther 3 months ago

In #6352 the mentioned configuration is:

  • lowerRank - default: UnknownRank = 5c4d6755-2cf6-44ca-9220-cccf8881700b (default and therefore can be omitted)
  • upperRank - default: Kingdom = fbe7109d-66b3-498c-a697-c6c49c686162
  • targetAreaLevel - no default but required
  • mode: default: byAreasAndRanks (the other options are not really need for the general user.

But the configurator also includes StatusOrder, we should discuss how the dialog for choosing this parameter should look like

#8 Updated by Andreas Müller 3 months ago

Katja Luther wrote:

In #6352 the mentioned configuration is:

  • lowerRank - default: UnknownRank = 5c4d6755-2cf6-44ca-9220-cccf8881700b (default and therefore can be omitted)
  • upperRank - default: Kingdom = fbe7109d-66b3-498c-a697-c6c49c686162
  • targetAreaLevel - no default but required
  • mode: default: byAreasAndRanks (the other options are not really need for the general user.

But the configurator also includes StatusOrder, we should discuss how the dialog for choosing this parameter should look like

The old ticket is build on the old configurator so a bit outdated.

However what we should offer for now is:

  • TaxonNodeFilter parameter

    • subtrees (TaxonNode) - if started from navigator by taxon node kontext menu, this should be prefilled
    • upperRank and lower rank, both are optional, but upperRank should not show ranks above the rank of the selected taxonnode (if any selected)
    • includeUnpublished (not yet fully implemented but definetely needed)
    • taxonNodes: if we want to allow to update single taxonNodes (without subtree) we can use this, maybe the UI can have a checkbox "on subtree/on taxon only" to switch between subtrees/taxonNodes
    • DON'T use
      • orderBy (it always uses TREEINDEX_DESC
      • includeRootNodes (on root nodes aggregation makes no sense, it always uses false)
      • areaFilter - for now not implemented, maybe will be implemented in future
      • distributionStatusFilter - not yet implemented but may be used in future
      • classifications - can be handled via subtrees (but no problems if also being used)
      • taxa - can be handled via taxonNodes (difference difficult to understand for users)
  • statusOrder: this is a link on all TermTree in the DB, which can be created with TaxEditor now. If empty the default ordering of the vocabulary for PresenceAbsenceTerm is taken, so if you want you can also add this vocabulary to the selection list

  • SourceMode: List of the available enum of same name, a human readable version is still missing

  • aggregatingSourceTypes: source types to use for aggregation, by default it is the both PrimaryXXX

Configuration that may change signature in future:

  • aggregation modes : byRank, byArea (this will change a bit in the configurator soon, so better wait with implementation)
  • superAreas (only if byArea is selected as aggregation mode): configuration may change soon, so better wait for new implementation
  • doClearExistingDescriptions: will fully empty existing aggregation description and create new descriptions, maybe useful if soemthing goes wrong, to be on the save side otherwise not
  • sourceUsage: this is coming soon

#9 Updated by Andreas Müller 3 months ago

I updated the above list

#10 Updated by Andreas Müller 3 months ago

  • Related to task #8679: Further unify description aggregation methods added

#11 Updated by Andreas Müller 3 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 40

Open issues:

  • highest rank should include the rank of the selected taxon
  • lowest rank should inlcude the highest rank (in case exactly 1 rank should be selected)
  • disable rank fields in case aggregation should run only on the 1 selected taxon (and not on subtree)
  • use message() for enumeration labels
  • remove semicolon at end of German title "Aggregations Konfiguration*;*"
  • pre-select of areas if area level is defined
  • i18n
  • source type selection per source mode

#12 Updated by Andreas Müller about 1 month ago

  • Copied to task #8811: Open issues for "Add distribution aggregation to set subtree menu" added

#13 Updated by Andreas Müller about 1 month ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Moved open issues to #8811

Review needed for this ticket.

#14 Updated by Andreas Müller about 1 month ago

  • % Done changed from 40 to 70

#15 Updated by Katja Luther about 1 month ago

  • Target version changed from Release 5.12 to Release 5.13

#16 Updated by Andreas Müller about 1 month ago

  • Target version changed from Release 5.13 to Release 5.12

#17 Updated by Andreas Müller about 1 month ago

use message() for enumeration labels

This seems not yet to be used by "Aggregation mode". I move this to follow up ticket.

#18 Updated by Andreas Müller about 1 month ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 70 to 100

source type selection per source mode

maybe there is a misunderstanding, I meant source type . There is still only 1 source type list which is therfore for both source modes I guess. I move this also to follow up.

The remaining issues work and the ticket can be closed.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)