Project

General

Profile

Actions
Copy link

task #8651

closed

Unify description aggregation methods (distribution and structured descriptive data)

Added by Andreas Müller about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Andreas Müller
Category:
cdmlib
Target version:
Release 5.11
Start date:
Due date:
% Done:

70%

Estimated time:
Severity:
normal
Tags:
euro+med transmission-engine-distribution additivity pesi

Description

Currentyl we have at least 2 methods/classes handling description aggregation, 1 for distribution data called TransmissionEngineDistribution, 1 for structured descriptive data currently handled in DescriptionDataSetService.

Both do similar things like aggregating descriptive data first on taxon level and in a second step aggregating descriptive data to higher rank taxa, flagging the created descriptions with flag "aggregated" and deleting older aggregation when aggregation is running anew.

Therefore both algorithms may use same base functionality and may learn from each other. Also the handling as long running task should be unified.

Related issues

Related to EDIT - bug #8670: Unwanted distribution aggregation/display on 2 levels ClosedAndreas Müller

Actions
Related to EDIT - task #8671: Distribution in E+M (BM) on different levelsRejectedAndreas Müller

Actions
Related to EDIT - feature request #5176: TransmissionEngineDistribution can run on selected taxaClosedAndreas Müller

Actions
Related to EDIT - feature request #2625: [E+M Overview] Data aggregation functionalities for E+M (TransmissionEngine)ClosedAndreas Müller

Actions
Related to EDIT - bug #8312: Test, fix, improve and run Transmission engine for E+MClosedAndreas Müller

Actions
Precedes EDIT - task #8679: Further unify description aggregation methods ClosedAndreas Müller

Actions
Actions
Copy link
 #1

Updated by Andreas Müller about 3 years ago

  • Subject changed from Unify description aggregation methods to Unify description aggregation methods (distribution and structured descriptive data)
Actions
Copy link
 #2

Updated by Andreas Müller about 3 years ago

  • Related to bug #8670: Unwanted distribution aggregation/display on 2 levels added
Actions
Copy link
 #3

Updated by Andreas Müller about 3 years ago

  • Related to task #8671: Distribution in E+M (BM) on different levels added
Actions
Copy link
 #4

Updated by Andreas Müller about 3 years ago

Actions
Copy link
 #5

Updated by Andreas Müller about 3 years ago

  • Status changed from New to In Progress
  • Priority changed from New to Highest
  • Target version changed from Release 5.12 to Release 5.11
  • % Done changed from 0 to 40

This is basically done but there are mutliple open tasks

Actions
Copy link
 #6

Updated by Andreas Müller about 3 years ago

  • Precedes task #8679: Further unify description aggregation methods added
Actions
Copy link
 #7

Updated by Andreas Müller about 3 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Müller to Andreas Kohlbecker
  • % Done changed from 40 to 70

We do now have a common base class and also the LongRunningTaskService used only 1 method (with config as parameter).

Further work is to be done and will be handled in #8679.

AK and PP as you have developed the orginal classes maybe you want to have a look to the new implementation. Afterwards you may close this ticket.

Before closing we should delete the redundant methods from DescriptiveDataSetService. PP can you do this?

Actions
Copy link
 #8

Updated by Patrick Plitzner about 3 years ago

Andreas Müller wrote:

Before closing we should delete the redundant methods from DescriptiveDataSetService. PP can you do this?

redundant methods are deleted.

Actions
Copy link
 #9

Updated by Andreas Kohlbecker about 3 years ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller

Andreas Müller wrote:

AK and PP as you have developed the orginal classes maybe you want to have a look to the new implementation. Afterwards you may close this ticket.

I tried to review the changes but it turned out to be quite time consuming, since a profound review would require having an in depth understanding of all the new requirements and decisions that have been made. I am having no objections against closing this issue as long as the result of the aggregation conforms to the expectations as as long as the performance is good.

Actions
Copy link
 #10

Updated by Andreas Müller about 3 years ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Andreas Kohlbecker wrote:

Andreas Müller wrote:

AK and PP as you have developed the orginal classes maybe you want to have a look to the new implementation. Afterwards you may close this ticket.

I tried to review the changes but it turned out to be quite time consuming, since a profound review would require having an in depth understanding of all the new requirements and decisions that have been made. I am having no objections against closing this issue as long as the result of the aggregation conforms to the expectations as as long as the performance is good.

I agree that it is difficult to review. I only wanted to link you to the changes in case you are interested.
The requirements did not really change, tests have not been changed (and helped me a lot). Only the algorithm is more generic now and also subtree aggregation is now possible (required a lot of changes).

I think we can close this ticket. There is a follow up: #8679

Actions
Copy link
 #11

Updated by Andreas Müller about 3 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
Actions
Copy link
 #12

Updated by Andreas Müller almost 2 years ago

  • Related to feature request #2625: [E+M Overview] Data aggregation functionalities for E+M (TransmissionEngine) added
Actions
Copy link
 #13

Updated by Andreas Müller almost 2 years ago

  • Related to bug #8312: Test, fix, improve and run Transmission engine for E+M added
Actions
Copy link

Also available in: Atom PDF