EDIT

Patrick, can you please check if the DNA search is somehow needed in additivity context? I don't expect it but just to be on the save side.

Patrick Plitzner wrote:

We used the specimen search for DNA in the Taxeditor. This still works so no problems from my side

Do you mean by this General > Import > Specimens ?

Can I use this import to search for specimens for all Taxa and names?

Andreas Müller wrote:

why did you give this to Lutz? I guess this was a mistake?

OOPS! Thank you for fixing this.

Andreas Kohlbecker wrote:

Patrick Plitzner wrote:

Andreas Kohlbecker wrote:

Patrick Plitzner wrote:

We used the specimen search for DNA in the Taxeditor. This still works so no problems from my side

Do you mean by this General > Import > Specimens ?

Can I use this import to search for specimens for all Taxa and names?

You can search Gbif and any BioCaseProvider by specifying parameters like taxon name, accession number, etc.

Katja was recently working on this import and added some new fields and configuration.

I was asking "Can I use this import to search for specimens for all Taxa and names?" because I am having the impression that the functionality which was removed from the ABCD file import is not exactly the same as implemented in the so called "Specimens Import". My experience is the following:

During the ABCD file import specimens (DNA, etc?) have been fetched from a BioCase provider and where used to enrich names, taxa and units which came from the file. So this is a batch operation affecting many taxa. I tried to use the "Specimens Import" to achieve the same result but without success.

This was something I implemented in GBOL context to get the DNA while importing the specimen searched via biocase.
The file import did not have this functionality before, therefore I removed the configuration possibility because I think if someone import something from a file, he or she only wants to import the information out of the file.

Katja Luther wrote:

Andreas Kohlbecker wrote:

Patrick Plitzner wrote:

Andreas Kohlbecker wrote:

Patrick Plitzner wrote:

We used the specimen search for DNA in the Taxeditor. This still works so no problems from my side

Do you mean by this General > Import > Specimens ?

Can I use this import to search for specimens for all Taxa and names?

You can search Gbif and any BioCaseProvider by specifying parameters like taxon name, accession number, etc.

Katja was recently working on this import and added some new fields and configuration.

I was asking "Can I use this import to search for specimens for all Taxa and names?" because I am having the impression that the functionality which was removed from the ABCD file import is not exactly the same as implemented in the so called "Specimens Import". My experience is the following:

During the ABCD file import specimens (DNA, etc?) have been fetched from a BioCase provider and where used to enrich names, taxa and units which came from the file. So this is a batch operation affecting many taxa. I tried to use the "Specimens Import" to achieve the same result but without success.

This was something I implemented in GBOL context to get the DNA while importing the specimen searched via biocase.
The file import did not have this functionality before, therefore I removed the configuration possibility because I think if someone import something from a file, he or she only wants to import the information out of the file.

OK, so the "Specimens Import" can not replace the remove functionality, right?

• So why don't we keep this potentially valuable functionality as optional feature (experimental?).
• Can,t this functionality be integrated into the Specimen import, so that i can fetch specimens for a set of taxa?
• The user should have the option to review and select the fetched specimens before they are finally persisted and associated with the existing cdm entities.

Andreas Kohlbecker wrote:

Katja Luther wrote:

Andreas Kohlbecker wrote:

Patrick Plitzner wrote:

Andreas Kohlbecker wrote:

Patrick Plitzner wrote:

We used the specimen search for DNA in the Taxeditor. This still works so no problems from my side

Do you mean by this General > Import > Specimens ?

Can I use this import to search for specimens for all Taxa and names?

You can search Gbif and any BioCaseProvider by specifying parameters like taxon name, accession number, etc.

Katja was recently working on this import and added some new fields and configuration.

I was asking "Can I use this import to search for specimens for all Taxa and names?" because I am having the impression that the functionality which was removed from the ABCD file import is not exactly the same as implemented in the so called "Specimens Import". My experience is the following:

During the ABCD file import specimens (DNA, etc?) have been fetched from a BioCase provider and where used to enrich names, taxa and units which came from the file. So this is a batch operation affecting many taxa. I tried to use the "Specimens Import" to achieve the same result but without success.

This was something I implemented in GBOL context to get the DNA while importing the specimen searched via biocase.
The file import did not have this functionality before, therefore I removed the configuration possibility because I think if someone import something from a file, he or she only wants to import the information out of the file.

OK, so the "Specimens Import" can not replace the remove functionality, right?

• So why don't we keep this potentially valuable functionality as optional feature (experimental?).
• Can,t this functionality be integrated into the Specimen import, so that i can fetch specimens for a set of taxa?
• The user should have the option to review and select the fetched specimens before they are finally persisted and associated with the existing cdm entities.

For the specimen search the user can choose which of the found specimen should be imported and in this context it is still possible to choose the DNA search for the selected specimen.

I removed this from file import because it created problems which I could not solve as fast as it should be solved. But when the problems solved we can reintegrate it to the file import. It is only two lines of code

Katja Luther wrote:

...

... But when the problems solved we can reintegrate it to the file import. It is only two lines of code

This is just like music in my ears ;-)

As mentioned by Katja before I do not understand why we need it. It is work to keep such things running and as Katjas says: if someone runs a file import he/she wants to import the file and not data from an external webservice. If the later is the case you can use the webservice import.

Also we have to have in minde that file based ABCD import does not really have a use-case (beside workshop setups). So we should not spend to much time to make it sophisticated. The reason why the lines were removed I think was that it created a mixture between pure IO and ext. And therefore it was more difficult and not so clean to run tests on it. Something that we should keep in mind.

I suggest to close this ticket and if needed open a new ticket to discuss the necessity (and best implementation) of an integrated DNA import in the ABCD file import

I don't insist in keeping this function in the ABCD import. I only feared that we lose valuable functionality. therefore I tried to find out if General > Import > Specimens serves the same functionality just by asking questions here in the ticket. But this obviously did not work well, since i never got the answer I was aiming for. Direct verbal communication is often so much more efficient. So I did some tests with the editor. As far as I see, the specimen import exactly does that, what was running in the ABCD import under the hood.

So I agree with removing these two lines of code completely.