Project

General

Profile

feature request #8595

Create description detail page

Added by Patrick Plitzner 11 months ago. Updated 5 months ago.

Status:
Closed
Priority:
New
Category:
cdm-dataportal
Target version:
Start date:
10/16/2019
Due date:
% Done:

100%

Severity:
normal
Tags:

Description

Create a description detail page like it already exists for e.g. specimens.

From additivity wiki:

Wir brauchen eine Portal-Detailseite für Descriptions

  • Von der Taxonseite gibt es einen Link unterhalb der Aggr.Description, der zu einer Seite mit einer Liste aller Quellen zeigt
  • Die Quellen sind die geklonten SpecimenDescriptions, die man einzeln anklicken kann.
  • Auf der Taxonseite sollen schon Daten erscheinen, so wie jetzt schon für das Feature Description
  • Quellenlink zu den SpecimenDescription soll nicht der TitleCache der Description sein, sondern gekürzt z.B. das SpecimenLabel (Collection+AccNo)
  • Geklonte SpecimenDescription brauchen Datum und Dataset im Titel
  • Keine langen Zeilen als Link, sondern Text in schwarz und dahinter ein Link-Icon
  • Categorical Data soll mit Count angezeigt werden.

Related issues

Related to Edit - feature request #8596: Add a list of descriptions to the taxon page Closed 10/16/2019
Precedes Edit - bug #8739: remaining issues for description detail page Closed

Associated revisions

Revision e170a53e (diff)
Added by Patrick Plitzner 11 months ago

ref #8595, #8596 Show list of aggr. descriptions on taxon page and link to detail page

Revision 8b384421 (diff)
Added by Patrick Plitzner 11 months ago

ref #8595 Show clickable sources on description detail page

Revision af9984b8 (diff)
Added by Patrick Plitzner 11 months ago

ref #8595 Add sources to description init strategy

Revision 9d88232c (diff)
Added by Patrick Plitzner 11 months ago

ref #8595 Fix taxon page TOC

Revision 67ce7111 (diff)
Added by Patrick Plitzner 11 months ago

ref #8595 Show associated specimen on description detail page

  • drupal formatting code

Revision 882e2c02 (diff)
Added by Patrick Plitzner 11 months ago

ref #8595 Show aggregation description elements on taxon page

Revision 4b428921 (diff)
Added by Patrick Plitzner 11 months ago

ref #8595 Show count for StateData + only show data when state!=null

Revision 1601d218 (diff)
Added by Patrick Plitzner 11 months ago

ref #8595 Change header label for aggr. descriptions

Revision 074747bf (diff)
Added by Patrick Plitzner 11 months ago

ref #8595 Show characters in italic instead of bold

Revision d61e49ac (diff)
Added by Patrick Plitzner 11 months ago

ref #8595 Show specimen titleCache for source descriptions

Revision 18110d8c (diff)
Added by Patrick Plitzner 11 months ago

ref #8595 Fix compile error

Revision 5548f6bc (diff)
Added by Patrick Plitzner 11 months ago

ref #8595 Fix compile error

Revision 16515bdf (diff)
Added by Patrick Plitzner 10 months ago

ref #8595 Add creation date for cloned source descriptions

Revision c7e854d5 (diff)
Added by Patrick Plitzner 10 months ago

ref #8595 Only show feature table when data available

Revision 5ac909c0 (diff)
Added by Patrick Plitzner 10 months ago

ref #8595 Only show available datasets label when data available

Revision eb89b236 (diff)
Added by Patrick Plitzner 10 months ago

ref #8595 Fix feature table when no data available

Revision 1b7e1801 (diff)
Added by Patrick Plitzner 10 months ago

ref #8595 Fix moved method invocation

Revision 06d7ad52 (diff)
Added by Patrick Plitzner 10 months ago

ref #8595 Fix potential null pointer

Revision 20245cca (diff)
Added by Patrick Plitzner 10 months ago

ref #8595 Do not filter description sources by class

History

#1 Updated by Patrick Plitzner 11 months ago

  • Status changed from New to Resolved

#2 Updated by Patrick Plitzner 11 months ago

  • Assignee changed from Patrick Plitzner to Andreas Kohlbecker
  • % Done changed from 0 to 50

#3 Updated by Andreas Kohlbecker 11 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Kohlbecker to Patrick Plitzner

It is hard to review this ticket since the requirements to the layout of the page are missing in the ticket. Please add the full specification as discussed in the project (Meeting notes etc....)

#4 Updated by Andreas Müller 11 months ago

There are still many open issues (most of them discussed in additivity). So we need a follow up ticket. This ticket as implement for 5.11 seems to be more about the existence of the page (and maybe correct URL syntax etc.). Layout (and ordering) definetly needs further work.

@PP: Maybe it is a no.brainer to remove the full description from each source again (as discussed in last meeting), this may make the page look much nicer already

#5 Updated by Andreas Müller 11 months ago

#6 Updated by Patrick Plitzner 11 months ago

  • Description updated (diff)
  • Assignee changed from Patrick Plitzner to Andreas Kohlbecker

Added specs from additivity wiki

#7 Updated by Patrick Plitzner 11 months ago

  • Description updated (diff)

#8 Updated by Andreas Kohlbecker 11 months ago

  • Assignee changed from Andreas Kohlbecker to Patrick Plitzner

Code review notes:

  • description.inc#1179 : $enclosing_tag = cdm_feature_block_element_tag_name($feature_block_settings); is unused, this breaks the feature block setting as_list (old bug)
  • pages.inc : render_cdm_description_link() & compose_cdm_description() must not use <i> and <br> to apply styling, all styling must be allied through css

These findings are not critical and should be solved for the next release.

#9 Updated by Patrick Plitzner 11 months ago

  • Target version changed from Release 5.11 to 287

#10 Updated by Patrick Plitzner 10 months ago

  • Description updated (diff)

#11 Updated by Patrick Plitzner 10 months ago

  • Description updated (diff)
  • Status changed from Feedback to Resolved

#13 Updated by Patrick Plitzner 10 months ago

  • Description updated (diff)

#14 Updated by Patrick Plitzner 10 months ago

  • Description updated (diff)

#15 Updated by Andreas Kohlbecker 10 months ago

  • Description updated (diff)

#16 Updated by Andreas Kohlbecker 10 months ago

  • Description updated (diff)

#17 Updated by Andreas Kohlbecker 10 months ago

  • Description updated (diff)

#18 Updated by Patrick Plitzner 10 months ago

  • Description updated (diff)

#19 Updated by Patrick Plitzner 10 months ago

  • Related to bug #8739: remaining issues for description detail page added

#20 Updated by Patrick Plitzner 10 months ago

  • Related to deleted (bug #8739: remaining issues for description detail page)

#21 Updated by Patrick Plitzner 10 months ago

  • Precedes bug #8739: remaining issues for description detail page added

#22 Updated by Patrick Plitzner 10 months ago

  • Description updated (diff)

#23 Updated by Patrick Plitzner 10 months ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

created new ticket for remaining issues and discussion -> #8739

#24 Updated by Andreas Müller 9 months ago

  • Target version changed from 287 to Release 5.12

#25 Updated by Andreas Müller 5 months ago

Geklonte SpecimenDescription brauchen Datum und Dataset im Titel => this is not yet fully implemented. Created new ticket: #8967

#26 Updated by Andreas Müller 5 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • % Done changed from 50 to 100

All the rest seems to be fixed or even improved in the meanwhile. So I close this ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)