Project

General

Profile

Actions
Copy link

feature request #8572

closed

Rule considered configurable

Added by Katja Luther over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
New
Assignee:
Katja Luther
Category:
taxeditor
Target version:
Release 5.11
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

Rule considered is not needed in all projects, therefore it should be configurable whether it should be shown or not

Files

picture667-1.png (1.59 KB) picture667-1.png Andreas Müller, 11/01/2019 10:03 AM

Related issues

Related to EDIT - feature request #8410: Add nomenclatural code edition to ruleConsidered in TaxEditorClosedKatja Luther

Actions
Actions
Copy link
 #1

Updated by Katja Luther over 3 years ago

Actions
Copy link
 #2

Updated by Katja Luther over 3 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Katja Luther over 3 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review

Actions
Copy link
 #4

Updated by Katja Luther over 3 years ago

  • % Done changed from 0 to 70
Actions
Copy link
 #5

Updated by Andreas Müller over 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Please use human readable version for rule considered. E.g. by using getMessage().

@AK: which method do you use in vaadin editor?

Update: Sorry, wrong ticket, see #8410#note-8

Actions
Copy link
 #6

Updated by Andreas Müller over 3 years ago

The filtering does not work! Neither for project prefs nor for local prefs => see #8572#note-9

Actions
Copy link
 #7

Updated by Andreas Müller over 3 years ago

  • % Done changed from 70 to 50

If "rule considered" is not switched on also "Code edition" should be automatically be switched off in the preferences. This is in accordance with the name details view: if you do not enter a rule considered you can also not select a code editon.

Actions
Copy link
 #8

Updated by Andreas Müller over 3 years ago

Please have some more indentation for the sub-preferences on the name details view. Currently it is only ~1/3 of the checkbox. I think the checkbox of the sub-preference should start at about the position as the text for the main preferences

Actions
Copy link
 #9

Updated by Andreas Müller over 3 years ago

Andreas Müller wrote:

The filtering does not work! Neither for project prefs nor for local prefs

A sorry this was probably a mistake. I set it for name relationship but worked on name status

Actions
Copy link
 #10

Updated by Andreas Müller over 3 years ago

Andreas Müller wrote:

Please have some more identation for the sub-preferences on the name details view. Currently it is only ~1/3 of the checkbox. I think the checkbox of the sub-preference should start at about the position as the text for the main preferences

By the way: the label for "Secundum enabled (editing in d....) is not fully shown for some reason

Actions
Copy link
 #11

Updated by Katja Luther over 3 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

I think all open issues are fixed.

  • sub preference have more indent
  • the label for "Secundum enabled..." is fully displayed
  • enabling/disabling of subpreferences
Actions
Copy link
 #12

Updated by Andreas Müller over 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 90

Personally I would give even more indentation (see #8572#note-8). But this is up to you.

Generally we can close the ticket.

Actions
Copy link
 #13

Updated by Katja Luther over 3 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100
Actions
Copy link

Also available in: Atom PDF