Project

General

Profile

feature request #8572

Rule considered configurable

Added by Katja Luther 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
09/27/2019
Due date:
% Done:

100%

Severity:
normal

Description

Rule considered is not needed in all projects, therefore it should be configurable whether it should be shown or not

picture667-1.png View (1.59 KB) Andreas Müller, 11/01/2019 10:03 AM


Related issues

Related to Edit - feature request #8410: Add nomenclatural code edition to ruleConsidered in TaxEditor Closed 07/26/2019

Associated revisions

Revision da5756d8 (diff)
Added by Katja Luther 8 months ago

ref #8572: code cleaning and rule considered configurable

Revision 077e5556 (diff)
Added by Katja Luther 8 months ago

ref #8572: minor

Revision 5006c242 (diff)
Added by Katja Luther 7 months ago

ref #8572: rule considered and code edition enable/disable in preferences

Revision 54c2a6e5 (diff)
Added by Katja Luther 7 months ago

ref #8572: some more indention for sub preferences

History

#1 Updated by Katja Luther 8 months ago

#2 Updated by Katja Luther 8 months ago

  • Status changed from New to In Progress

#3 Updated by Katja Luther 8 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review

#4 Updated by Katja Luther 8 months ago

  • % Done changed from 0 to 70

#5 Updated by Andreas Müller 7 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Please use human readable version for rule considered. E.g. by using getMessage().

@AK: which method do you use in vaadin editor?

Update: Sorry, wrong ticket, see #8410#note-8

#6 Updated by Andreas Müller 7 months ago

The filtering does not work! Neither for project prefs nor for local prefs => see #8572#note-9

#7 Updated by Andreas Müller 7 months ago

  • % Done changed from 70 to 50

If "rule considered" is not switched on also "Code edition" should be automatically be switched off in the preferences. This is in accordance with the name details view: if you do not enter a rule considered you can also not select a code editon.

#8 Updated by Andreas Müller 7 months ago

Please have some more indentation for the sub-preferences on the name details view. Currently it is only ~1/3 of the checkbox. I think the checkbox of the sub-preference should start at about the position as the text for the main preferences

#9 Updated by Andreas Müller 7 months ago

Andreas Müller wrote:

The filtering does not work! Neither for project prefs nor for local prefs

A sorry this was probably a mistake. I set it for name relationship but worked on name status

#10 Updated by Andreas Müller 7 months ago

Andreas Müller wrote:

Please have some more identation for the sub-preferences on the name details view. Currently it is only ~1/3 of the checkbox. I think the checkbox of the sub-preference should start at about the position as the text for the main preferences

By the way: the label for "Secundum enabled (editing in d....) is not fully shown for some reason

#11 Updated by Katja Luther 7 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

I think all open issues are fixed.
* sub preference have more indent
* the label for "Secundum enabled..." is fully displayed
* enabling/disabling of subpreferences

#12 Updated by Andreas Müller 7 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 90

Personally I would give even more indentation (see #8572#note-8). But this is up to you.

Generally we can close the ticket.

#13 Updated by Katja Luther 7 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)