Project

General

Profile

bug #8547

Default type of a newly created inReference should depend on the type of the reference

Added by Katja Luther over 1 year ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
09/17/2019
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

mail from WB:

Hallo,
ich habe ausgehend vom Details view eine neue NomReferenz (Artikel) eingegeben. Dabei musste ich auch das Journal neu eingeben. Nach der Rückkehr aus der Journal Eingabe erscheint der gesamte Eintrag im Reference Editor im Suchfeld, aber nicht in der Liste. Wenn ich dann Ok sage, erscheint er auch nicht im Details view und der Eintrag im Name Editor hat auch kein Sternchen – kann also auch nicht speichern. Nach einem Refresh des Details View ist der Eintrag auch nicht da. Wenn ich dann aber die NomRef-Auswahl wieder aufrufe, ist der komplette Eintrag in der Liste und kann normal eingetragen werden.
Herzlichen Gruß
Walter

Hallo,
ich habe das Journal aus einer Neueingabe eines Artikels neu eingegeben. Nach Abschluss der Journal-Eingabe und der Artikeleingabe war das Suchfeld mit dem vollst. Artikel gefüllt, nicht aber die Auswahlliste darunter. Die Eingabe konnte also dann nicht in den Details-View des Namens übernommen werden. Artikel und Journal wurden aber korrekt abgespeichert, sie konnten mit einer neuen Auswahl aus dem Details-View dann eingetragen werden.
HG
W


Related issues

Copied to Edit - feature request #9342: Only show specific reference types for inreferences New 12/03/2020

Associated revisions

Revision 2d07da9a (diff)
Added by Katja Luther 5 months ago

ref #8547: default type of inreference depending on ref type

Revision 2c0bb8e3 (diff)
Added by Andreas Müller 3 months ago

ref #8547 make ReferenceType.inReferenceContraints() a list

Revision 46418777 (diff)
Added by Andreas Müller 3 months ago

ref #8547 make ReferenceType.inReferenceContraints() a list (adapt vaadin)

Revision 76ee473f (diff)
Added by Andreas Müller 3 months ago

ref #8547 add inreference type for Proceedings

History

#1 Updated by Katja Luther over 1 year ago

this problem appears only when the newly created in-reference is not of the type journal.

#2 Updated by Katja Luther over 1 year ago

  • Subject changed from newly created journal does not appear in selection dialog to newly created article with new journal does not appear in selection dialog
  • Description updated (diff)

#3 Updated by Katja Luther over 1 year ago

  • Target version changed from Release 5.10 to Release 5.11

#4 Updated by Andreas Müller over 1 year ago

  • Priority changed from New to Highest

#5 Updated by Katja Luther over 1 year ago

  • Status changed from New to Feedback
  • Assignee changed from Katja Luther to Andreas Müller

Katja Luther wrote:

this problem appears only when the newly created in-reference is not of the type journal.

I think the problem is that the selection dialog for the in reference of an article shows only journals and when the newly created reference is not of this type it does not show up.

Could you please check, if this is right

#6 Updated by Andreas Müller over 1 year ago

Katja Luther wrote:

Katja Luther wrote:

this problem appears only when the newly created in-reference is not of the type journal.

I think the problem is that the selection dialog for the in reference of an article shows only journals and when the newly created reference is not of this type it does not show up.

Could you please check, if this is right

But do we really allow to enter some other ref type if article is the section reference? We shouldn't I think. Definetely by default Journal should be preselected. But maybe changing ref type should not be possible at all in this case.
Also I do not really think that Walter did choose something else. But maybe, if General is stil the default, in this case he might have forgotten to change the type.
I added Walter to cc so he can comment on this.

#7 Updated by Andreas Müller over 1 year ago

  • Status changed from Feedback to New
  • Assignee changed from Andreas Müller to Katja Luther

Is there a reason why you did set as "Feedback" on me?

#8 Updated by Katja Luther over 1 year ago

  • Target version changed from Release 5.11 to Release 5.12

#9 Updated by Katja Luther about 1 year ago

  • Target version changed from Release 5.12 to Release 5.13

#10 Updated by Andreas Müller 12 months ago

  • Target version changed from Release 5.13 to Release 5.14

#11 Updated by Katja Luther 11 months ago

  • Target version changed from Release 5.14 to Release 5.15

#12 Updated by Katja Luther 11 months ago

  • Target version changed from Release 5.15 to Release 5.18

#13 Updated by Katja Luther 5 months ago

  • Subject changed from newly created article with new journal does not appear in selection dialog to Default type of a newly created inReference should be depend on the type of the reference
  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

The default type of the newly created inReference depends of the reference now. Please review.
Updated the title.

#14 Updated by Andreas Müller 5 months ago

  • Subject changed from Default type of a newly created inReference should be depend on the type of the reference to Default type of a newly created inReference should depend on the type of the reference

#15 Updated by Andreas Müller 5 months ago

  • % Done changed from 0 to 50

#16 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

For "Section" the type is "InProceedings" now which is generally false. We should use "General" as before or even better force the user to explicitly choose a type as discussed recently in other context.

#17 Updated by Andreas Müller 3 months ago

I got the following NPE when playing around with the dialog:

last remote method : http://test.e-taxonomy.eu:80/cdmserver/rem_conf_am/remoting/reference.service
last remote request client time : 2020-11-27T17:22:52.882
last remote request response header time : Fri, 27 Nov 2020 17:22:52 GMT
client error time : 2020-11-27T17:22:54.278
login : admin
editor version : 5.18.0.202011270848
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 5.18.5.0.20201103
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
    at eu.etaxonomy.taxeditor.ui.dialog.selection.ReferenceSelectionDialog.getNewEntityWizard(ReferenceSelectionDialog.java:258)
    at eu.etaxonomy.taxeditor.ui.dialog.selection.AbstractFilteredCdmResourceSelectionDialog$2.widgetSelected(AbstractFilteredCdmResourceSelectionDialog.java:443)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
    at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
    at org.eclipse.jface.window.Window.open(Window.java:794)
    at eu.etaxonomy.taxeditor.ui.dialog.selection.AbstractFilteredCdmResourceSelectionDialog.getUuidAndTitleCacheSelectionFromDialog(AbstractFilteredCdmResourceSelectionDialog.java:152)
    at eu.etaxonomy.taxeditor.ui.dialog.selection.AbstractFilteredCdmResourceSelectionDialog.getSelectionFromDialog(AbstractFilteredCdmResourceSelectionDialog.java:133)
    at eu.etaxonomy.taxeditor.ui.dialog.selection.NomenclaturalReferenceSelectionDialog.select(NomenclaturalReferenceSelectionDialog.java:127)
    at eu.etaxonomy.taxeditor.ui.dialog.selection.SelectionDialogFactory.getSelectionFromDialog(SelectionDialogFactory.java:98)
    at eu.etaxonomy.taxeditor.ui.selection.EntitySelectionElement.widgetSelected(EntitySelectionElement.java:239)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:249)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
    at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
    at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
    at eu.etaxonomy.taxeditor.Application.start(Application.java:20)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1519)

#18 Updated by Andreas Müller 3 months ago

Andreas Müller wrote:

For "Section" the type is "InProceedings" now which is generally false. We should use "General" as before or even better force the user to explicitly choose a type as discussed recently in other context.

Also Proceedings have "General" but should have "Print Series" accoring to UI interface.

And for WebPage I would again take WebPage as default. Usually this is a specific page which is part of a more general WebPage. It also could be database but this is up to the user to decide. Not so often used anyway.

#19 Updated by Katja Luther 3 months ago

The type of the in-reference depends on ReferenceType.inReferenceContraints, we should add the constraints mentioned above.

#20 Updated by Katja Luther 3 months ago

Andreas Müller wrote:

I got the following NPE when playing around with the dialog:

This should be fixed now.

#21 Updated by Katja Luther 3 months ago

Katja Luther wrote:

The type of the in-reference depends on ReferenceType.inReferenceContraints, we should add the constraints mentioned above.

AM:

Hallo, diese Methode ist von Andreas K. angelegt worden, daher müsste er da auch nochmal drauf schauen. Kritisch finde ich das handling von Book in Journal. Mit diesen extremen Ausnahmen handelt man sich eine Reihe Probleme ein. Ich denke da macht es mehr Sinn, diese Ausnahme irgendwie anders zu behandelt (z.B. doch als Article mit entsprechender Annotation oder als Book in PrintSeries) oder so, aber das müsste man mit den Taxonomen nochmal besprechen und durchdenken, was das für Probleme bereitet in Eingabe und Ausgabe UIs sowie beim Formattieren. Außer anscheinend Henning hat meines Wissens noch niemand eine solche Andorderung gehabt.
Auch sollte man bei >1 Rückgabetypen drüber nachdenken, ob das nicht zumindeste eine Liste sein sollte, um eine gewisse Wertung zu haben. Falls wir bei Journal als möglichkeit bleiben, wäre es ja extrem wichtig, PrintSeries aber als den absoluten Standard festzulegen.
Kannst du das ins Ticket rüberziehen? Hier geht es schnell verloren.

AK:

ich kenne ähnliche Fälle auch aus der Zoologie (90er Jahre) allerdings weiß ich nicht welchem Typ diese Preprint-Auszüge aus dem Journal in diesen Fällen hatten. Ob man diese Bücher als Article handhaben kann hängt natürtlich davon ab, welche Metadaten gebraucht werden, Article ist da sicherlich nicht ausreichend.

AM:
Das stimmt wahrscheinlich. Im exakten Sinne sind sie aber auch nicht in einem Journal veröffentlicht. Dann passt evtl. besser die PrintSeries, welcher ja ein loser Zusammenhang ist.
Aber das sollten wir unbedingt die User nochmal fragen, insbesondere auch Leute wie Norbert, der sich ja mit sowas sehr gut auskennt.
... also vielleicht müssen wir auch wirklich Journal für diesen Typ zusätzlich zulassen, wenn das wirklich öfters vorkommt.

AK:
Ich denke dass man die Definition von Journal weiter fassen muss. Ein Journal kann in seltenen Fällen auch ein preprint Excerpt als Büchlein herausgeben. Wobei mit Büchlein eher ein eingeständiges kleines Heftchen, als ein dicker Schinken, gemeint ist. Vielleicht liegt auch hierin die Unterscheidung Büchlein vs Buch?

#22 Updated by Andreas Müller 3 months ago

ReferenceType.inReferenceContraints() is a list now, so the first element in the list is the default preferred type. Additionally it should be used in the TaxEditor for filling the combobox, but don't forget to always also add "Generic".

#23 Updated by Andreas Müller 3 months ago

#24 Updated by Andreas Müller 3 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 50 to 100

This is fixed as far as now by default the most likely reference type is now prefilled for inreferences.

There is a follow up ticket to fill the combo box only with possible values for inreference types: #9342

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)