Project

General

Profile

task #8543

overcome distinction of annotation and other foonotes

Added by Andreas Kohlbecker 11 months ago. Updated 9 days ago.

Status:
Closed
Priority:
New
Category:
cdm-dataportal
Target version:
Start date:
09/11/2019
Due date:
% Done:

100%

Severity:
normal

Description

The distinction of annotation and other foonotes is causing problems as reported in #2602 and in #4964

Moreover it is also complicating the code and is frequently a source of errors.

consequently the different settings in admin/config/cdm_dataportal/settings/layout no not make sense anymore:

These settings are not used in any portal with the only exception of the phycobank portal where annotation footnotes have been switched off. Even there this is not really needed. So there is no reason for keeping these settings.

picture915-1.png View (51.7 KB) Andreas Kohlbecker, 07/29/2020 03:11 PM


Related issues

Related to Edit - bug #2602: Taxon synonymy: type designation footnotes rendered together with taxon_page_synonymy footnotes Worksforme 06/03/2015
Related to Edit - bug #4964: footnotes for taxonRelationship sources and annotations should be rendered together New

Associated revisions

Revision f814b2cd (diff)
Added by Andreas Kohlbecker 11 months ago

ref #8543 documenting foonote-key-suggestino handling in some functions

Revision f95bf1b1 (diff)
Added by Andreas Kohlbecker 12 days ago

ref #8543 refactoring theme_cdm_annotation_footnotes to normal function

Revision 18a83116 (diff)
Added by Andreas Kohlbecker 12 days ago

ref #8543 refactoring theme_cdm_annotation_footnotes to normal function - 2

Revision b810c46f (diff)
Added by Andreas Kohlbecker 12 days ago

ref #8543 refactoring theme_cdm_footnotes to normal function

Revision e9cc637a (diff)
Added by Andreas Kohlbecker 12 days ago

ref #8543 refactoring cdm_annotations to normal function

Revision 9ece0f7b (diff)
Added by Andreas Kohlbecker 11 days ago

ref #8543 refactoring cdm_footnotes to normal function

Revision 8e677507 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 improving zen_dataportal theme detection

Revision bc7f81f1 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 removing unused footnote related theme functions

Revision 963f9de3 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 replacing theme_cdm_footnote_key() by cdm_footnote_key()

Revision 34fe810d (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 replacing theme_cdm_footnote_key() by cdm_footnote_key() - bug fix

Revision b56a52e4 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 replacing theme_cdm_footnote_key() by cdm_footnote_key() - bug fix

Revision c57342f4 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 renaming function cdm_entities_annotations_as_footnotekeys() -> cdm_entities_annotations_footnotekeys()

Revision 8ae85ae4 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 renaming theme_cdm_entities_annotations_as_footnotekeys() -> cdm_entities_annotations_as_footnotekeys()

Revision d0be436a (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 renaming theme_cdm_entities_annotations_as_footnotekeys() -> cdm_entities_annotations_as_footnotekeys() - bug fix

Revision dd0767b6 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 moving footnote functions to separate inc file

Revision fe064e2d (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 removing useless code and cleaner footnote functions

Revision d8069342 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 further harmonizing footnote functions

Revision fc6585f9 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 renaming and documentation towards unification of annotation and other footnotes

Revision 3c4a5472 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 further unification of annotation and source handling

Revision aa139fac (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 further unification of annotation and source footnotes and fixing separator bug

Revision 61658f41 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 unification of annotation and source footnotes in synonymy

Revision 39ae8ca4 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 unification of annotation and source footnotes for related taxa etc.

Revision f5c014af (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 unification of annotation and source footnotes for related taxa etc. - fixing typo in array key

Revision 51ace96f (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 deprecating, cleaning up and documentation of footnote functions

Revision a067cc04 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 avoiding separation of annotation and source footnotes by always passing defined footnote_list_key_suggestion

Revision b59fbdfa (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 introducing default footnoteListKey in RenderHints

Revision e31c69e3 (diff)
Added by Andreas Kohlbecker 10 days ago

ref #8543 testing for FOOTNOTE_KEY_SUFFIX_ANNOTATIONS in use by throwing an exception

Revision d0d0a092 (diff)
Added by Andreas Kohlbecker 9 days ago

ref #8543 complete removal of annotation footnote code, also removing deprecated methods

Revision 1c30a02b (diff)
Added by Andreas Kohlbecker 9 days ago

ref #8543 fix missing footnoteListKey default fallback

Revision 9f9fe101 (diff)
Added by Andreas Kohlbecker 9 days ago

ref #8543 refactoring: renaming variables & moving functions to other files

Revision 6f4506af (diff)
Added by Andreas Kohlbecker 9 days ago

ref #8543 removing settings to generally disable footnotes

Revision 8c14d0ea (diff)
Added by Andreas Kohlbecker 9 days ago

ref #8543 testing for erroneous usage of the dafault footnoteListKey

Revision f2e3c080 (diff)
Added by Andreas Kohlbecker 9 days ago

ref #8543 moving name_relationship_footnote_markup() to footnotes.inc

Revision fef841d4 (diff)
Added by Andreas Kohlbecker 9 days ago

ref #8543 moving more *_footnote_markup() to footnotes.inc

Revision 8202a2c0 (diff)
Added by Andreas Kohlbecker 9 days ago

ref #8543 option to block footnote list key to avoid foonote keys in odd places like warnings

Revision 97fada02 (diff)
Added by Andreas Kohlbecker 9 days ago

ref #8543 more specific xpath for footnotes

History

#1 Updated by Andreas Kohlbecker 11 months ago

  • Related to bug #2602: Taxon synonymy: type designation footnotes rendered together with taxon_page_synonymy footnotes added

#2 Updated by Andreas Kohlbecker 11 months ago

  • Related to bug #4964: footnotes for taxonRelationship sources and annotations should be rendered together added

#3 Updated by Andreas Kohlbecker 10 days ago

#4 Updated by Andreas Kohlbecker 9 days ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Target version changed from Unassigned CDM tickets to Release 5.17
  • % Done changed from 0 to 40

#5 Updated by Andreas Kohlbecker 9 days ago

  • % Done changed from 40 to 50

completed

#6 Updated by Andreas Kohlbecker 9 days ago

  • Status changed from In Progress to Closed
  • % Done changed from 50 to 100

verified by test and checking the result of the drupal dbupdate

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)