bug #8517
closedSpecimenOrObservation: data from protected titleCache missig in portal pages
100%
Description
The following portal pages are missing to show data from protected SpecimenOrObservation.titleCaches:
- Registration page (e.g: https://www.phycobank.org/cdm_dataportal/registration?identifier=http%3A//phycobank.org/9924)
- specimen page (e.g.: https://www.phycobank.org/cdm_dataportal/occurrence/77d83237-a5ae-4a30-810f-61497ce040ee)
Related issues
Updated by Andreas Kohlbecker over 4 years ago
- Category changed from cdm-dataportal to cdm
this is actually a problem in the DerivedUnitFacadeCacheStrategy
which misses to respect protected FieldUnit
title caches.
Updated by Andreas Kohlbecker over 4 years ago
- Status changed from New to Resolved
- Assignee changed from Andreas Kohlbecker to Andreas Müller
- % Done changed from 0 to 50
please review
Updated by Andreas Müller over 4 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Andreas Kohlbecker
This seems to work but handling the protected title cache of the field unit in the derivedunit cachestrategy to me does not look so clean.
Shouldn't instead the getFieldData method of the fieldunit cachestrategy handle the protected cache?
Updated by Andreas Kohlbecker over 4 years ago
- Assignee changed from Andreas Kohlbecker to Andreas Müller
Andreas Müller wrote:
This seems to work but handling the protected title cache of the field unit in the derivedunit cachestrategy to me does not look so clean.
Shouldn't instead the getFieldData method of the fieldunit cachestrategy handle the protected cache?
This issue is about a problem in the DerivedUnitFacadeCacheStrategy is don' see how the FieldUnitCacheStrategy would help in this case.
Updated by Andreas Müller over 4 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Andreas Müller to Andreas Kohlbecker
Sorry, I was not exact in my comment. I meant to move it from DerivedUnitFacadeCacheStrategy to DerivedUnitFacadeFieldUnitCacheStrategy.
I tried to implement this in 10fda345 . Can you please review and test (I have not tested).
The new implementation also works in a pure DerivedUnitFacadeFieldUnitCacheStrategy (e.g. FieldUnits in BulkEditor) context therefore I think is solves the problem a bit more generic.
Updated by Andreas Müller over 2 years ago
- Description updated (diff)
- Status changed from Resolved to Closed
- % Done changed from 50 to 100
The above links work as expected so I think we can close this ticket. Please reopen if you think there is something left to do.
Updated by Andreas Müller over 2 years ago
- Related to task #9678: Remove Derived- and FieldUnitFacadeCacheStrategies added