Project

General

Profile

bug #8517

SpecimenOrObservation: data from protected titleCache missig in portal pages

Added by Andreas Kohlbecker about 2 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
09/03/2019
Due date:
% Done:

100%

Severity:
normal
Found in Version:
Tags:

Description

The following portal pages are missing to show data from protected SpecimenOrObservation.titleCaches:


Related issues

Related to Edit - task #9678: Remove Derived- and FieldUnitFacadeCacheStrategies Closed 06/25/2021

Associated revisions

Revision c487ac2e (diff)
Added by Andreas Kohlbecker about 2 years ago

ref #8517 DerivedUnitFacadeCacheStrategy handling protected FieldUnit title caches correctly

Revision 10fda345 (diff)
Added by Andreas Müller almost 2 years ago

ref #8517 handle protected fieldunit titlecache in DerivedUnitFacadeFieldUnitCacheStrategy and not in DerivedUnitFacadeCacheStrategy

Revision cd10bbf6 (diff)
Added by Andreas Müller almost 2 years ago

ref #8517 handle protected fieldunit titlecache in DerivedUnitFacadeFieldUnitCacheStrategy and not in DerivedUnitFacadeCacheStrategy - fix compile error

History

#1 Updated by Andreas Kohlbecker about 2 years ago

  • Description updated (diff)

#2 Updated by Andreas Kohlbecker about 2 years ago

  • Category changed from cdm-dataportal to cdm

this is actually a problem in the DerivedUnitFacadeCacheStrategy which misses to respect protected FieldUnit title caches.

#3 Updated by Andreas Kohlbecker about 2 years ago

  • Status changed from New to Resolved
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 0 to 50

please review

#4 Updated by Andreas Müller about 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

This seems to work but handling the protected title cache of the field unit in the derivedunit cachestrategy to me does not look so clean.
Shouldn't instead the getFieldData method of the fieldunit cachestrategy handle the protected cache?

#5 Updated by Andreas Müller about 2 years ago

  • Category changed from cdm to cdmlib

#6 Updated by Andreas Kohlbecker almost 2 years ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller

Andreas Müller wrote:

This seems to work but handling the protected title cache of the field unit in the derivedunit cachestrategy to me does not look so clean.
Shouldn't instead the getFieldData method of the fieldunit cachestrategy handle the protected cache?

This issue is about a problem in the DerivedUnitFacadeCacheStrategy is don' see how the FieldUnitCacheStrategy would help in this case.

#7 Updated by Andreas Müller almost 2 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Sorry, I was not exact in my comment. I meant to move it from DerivedUnitFacadeCacheStrategy to DerivedUnitFacadeFieldUnitCacheStrategy.

I tried to implement this in 10fda345 . Can you please review and test (I have not tested).

The new implementation also works in a pure DerivedUnitFacadeFieldUnitCacheStrategy (e.g. FieldUnits in BulkEditor) context therefore I think is solves the problem a bit more generic.

#8 Updated by Andreas Müller 3 months ago

  • Description updated (diff)
  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

The above links work as expected so I think we can close this ticket. Please reopen if you think there is something left to do.

#9 Updated by Andreas Müller 3 months ago

  • Related to task #9678: Remove Derived- and FieldUnitFacadeCacheStrategies added

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)