Project

General

Profile

Actions

bug #8517

closed

SpecimenOrObservation: data from protected titleCache missig in portal pages

Added by Andreas Kohlbecker over 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:
Tags:

Description

The following portal pages are missing to show data from protected SpecimenOrObservation.titleCaches:


Related issues

Related to EDIT - task #9678: Remove Derived- and FieldUnitFacadeCacheStrategiesClosedAndreas Müller

Actions
Actions #1

Updated by Andreas Kohlbecker over 4 years ago

  • Description updated (diff)
Actions #2

Updated by Andreas Kohlbecker over 4 years ago

  • Category changed from cdm-dataportal to cdm

this is actually a problem in the DerivedUnitFacadeCacheStrategy which misses to respect protected FieldUnit title caches.

Actions #3

Updated by Andreas Kohlbecker over 4 years ago

  • Status changed from New to Resolved
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 0 to 50

please review

Actions #4

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

This seems to work but handling the protected title cache of the field unit in the derivedunit cachestrategy to me does not look so clean.
Shouldn't instead the getFieldData method of the fieldunit cachestrategy handle the protected cache?

Actions #5

Updated by Andreas Müller over 4 years ago

  • Category changed from cdm to cdmlib
Actions #6

Updated by Andreas Kohlbecker over 4 years ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller

Andreas Müller wrote:

This seems to work but handling the protected title cache of the field unit in the derivedunit cachestrategy to me does not look so clean.
Shouldn't instead the getFieldData method of the fieldunit cachestrategy handle the protected cache?

This issue is about a problem in the DerivedUnitFacadeCacheStrategy is don' see how the FieldUnitCacheStrategy would help in this case.

Actions #7

Updated by Andreas Müller over 4 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Sorry, I was not exact in my comment. I meant to move it from DerivedUnitFacadeCacheStrategy to DerivedUnitFacadeFieldUnitCacheStrategy.

I tried to implement this in 10fda345 . Can you please review and test (I have not tested).

The new implementation also works in a pure DerivedUnitFacadeFieldUnitCacheStrategy (e.g. FieldUnits in BulkEditor) context therefore I think is solves the problem a bit more generic.

Actions #8

Updated by Andreas Müller over 2 years ago

  • Description updated (diff)
  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

The above links work as expected so I think we can close this ticket. Please reopen if you think there is something left to do.

Actions #9

Updated by Andreas Müller over 2 years ago

  • Related to task #9678: Remove Derived- and FieldUnitFacadeCacheStrategies added
Actions

Also available in: Atom PDF