Project

General

Profile

Actions

task #8505

closed

ConfigFileUtil: turn all spring bean methods into not statical methods.

Added by Andreas Kohlbecker over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

follow up to #8189

in ConfigFileUtil

1. turn all spring bean methods into not statically methods.

2. better naming for getFolderSeperator():

CdmUtils.getFolderSeperator differentiates if the code runs from a jar bundle or if it runs from commandline. In the later case the first case you always need "/" as separator while in the later case it is OS dependendend and therefore the test fails.
Distinguishing this is e.g. important when term loading from csv files to distinguish the position of the csv files in the file system. If compiled to a jar you need another folder separator then reading from the ordinary folder on Windows because on Windows File.separator <> "/".

But I agree that we should maybe rename CdmUtils.getFolderSeperator to make clear that it is only for this specific usecase and it is not a general shortcut to replace File.separator


Related issues

Related to EDIT - bug #8189: Allow configuration of 'user.home' via the spring environmentClosedAndreas Kohlbecker

Actions
Related to EDIT - feature request #8187: Use Spring Environment instead of custom code in AbstractWebApplicationConfigurerNewAndreas Kohlbecker

Actions
Related to EDIT - task #8506: Remove the UpdatableRoutingDataSource, related classes and configurationNewAndreas Müller

Actions
Related to EDIT - task #2387: make name and location of ~/.cdmlibrary folder configurableNewAndreas Müller

Actions
Actions

Also available in: Atom PDF