Project

General

Profile

task #8505

ConfigFileUtil: turn all spring bean methods into not statical methods.

Added by Andreas Kohlbecker 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Highest
Category:
cdmlib
Target version:
Start date:
08/30/2019
Due date:
% Done:

100%

Severity:
normal

Description

follow up to #8189

in ConfigFileUtil

1. turn all spring bean methods into not statically methods.

2. better naming for getFolderSeperator():

CdmUtils.getFolderSeperator differentiates if the code runs from a jar bundle or if it runs from commandline. In the later case the first case you always need "/" as separator while in the later case it is OS dependendend and therefore the test fails.
Distinguishing this is e.g. important when term loading from csv files to distinguish the position of the csv files in the file system. If compiled to a jar you need another folder separator then reading from the ordinary folder on Windows because on Windows File.separator <> "/".

But I agree that we should maybe rename CdmUtils.getFolderSeperator to make clear that it is only for this specific usecase and it is not a general shortcut to replace File.separator


Related issues

Related to Edit - bug #8189: Allow configuration of 'user.home' via the spring environment Closed 03/21/2019
Related to Edit - feature request #8187: Use Spring Environment instead of custom code in AbstractWebApplicationConfigurer New 03/20/2019
Related to Edit - task #8506: Remove the UpdatableRoutingDataSource, related classes and configuration New 08/30/2019
Related to Edit - task #2387: make name and location of ~/.cdmlibrary folder configurable New 05/23/2011

Associated revisions

Revision 68ea5e65 (diff)
Added by Andreas Kohlbecker 3 months ago

fix #8505 turning statical methods of ConfigFileUtil into non statical bean methods

Revision 768f6835 (diff)
Added by Andreas Kohlbecker 3 months ago

ref #8505 renaming method to getResourceFolderSeperator() and adapting documentation

Revision 805b1fcf (diff)
Added by Andreas Kohlbecker 3 months ago

ref #8505 making getCdmHomeSubDirFallback() static again

Revision 2169c8d6 (diff)
Added by Andreas Kohlbecker 3 months ago

ref #8505 removing test code

Revision eba7ec9d (diff)
Added by Andreas Kohlbecker 3 months ago

ref #8505 adapting taxeditor to changes in ConfigFileUtil

Revision 876d7bb3 (diff)
Added by Andreas Kohlbecker 3 months ago

ref #8505 adapting ApplicationConfiguration

Revision ca8b3fe8 (diff)
Added by Andreas Kohlbecker 3 months ago

ref #8505 inverting incorrect null check

History

#1 Updated by Andreas Kohlbecker 3 months ago

  • Related to bug #8189: Allow configuration of 'user.home' via the spring environment added

#2 Updated by Andreas Kohlbecker 3 months ago

  • Description updated (diff)

#3 Updated by Andreas Kohlbecker 3 months ago

  • Related to feature request #8187: Use Spring Environment instead of custom code in AbstractWebApplicationConfigurer added

#4 Updated by Andreas Kohlbecker 3 months ago

  • Related to task #8506: Remove the UpdatableRoutingDataSource, related classes and configuration added

#5 Updated by Andreas Kohlbecker 3 months ago

  • Related to task #2387: make name and location of ~/.cdmlibrary folder configurable added

#6 Updated by Andreas Kohlbecker 3 months ago

  • Subject changed from ConfigFileUtil: turn all sping bean methods into not statically methods. to ConfigFileUtil: turn all sping bean methods into not statical methods.
  • Status changed from New to In Progress

#7 Updated by Andreas Kohlbecker 3 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 50

#8 Updated by Andreas Kohlbecker 3 months ago

  • Subject changed from ConfigFileUtil: turn all sping bean methods into not statical methods. to ConfigFileUtil: turn all spring bean methods into not statical methods.
  • % Done changed from 50 to 0

#9 Updated by Andreas Kohlbecker 2 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100

fully solved and working as expected since there are no longer any problems in the dependent products

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)