Project

General

Profile

feature request #8476

Implement support for TermCollection.isFlat in TaxEditor

Added by Andreas Müller almost 2 years ago. Updated about 2 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
08/16/2019
Due date:
% Done:

100%

Severity:
normal

Description

Often term collections are meant to be a flat list or set without hierarchical dependencies. For these collections there is the new flag "isFlat" now. This should be used in the TaxEditor.

  1. Make the flag editable
  2. If an existing collection already has a hierarchy disable editing of the flag (to avoid that someone sets the flag to true but still there is a hierarchy). Maybe we should also have this as a validation rule that this is not possible to save. -> This we should do as well.
  3. If isFlat=true no addChild menu should exist anymore.
  4. Drag&Drop should behave accordingly
  5. The New... menu to create new Term collection should have an alternative to create a flat "tree"/collection. => #9643
  6. Default should be a hierarchical collection.

This is strongly related to #8474


Related issues

Related to Edit - feature request #6794: Improve term structure In Progress 07/09/2017
Related to Edit - feature request #8474: Make TermCollection.orderRelevant usable for TermTrees Closed 08/16/2019
Related to Edit - feature request #8477: Implement support for TermCollection.allowDuplicates in TaxEditor Closed 08/16/2019
Related to Edit - bug #8776: Open issues for TermCollection.allowDuplicates handling in TaxEditor Closed 08/19/2019
Related to Edit - bug #8774: Reimplement term tree editors to implement the general save strategy Closed 12/17/2019
Related to Edit - feature request #9337: Open issues for reimplementation of termtree editors Closed 11/30/2020
Copied to Edit - feature request #9643: New menu in term tree editor should have alternatives for flags New 06/01/2021

Associated revisions

Revision 4f2c16a0 (diff)
Added by Patrick Plitzner over 1 year ago

ref #8476, #8474, #7994, #8477 Add checkboxes for term tree flags

Revision d800b880 (diff)
Added by Patrick Plitzner over 1 year ago

ref #8476, #8474 Set isFlat to false when creating a term tree

Revision 88b50562 (diff)
Added by Katja Luther about 2 months ago

ref #8476: do not show create child if tree is flat

Revision e866a450 (diff)
Added by Katja Luther about 2 months ago

ref #8476: do not allow d&d to a child

Revision 8acf6617 (diff)
Added by Katja Luther about 2 months ago

ref #8476: add check for subtrees

Revision 3d3a68f0 (diff)
Added by Katja Luther about 2 months ago

ref #8476: disable flat flag if tree has subtrees

Revision 12e7c169 (diff)
Added by Katja Luther about 2 months ago

ref #8476: fix d&d in flat tree and cleanup

Revision 57a53d78 (diff)
Added by Katja Luther about 2 months ago

fix #8476: fix paste not allowed for nodes if tree is flat

History

#1 Updated by Andreas Müller almost 2 years ago

#2 Updated by Andreas Müller almost 2 years ago

#3 Updated by Andreas Müller almost 2 years ago

  • Related to feature request #8477: Implement support for TermCollection.allowDuplicates in TaxEditor added

#4 Updated by Andreas Müller over 1 year ago

  • Assignee changed from Patrick Plitzner to Katja Luther
  • Priority changed from New to Highest

#5 Updated by Patrick Plitzner over 1 year ago

  • Description updated (diff)
  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
  • Target version changed from Unassigned CDM tickets to Release 5.12
  • % Done changed from 0 to 20

#6 Updated by Patrick Plitzner over 1 year ago

  • Description updated (diff)

#7 Updated by Andreas Müller over 1 year ago

  • Status changed from Resolved to In Progress
  • Assignee changed from Andreas Müller to Katja Luther

Only the flag is editable until now so I put this back to InProgress.

#8 Updated by Andreas Müller over 1 year ago

  • Related to bug #8776: Open issues for TermCollection.allowDuplicates handling in TaxEditor added

#9 Updated by Andreas Müller over 1 year ago

Note: saving often does not work due to issues to be solved in #8774

#10 Updated by Andreas Müller over 1 year ago

  • Related to bug #8774: Reimplement term tree editors to implement the general save strategy added

#11 Updated by Katja Luther over 1 year ago

  • Target version changed from Release 5.12 to Release 5.13

#12 Updated by Katja Luther over 1 year ago

  • Target version changed from Release 5.13 to Release 5.14

move to 5.14

#13 Updated by Katja Luther over 1 year ago

  • Target version changed from Release 5.14 to Release 5.15

#14 Updated by Katja Luther about 1 year ago

  • Target version changed from Release 5.15 to Release 5.18

#15 Updated by Andreas Müller 8 months ago

#16 Updated by Katja Luther 8 months ago

  • Target version changed from Release 5.18 to Release 5.19

#17 Updated by Katja Luther 3 months ago

  • Target version changed from Release 5.19 to Release 5.25

#18 Updated by Katja Luther about 2 months ago

  • Description updated (diff)

#19 Updated by Katja Luther about 2 months ago

  • Description updated (diff)

#20 Updated by Katja Luther about 2 months ago

  • Description updated (diff)

#21 Updated by Andreas Müller about 2 months ago

  • Description updated (diff)
  • % Done changed from 20 to 40

#22 Updated by Andreas Müller about 2 months ago

  • Description updated (diff)
  • Status changed from In Progress to Feedback

d&d is still available for moving a term to become a child of another term node. Instead the "is flat" flag is disabled in details view (which is correct in a way because the flag should not be editable for a real tree, but it should never become a tree when the flag is set).

Also "paste" from menu is still available.

#23 Updated by Andreas Müller about 2 months ago

Please also test for d&d from vocabulary editor. I have not tested yet.

#24 Updated by Andreas Müller about 2 months ago

#25 Updated by Katja Luther about 2 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

Please also test for d&d from vocabulary editor. I have not tested yet.

With the last commit the d&d is fixed also for d&d from vocabulary.

#26 Updated by Katja Luther about 2 months ago

  • % Done changed from 40 to 50

#27 Updated by Andreas Müller about 2 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • Target version changed from Release 5.25 to Release 5.24
  • % Done changed from 50 to 100

This seems to be fully fixed now. I move it back to 5.24 as it was fixed there.
Only open issue (menu) was moved to #9643.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)