EDIT

I find it very useful for debugging that computed descriptions can be viewed and modified in the editor. Can't we allow this by introducing a "Developer" mode in which the computed descriptions are not hidden or set to read only?

Andreas Kohlbecker wrote:

I find it very useful for debugging that computed descriptions can be viewed and modified in the editor. Can't we allow this by introducing a "Developer" mode in which the computed descriptions are not hidden or set to read only?

This ticket is not meant to completely make the computed descriptions invisible. By default they should only be disabled for editing. But ofcourse it might be even better if this can be made configurable (e.g. 3 states: editable, disabled for editing, invisible) with default to disabled for editing.
I think this should meat your requirments?

Andreas Müller wrote:

Andreas Kohlbecker wrote:

I find it very useful for debugging that computed descriptions can be viewed and modified in the editor. Can't we allow this by introducing a "Developer" mode in which the computed descriptions are not hidden or set to read only?

This ticket is not meant to completely make the computed descriptions invisible. By default they should only be disabled for editing. But ofcourse it might be even better if this can be made configurable (e.g. 3 states: editable, disabled for editing, invisible) with default to disabled for editing.
I think this should meat your requirments?

This would be the perfect solution!

I did some research but it seems to be a little bit more complex because this needs to be implemented by a mouseListener (see for example https://www.eclipse.org/forums/index.php/t/103773/), therefore we keep the ticket in 5.15

The preferences to make the aggregated data either disabled, invisible or enabled is still missing, correct?

Should we create a new ticket for this?

The "Types" field for ordinary descriptions is now enabled but shouldn't because it is read only (should be set only by machines). In 5.22 it was still disabled always.

I think we should reenable the "delete" menu item as it should always be possible to remove computed data again. Maybe in future there are cases where this is not wanted but for the current cases (distribution and description aggregation) I think it should be possible.

Andreas Müller wrote:

The description itself is not yet disabled in details view (but it is in suppl data view). This needs to be fixed.

I mentioned this in #note-22

Andreas Müller wrote:

I think we should reenable the "delete" menu item as it should always be possible to remove computed data again. Maybe in future there are cases where this is not wanted but for the current cases (distribution and description aggregation) I think it should be possible.

Delete is enabled again.

Andreas Müller wrote:

The "Types" field for ordinary descriptions is now enabled but shouldn't because it is read only (should be set only by machines). In 5.22 it was still disabled always.

this should be fixed again

Another issue is that sections can be opened now. E.g. if there is an annotation I can't see it's content as I can't open the section. This is also better if fields are only write protected.

Generally we may think about another implementation. I think about a solution which passes an "enabled" or "editingStatus" parameter with setInput() to ALL editors. (Alternatively we could also add it to createControl(?) but this in future should only run once per application and form so in future setInput() is the better place I guess).

This way we have a very generic way to disable writing as when ever we set the input to any control we also set the value if it should be write protected or not. This differs from the current code which needs a lot of case distictions etc.
Can you put this also to the new ticket?

This ticket can be closed once the new 2 tickets are created.