Project

General

Profile

Actions

feature request #8470

closed

Handle username constraints in user and group editing

Added by Andreas Müller almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

Since #8454 a regex exist for usernames and groupnames.

For new usernames and groups the TaxEditor should validate against this regex and show an appropriate warning if it not fulfilled.
Currently only cdm-security throws an exception and prevents from saving such new instances


Related issues

Related to EDIT - feature request #8454: Only allow certain patterns as username and groupnameClosedAndreas Müller

Actions
Actions #1

Updated by Andreas Müller almost 5 years ago

Actions #2

Updated by Katja Luther over 4 years ago

  • Target version changed from Release 5.9 to Release 5.10

I will implement this for the next release.

Actions #3

Updated by Katja Luther over 4 years ago

  • Target version changed from Release 5.10 to Release 5.11
Actions #4

Updated by Katja Luther over 4 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions #5

Updated by Katja Luther over 4 years ago

  • Assignee changed from Katja Luther to Andreas Müller
Actions #6

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Please also implement for groups.

Actions #7

Updated by Katja Luther over 4 years ago

Another question:

at the moment the user is created and saved immediately, but the group is created and saved when the group bulk editor is saved.
I think we decided once to avoid the immediately saved entities, so I would harmonize it.

Actions #8

Updated by Andreas Müller over 4 years ago

hmm, I think users and groups are special. There names are are unique identifiers and should not be changed anymore. So there is not really a reason for not saving them immediately. Also you can avoid that way that 2 people create the same user in parallel. So from my side we do could implement it the other way round for both user and groups.

Actions #9

Updated by Katja Luther over 4 years ago

  • Status changed from Feedback to Resolved
Actions #10

Updated by Katja Luther over 4 years ago

  • Assignee changed from Katja Luther to Andreas Müller

please review

Actions #11

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Now when creating a new user the bulkeditor is dirty. When NOT saving the bulk editor and after reopening the bulk editor the user is there, however. This is unexpected behavior.

Actions #12

Updated by Andreas Müller over 4 years ago

Andreas Müller wrote:

Now when creating a new user the bulkeditor is dirty. When NOT saving the bulk editor and after reopening the bulk editor the user is there, however. This is unexpected behavior.

The same is true for new groups.

Actions #13

Updated by Andreas Müller over 4 years ago

Can you please leave a message how exactly you changed the issue discussed in note 7 and 8. The discussion was not ended so I don't know what the expected behavior should be. However, the current implementation is not correct as the editors are dirty but still the new instance is saved.

Actions #14

Updated by Andreas Müller over 4 years ago

Also in the "New" dialog there is a message "Input cannot be empty". Also here further information on the allowed characters should be added. For both person and group.

Actions #15

Updated by Katja Luther over 4 years ago

  • Status changed from Feedback to Resolved

Andreas Müller wrote:

Can you please leave a message how exactly you changed the issue discussed in note 7 and 8. The discussion was not ended so I don't know what the expected behavior should be. However, the current implementation is not correct as the editors are dirty but still the new instance is saved.

Now it is implemented like for a new user before. The new user or group is created and saved immediatly, it is fixed that the editor is not set dirty.

Actions #16

Updated by Katja Luther over 4 years ago

Andreas Müller wrote:

Also in the "New" dialog there is a message "Input cannot be empty". Also here further information on the allowed characters should be added. For both person and group.

Now the message is the same as for a not saved new user/group

Actions #17

Updated by Andreas Müller over 4 years ago

  • Assignee changed from Katja Luther to Andreas Müller

I guess this is for review

Actions #18

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 100

Seems to work as expected

Actions

Also available in: Atom PDF