Project

General

Profile

bug #8443

a user with only rights on a subtree can edit taxa and names of another subtree

Added by Katja Luther 11 months ago. Updated 9 months ago.

Status:
New
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
08/05/2019
Due date:
% Done:

0%

Severity:
normal
Found in Version:

Description

the user with rights on a subtree is able to edit taxa outside the defined subtree. The only limitation is creation and deleting of nodes.

History

#1 Updated by Katja Luther 11 months ago

  • Description updated (diff)

#2 Updated by Katja Luther 11 months ago

  • Subject changed from a user with only rights on a subtree can edit a name not used in subtree (bulkeditor) to a user with only rights on a subtree can edit taxa and names of another subtree
  • Description updated (diff)
  • Category changed from cdmlib to taxeditor
  • Assignee changed from Andreas Müller to Katja Luther

#3 Updated by Andreas Müller 11 months ago

is this only an UI issue or is it also a cdmlib-security issue?

#4 Updated by Katja Luther 9 months ago

Andreas Müller wrote:

is this only an UI issue or is it also a cdmlib-security issue?

I think this is also a cdmlib security issue. Actually I work on the implementation in the Editor, but I think this needs also checked on cdmlib side.

#5 Updated by Andreas Kohlbecker 9 months ago

As far as I understand the problem, we need to implement the furtherVotingDescisions(CdmAuthority CdmAuthority, TargetEntityStates targetEntityStates, Collection<ConfigAttribute> attributes,
ValidationResult validationResult)
in TaxonBaseVoter so that the permissions on the TaxonNodes is always taken into account.
Problems can arise when deciding on a Taxon for which the TaxonNodes are not yet initialized in this case the required information needs to be loaded from the db first. Maybe we can directly delegate the decision to the TaxonNodeVoter by calling its vote() and furtherVotingDescisions() methods properly.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)