Project

General

Profile

feature request #8410

Add nomenclatural code edition to ruleConsidered in TaxEditor

Added by Andreas Müller 4 months ago. Updated 13 days ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
07/26/2019
Due date:
% Done:

100%

Severity:
normal
Tags:

Description

for nomenclatural status, name relation (and hybrid relation once it exists).

Make the field only available if rule considered is not empty, to indicate that these 2 belong together.

For details see #8398 and related tickets.


Related issues

Related to Edit - feature request #8398: Add nomenclatural code edition to ruleConsidered Closed 07/23/2019
Related to Edit - feature request #8572: Rule considered configurable Closed 09/27/2019

Associated revisions

Revision ec00e362 (diff)
Added by Katja Luther about 2 months ago

ref #8410: add nomencl. code edition

Revision 7d377aab (diff)
Added by Katja Luther about 2 months ago

ref #8410: add nomencl. code edition - continue

Revision cc1f8735 (diff)
Added by Katja Luther about 2 months ago

ref #8410: disable code edition combo when rule considered is empty

Revision 25364108 (diff)
Added by Katja Luther 17 days ago

ref #8410: add indent to code edition

Revision 37811f53 (diff)
Added by Katja Luther 16 days ago

ref #8410: add only nomenclatural code editions for code of name to combo

Revision c127b2b6 (diff)
Added by Katja Luther 13 days ago

ref #8410: indent only for label

Revision 7bbfb091 (diff)
Added by Katja Luther 13 days ago

ref #8410: indent only for label -continue

Revision 9021b90c (diff)
Added by Katja Luther 13 days ago

ref #8410: fix NPE

History

#1 Updated by Andreas Müller 4 months ago

#2 Updated by Andreas Müller 4 months ago

  • Subject changed from Add nomenclatural code edition to ruleConsidered to Add nomenclatural code edition to ruleConsidered in TaxEditor
  • Description updated (diff)

#3 Updated by Andreas Müller 3 months ago

  • Target version changed from Unassigned CDM tickets to Release 5.10

Maybe we can do this in 5.10 latest so it is close to the model change.

I think we should add it to configuration as in many projects in will not be needed. Same applies to rule considered I guess. But adding to configuration might be another ticket.

#4 Updated by Andreas Müller 3 months ago

  • Description updated (diff)

#5 Updated by Katja Luther 2 months ago

  • Target version changed from Release 5.10 to Release 5.11

#6 Updated by Katja Luther about 2 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

this is implemented now. Configuration is moved to new ticket (#8572).

#7 Updated by Katja Luther about 2 months ago

#8 Updated by Andreas Müller 20 days ago

  • % Done changed from 0 to 80

Works!

Only some layout issues:

  • Please add identation to label to make clear belongs and depends on state of "Rule considered"
  • Shorten label to "Code edition"
  • Use capital letter for "considered" in "Rule Considered" => this is according to handling in other parts of name details view
  • use human readable labels for the code editions (#8572#note-5)

#9 Updated by Andreas Müller 20 days ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

#10 Updated by Katja Luther 17 days ago

Andreas Müller wrote:

Works!

Only some layout issues:

  • Please add identation to label to make clear belongs and depends on state of "Rule considered"
  • Shorten label to "Code edition"
  • Use capital letter for "considered" in "Rule Considered" => this is according to handling in other parts of name details view
  • use human readable labels for the code editions (#8572#note-5)

#11 Updated by Katja Luther 17 days ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

#12 Updated by Andreas Müller 17 days ago

Katja Luther wrote:

Andreas Müller wrote:

Works!

Only some layout issues:

  • Please add identation to label to make clear belongs and depends on state of "Rule considered"
  • Shorten label to "Code edition"
  • Use capital letter for "considered" in "Rule Considered" => this is according to handling in other parts of name details view
  • use human readable labels for the code editions (#8572#note-5)

Identation still does not exist. "Considered" still does have no capital letter.

#13 Updated by Andreas Müller 17 days ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

One more requirement I forgot to mention before:

The list should show only those codes which fit to the nomenclatural code of the taxon name.
You may use NomenclaturalCodeEdition.forCode(NomenclaturalCode code) for this purpose.

#14 Updated by Andreas Kohlbecker 17 days ago

Andreas Müller wrote:

One more requirement I forgot to mention before:

The list should show only those codes which fit to the nomenclatural code of the taxon name.
You may use NomenclaturalCodeEdition.forCode(NomenclaturalCode code) for this purpose.

I think the availability of codes should be configurable via the properties. The restriction of a project to only one code can be a too narrow constraint for some projects. (E.g. Taxon interactions between animals and plants)

#15 Updated by Andreas Müller 17 days ago

Andreas Kohlbecker wrote:

Andreas Müller wrote:

One more requirement I forgot to mention before:

The list should show only those codes which fit to the nomenclatural code of the taxon name.
You may use NomenclaturalCodeEdition.forCode(NomenclaturalCode code) for this purpose.

I think the availability of codes should be configurable via the properties. The restriction of a project to only one code can be a too narrow constraint for some projects. (E.g. Taxon interactions between animals and plants)

My suggestion was not project but taxon name specific.

#16 Updated by Katja Luther 16 days ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

sorry, the last changes were not pushed, now they are available in the actual nightly build.

the combo box is filled only with code editions for the code of the name

#17 Updated by Andreas Müller 16 days ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

I tried to change the nom code ICNAFP to ICZN for a name but the list did not change even after reopening the taxon.

#18 Updated by Andreas Müller 16 days ago

The list should always show an empty entry to make it possible to delete the field.

#19 Updated by Andreas Müller 16 days ago

Now the indentation is for both the label and the textfield. but I think for the label it is enough. Otherwise the layout becomes very bumby.
But you could do a bit more indentation for the label.

#20 Updated by Andreas Müller 13 days ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 100

It looks better now. I think we can close the ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)