Project

General

Profile

Actions

feature request #8410

closed

Add nomenclatural code edition to ruleConsidered in TaxEditor

Added by Andreas Müller almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:

Description

for nomenclatural status, name relation (and hybrid relation once it exists).

Make the field only available if rule considered is not empty, to indicate that these 2 belong together.

For details see #8398 and related tickets.


Related issues

Related to EDIT - feature request #8398: Add nomenclatural code edition to ruleConsideredClosedAndreas Müller

Actions
Related to EDIT - feature request #8572: Rule considered configurableClosedKatja Luther

Actions
Actions #1

Updated by Andreas Müller almost 5 years ago

Actions #2

Updated by Andreas Müller almost 5 years ago

  • Subject changed from Add nomenclatural code edition to ruleConsidered to Add nomenclatural code edition to ruleConsidered in TaxEditor
  • Description updated (diff)
Actions #3

Updated by Andreas Müller almost 5 years ago

  • Target version changed from Unassigned CDM tickets to Release 5.10

Maybe we can do this in 5.10 latest so it is close to the model change.

I think we should add it to configuration as in many projects in will not be needed. Same applies to rule considered I guess. But adding to configuration might be another ticket.

Actions #4

Updated by Andreas Müller almost 5 years ago

  • Description updated (diff)
Actions #5

Updated by Katja Luther over 4 years ago

  • Target version changed from Release 5.10 to Release 5.11
Actions #6

Updated by Katja Luther over 4 years ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

this is implemented now. Configuration is moved to new ticket (#8572).

Actions #7

Updated by Katja Luther over 4 years ago

Actions #8

Updated by Andreas Müller over 4 years ago

  • % Done changed from 0 to 80

Works!

Only some layout issues:

  • Please add identation to label to make clear belongs and depends on state of "Rule considered"
  • Shorten label to "Code edition"
  • Use capital letter for "considered" in "Rule Considered" => this is according to handling in other parts of name details view
  • use human readable labels for the code editions (#8572#note-5)
Actions #9

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
Actions #10

Updated by Katja Luther over 4 years ago

Andreas Müller wrote:

Works!

Only some layout issues:

  • Please add identation to label to make clear belongs and depends on state of "Rule considered"
  • Shorten label to "Code edition"
  • Use capital letter for "considered" in "Rule Considered" => this is according to handling in other parts of name details view
  • use human readable labels for the code editions (#8572#note-5)
Actions #11

Updated by Katja Luther over 4 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
Actions #12

Updated by Andreas Müller over 4 years ago

Katja Luther wrote:

Andreas Müller wrote:

Works!

Only some layout issues:

  • Please add identation to label to make clear belongs and depends on state of "Rule considered"
  • Shorten label to "Code edition"
  • Use capital letter for "considered" in "Rule Considered" => this is according to handling in other parts of name details view
  • use human readable labels for the code editions (#8572#note-5)

Identation still does not exist. "Considered" still does have no capital letter.

Actions #13

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

One more requirement I forgot to mention before:

The list should show only those codes which fit to the nomenclatural code of the taxon name.
You may use NomenclaturalCodeEdition.forCode(NomenclaturalCode code) for this purpose.

Actions #14

Updated by Andreas Kohlbecker over 4 years ago

Andreas Müller wrote:

One more requirement I forgot to mention before:

The list should show only those codes which fit to the nomenclatural code of the taxon name.
You may use NomenclaturalCodeEdition.forCode(NomenclaturalCode code) for this purpose.

I think the availability of codes should be configurable via the properties. The restriction of a project to only one code can be a too narrow constraint for some projects. (E.g. Taxon interactions between animals and plants)

Actions #15

Updated by Andreas Müller over 4 years ago

Andreas Kohlbecker wrote:

Andreas Müller wrote:

One more requirement I forgot to mention before:

The list should show only those codes which fit to the nomenclatural code of the taxon name.
You may use NomenclaturalCodeEdition.forCode(NomenclaturalCode code) for this purpose.

I think the availability of codes should be configurable via the properties. The restriction of a project to only one code can be a too narrow constraint for some projects. (E.g. Taxon interactions between animals and plants)

My suggestion was not project but taxon name specific.

Actions #16

Updated by Katja Luther over 4 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

sorry, the last changes were not pushed, now they are available in the actual nightly build.

the combo box is filled only with code editions for the code of the name

Actions #17

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

I tried to change the nom code ICNAFP to ICZN for a name but the list did not change even after reopening the taxon.

Actions #18

Updated by Andreas Müller over 4 years ago

The list should always show an empty entry to make it possible to delete the field.

Actions #19

Updated by Andreas Müller over 4 years ago

Now the indentation is for both the label and the textfield. but I think for the label it is enough. Otherwise the layout becomes very bumby.
But you could do a bit more indentation for the label.

Actions #20

Updated by Andreas Müller over 4 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 100

It looks better now. I think we can close the ticket.

Actions

Also available in: Atom PDF