Project

General

Profile

feature request #8304

feature request #8108: Name page shows complete name information (I)

Name page redirects to according taxon depending on query parameter

Added by Andreas Kohlbecker 6 months ago. Updated 3 months ago.

Status:
Feedback
Priority:
New
Category:
cdm-dataportal
Target version:
Start date:
05/26/2019
Due date:
% Done:

50%

Severity:
normal
Tags:

Description

As requested in #8108 the redirection behavior of the name page to the related taxon (if there is only one) should be configurable.

The behavior should not be unique for the whole dataportal but individually different for the contexts in which a name is used in the portal.
Therefore the best solution would be to make it configurable via a query parameter or by drupal path argument.

The behavior also needs to be configurable per portal installation individually per context. The render templates already allow to fine tune the display of names and taxa, to enable links to the name and nomref. From this point of view it seems to make sense to use the render templates also for the configuration of the autoredirect feature of the name page. rejected in favor of having this implemented more quick an simplistic, see comment 4

picture689-1.png View (13.4 KB) Andreas Kohlbecker, 06/25/2019 05:41 PM

Associated revisions

Revision 2f65af04 (diff)
Added by Andreas Kohlbecker 6 months ago

fix #8304 redirect from name to taxon page depending on drupal path argument, with test

Revision b648739e (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8304 fixing problems with page arg evaluation

Revision 6d0b5bc3 (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8304 adapting test cases

Revision 14832ae9 (diff)
Added by Andreas Kohlbecker 5 months ago

ref #8304 global switch to enable the name page redirecting to taxa

History

#1 Updated by Andreas Kohlbecker 6 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#2 Updated by Andreas Kohlbecker 5 months ago

  • Description updated (diff)

#3 Updated by Andreas Kohlbecker 5 months ago

Hallo,

ich bemerke gerade eine Veränderung in der Anzeige von Homonymbeziehungen:

Wenn ich in http://cichorieae.e-taxonomy.net/portal/cdm_dataportal/taxon/0d33931c-b89b-47ba-aecd-93a11778f765/synonymy?highlite=f69929b6-942c-4f53-b1f4-25db9345b580&acceptedFor=f69929b6-942c-4f53-b1f4-25db9345b580#f69929b6-942c-4f53-b1f4-25db9345b580 auf das ältere Homonym H. foliosa Vill. 1876 gehen, lande ich nicht wie früher in der Synonymy der Taxonseite zu der das ältere Homonym gehört, sondern auf eine nutzlosen Zwischenseite http://cichorieae.e-taxonomy.net/portal/cdm_dataportal/name/a111f1a1-304f-4e38-9ea7-ca4086a6d23e/f69929b6-942c-4f53-b1f4-25db9345b580/null/

Lässt sich das wieder abstellen??

By the way: Fußnotenverweise werden z.Z. verdoppelt dargestellt, so auf http://cichorieae.e-taxonomy.net/portal/cdm_dataportal/taxon/e2b2af79-21bc-4a49-98d8-3b716ca26e9b/synonymy?highlite=c661ae18-da75-48c1-bd0d-8955ad2e4b8b&acceptedFor=c661ae18-da75-48c1-bd0d-8955ad2e4b8b#c661ae18-da75-48c1-bd0d-8955ad2e4b8b, sihe unter A. uniflorus car. crepidifolius ....

Beste Grüße,
Norbert

#4 Updated by Andreas Kohlbecker 5 months ago

The suggestion made in the issue description to use the name render templates to fine tune the behavior of the autoredirect feature per portal and context would require quite some time to be implemented. The render templates are evaluated in the render_name_or_taxon() method the autoredirect feature however is implemented in the cdm_dataportal_name_view() method which is a completely different place. The extension of the render templates would also be a bit costly in terms of time. Therefore I will only implement a global switch in the settings by which the autoredirect feature can be enabled always.

#5 Updated by Andreas Kohlbecker 5 months ago

  • Description updated (diff)

#6 Updated by Andreas Kohlbecker 5 months ago

The layout settings page () now offers the following checkbox:

#7 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

I do not fully understand this solution. I thought it should be configurable for each location that has a link to a name (e.g. name in source, name in synonymy, determined under, ...

The current implementation allows to configure only 1 (and always the same) behavior it does not allow to distinguish where the call comes from as far as I can see.

#8 Updated by Andreas Kohlbecker 4 months ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller

This is a misunderstanding. During the standup yesterday I was talking about a global switch which overrides the default behavior. The explanation why I decided for this solution is found in comment 14

Also other implementations witch are not making use of the render templates would be costly in terms of time. I think we should not invest this time as long there is no definite user request for this.

#9 Updated by Andreas Müller 4 months ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

As far as I remember there is already a user request for this. At least I have discussed it with users.
Also I think the general usage of the name page is only possible if such configurations exists. At least for those portal which generally require to redirect to the taxon page may still want to have exactly 1 place (e.g. as an icon link behind the names in synonymy) where the names can directly be linked. Otherwise for those portals it will never be possible to show explicit name information for names used eactly 1x in synonymy. But as in future more information will be stored about names (e.g. name identifier, name facts, etc.) this will lead to a loss of information on these portals.

Also I don't think it is difficult to implement, isn't it?

#10 Updated by Andreas Kohlbecker 4 months ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller

I don't think that these requirements are contradict the current implementation with the 'global' switch. As far as I understand the requirement, it would merely require an extension of the existing functionality.

#11 Updated by Andreas Müller 3 months ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Hi Andreas, I think we have discussed this issue sometime at phone. Do you remember the results? Are they somewhere in a ticket? What is the status.
Unfortunately currently I don't have time to check this further.

#12 Updated by Andreas Kohlbecker 3 months ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller

the result of our call was the following:

The global switch which overrides the redirect behavior is not causing problems for use-cases like linking from the synonymy to the according name of a synonym. The behavior of the name page can be set for each link with the redirect_to_taxon option. In case of the suggested icon link behind the names in synonymy the link would not have this parameter and the user would stay on the name page even if there is only one taxon for this name. This works unless the global switch is being used to override the behavior which is configured per link. All links then would behave as if redirect_to_taxon was set.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)