Project

General

Profile

feature request #8294

Make display of ID in source and ID Namespace configurable

Added by Katja Luther 7 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
05/22/2019
Due date:
% Done:

100%

Severity:
normal
Tags:

Description

The display of ID in Source and ID Namespace should be configurable, the preference predicates are available already but the preference pages need to be implemented.

picture299-1.png View (5.85 KB) Andreas Müller, 05/23/2019 11:31 AM

picture777-1.png View (21.4 KB) Patrick Plitzner, 07/15/2019 03:19 PM

picture232-1.png View (8.43 KB) Andreas Müller, 07/16/2019 05:47 PM


Related issues

Related to Edit - feature request #7793: Master ticket for E+M editor issues Feedback 09/27/2018
Copied to Edit - bug #8382: Local Supplemental Data Source Preferences should reflect the state of admin preferences Closed 07/17/2019

Associated revisions

Revision 011c997b (diff)
Added by Andreas Müller 7 months ago

adapt IdNamespace predicate a bit #8294

Revision a4f3f99c (diff)
Added by Katja Luther 6 months ago

ref #8294: add preference page for id in namespace and namespace in source

Revision 31457bf1 (diff)
Added by Patrick Plitzner 5 months ago

ref #8294 code cleaning

Revision 456115c5 (diff)
Added by Patrick Plitzner 5 months ago

ref #8294 Add missing "Show UUID/ID" option to preference

Revision b91b98c5 (diff)
Added by Patrick Plitzner 5 months ago

ref #8294 Move supplemental data source preferences to sub menu

Revision 660c3f90 (diff)
Added by Patrick Plitzner 5 months ago

ref #8294 Swap showIdInSource and ShowIdNamespace

Revision ddaac84e (diff)
Added by Patrick Plitzner 5 months ago

ref #8294 i18n for plugin.xml

History

#1 Updated by Andreas Müller 7 months ago

  • Status changed from New to Feedback

This issue is already mentioned in #7793 and it seems to be fixed (but maybe not yet available in Admin UI).

#2 Updated by Andreas Müller 7 months ago

The current implementation does not seem to work. I tried with

but still got both Id in Source and Id Namespace even after restart (tested on E+M production)

#3 Updated by Andreas Müller 7 months ago

When fixing please also rename predicate NameInSource. It should be IdNamespace. Also we may rename the predicate in the predicate enum from ShowNamespaceInSource -> ShowIdNamespace

#4 Updated by Andreas Müller 6 months ago

#5 Updated by Katja Luther 5 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review

#6 Updated by Patrick Plitzner 5 months ago

Tested on nightly: The admin and local preferences work as expected BUT they seem to be swapped. Also the one preferences was not renamed (see picture)

#7 Updated by Andreas Müller 5 months ago

yes, it is switched and also in both views it is called "ID in Namespace" but should be "ID Namespace". Also ID Namespace should be below ID in Source in both preference UIs.

Critical:

Show UUID and ID is not available in local preference but it was before:

=> we should move the new parameters to the submenu "Sources" as it exists for "extensions" and "marker" and keep the old top level page which has "Show UUID and ID ..."

#8 Updated by Andreas Müller 5 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

Patrick, can you try to fix the open issues?

#9 Updated by Patrick Plitzner 5 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

All issues should be fixed now.

What still would be nice is if the disabled local preferences would reflect the state of the admin preferences. Now they are just disabled showing the state of the local preference. This is done correctly e.g. in the specimen preferences -> #8382

#10 Updated by Andreas Müller 5 months ago

  • Copied to bug #8382: Local Supplemental Data Source Preferences should reflect the state of admin preferences added

#11 Updated by Andreas Müller 5 months ago

Server side preferences are not yet translated (Submenu Sources and Labels on page) (update code before changing as I did change the label for ID Namespace.

#12 Updated by Andreas Müller 5 months ago

  • Assignee changed from Andreas Müller to Patrick Plitzner

same in local preference (if this is different code)

#13 Updated by Andreas Müller 5 months ago

  • Status changed from Resolved to Feedback
  • % Done changed from 70 to 80

All the rest seems to work and looks ok.

#14 Updated by Andreas Müller 5 months ago

  • Tags set to euro+med

#15 Updated by Patrick Plitzner 5 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 100

translated preferences. Closing the ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)