Project

General

Profile

feature request #8283

Allow adding media to terms in taxeditor

Added by Patrick Plitzner about 1 month ago. Updated 13 days ago.

Status:
Feedback
Priority:
New
Category:
taxeditor
Target version:
Start date:
05/17/2019
Due date:
% Done:

80%

Severity:
normal

Description

This could be done in the details view for example

Associated revisions

Revision d4184136 (diff)
Added by Patrick Plitzner about 1 month ago

fix #8283 Add media section to term details view

Revision 909326e9 (diff)
Added by Patrick Plitzner 21 days ago

fix #8283 Add media section to term details view

History

#1 Updated by Patrick Plitzner about 1 month ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#2 Updated by Patrick Plitzner about 1 month ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

#3 Updated by Andreas Müller 22 days ago

should we add to HFX?

#4 Updated by Andreas Müller 21 days ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

The data may got lost the following way.

  • Open term
  • add media
  • open referencing objects view (-> Details View is empty which is anyway not wanted)
  • go back to term => media is not shown anymore

#5 Updated by Andreas Müller 21 days ago

With the current implementation it is not possible to switch between advanced and simple view but sometimes it is essential to add >1 representations to a media.
In general it is a bit critical to have media together with other data in the details view, because the media part can become large and also because (until now) we do not yet have asynchronous loading for media which makes everything very slow once media are selected.

I can see that we can not use the media view with the current model as it requires a DescriptionBase, but maybe we can a switch in the media view which decides if it should show a media gallery or a simple media list depending on the selected parent.
In general for UX I think it is better if media are always handled the same way (in media view).
These thoughts are only for discussion, I am not sure what the best solution really is.

#6 Updated by Andreas Müller 21 days ago

Katja, can you please cherry pick however. The above problems are minor issues and the media are not used much anyway but urgently needed for additivity.

#7 Updated by Andreas Müller 21 days ago

Andreas Müller wrote:

The data may got lost the following way.

  • Open term
  • add media
  • open referencing objects view (-> Details View is empty which is anyway not wanted)
  • go back to term => media is not shown anymore

Is this maybe related to new implementation in #8316?

#8 Updated by Katja Luther 21 days ago

cherry-picked to hotfix/5.7.3

#9 Updated by Katja Luther 21 days ago

  • Target version changed from Release 5.8 to Release 5.7

#10 Updated by Patrick Plitzner 21 days ago

  • Status changed from Feedback to Resolved

#11 Updated by Andreas Müller 21 days ago

  • Target version changed from Release 5.7 to Release 5.8

PP just added some more code. Could you check if this also needs to be cherry picked.
Revert milestone as not sure if this is already fully implemented.

#12 Updated by Andreas Müller 21 days ago

Or was this code only from the cherry picking? A bit confusing.

#13 Updated by Katja Luther 21 days ago

Andreas Müller wrote:

Or was this code only from the cherry picking? A bit confusing.

Yes this seems to be the cherry-pick.

#14 Updated by Katja Luther 21 days ago

  • Status changed from Resolved to Feedback

#15 Updated by Patrick Plitzner 13 days ago

Andreas Müller wrote:

PP just added some more code. Could you check if this also needs to be cherry picked.
Revert milestone as not sure if this is already fully implemented.

Interesting to see that interaction of cherry-picking and redmine. Not only is my name shown but also the 'fix' set the status back to resolved again.

#16 Updated by Patrick Plitzner 13 days ago

  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 50 to 80

Andreas Müller wrote:

The data may got lost the following way.

  • Open term
  • add media
  • open referencing objects view (-> Details View is empty which is anyway not wanted)
  • go back to term => media is not shown anymore

This does not happen anymore for me. Andreas, can you also try one more time and then we close this ticket and open a new one for the ideas mentioned in #8283#note-5

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)