Project

General

Profile

feature request #8282

Implement placementDoubtful in TaxEditor

Added by Andreas Müller 6 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
05/17/2019
Due date:
% Done:

100%

Severity:
normal
Tags:

Description

TaxonNode will have a doubtful flag (#8281). We need to implement this in TaxEditor, too.

Important is that the labels clearly distinguishes the Taxon.doubful and the TaxonNode.doubtful flag.

We may call it "placement doubtful" or "provisional placement" like in E+M Berlin Model.


Related issues

Related to Edit - feature request #8486: Indicating doubtful state in navigator and add set-doubtful to Set-Flags menu Closed 08/23/2019
Related to Edit - bug #8498: Set Flags should show the current status of the flags In Progress 08/29/2019
Follows Edit - feature request #8281: Doubtful flag for TaxonNode Closed 05/16/2019

Associated revisions

Revision 4601cb73 (diff)
Added by Katja Luther 4 months ago

ref #8282: adapt editor to new doubtful attribute in taxonnode

Revision d12aae39 (diff)
Added by Katja Luther 4 months ago

ref #8282: adapt save taxonnode to new doubtful attribute

Revision b850c728 (diff)
Added by Katja Luther 3 months ago

ref #8282: move doubtful checkbox below publish checkbox

Revision 43ed2498 (diff)
Added by Katja Luther 3 months ago

ref #8282: add setDoubtful to setFlag menu in navigator

Revision 76ab205e (diff)
Added by Katja Luther 3 months ago

ref #8282: adapt order in navigator menu

History

#1 Updated by Andreas Müller 6 months ago

  • Due date set to 05/17/2019
  • Start date changed from 05/16/2019 to 05/17/2019
  • Follows feature request #8281: Doubtful flag for TaxonNode added

#2 Updated by Andreas Müller 4 months ago

  • Due date deleted (05/17/2019)
  • Target version changed from Release 5.8 to Release 5.9

#3 Updated by Katja Luther 4 months ago

  • Status changed from New to In Progress

#4 Updated by Katja Luther 4 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

this is implemented now, please review.

#5 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • Priority changed from New to Highest

The new field should be close to the taxon node information as it is from taxon node. Currently it is in the middle of taxon information.

So we should move "Taxon is published" up and Placement doubtful down.

Also we should indicate the state in the taxon navigator somehow. E.g. by symbol "?" that we normally use for doubtful information. But we use ? already for unplaced. Maybe we find a better symbol for unplaced. If not maybe we use "??" to distinguish. => This might be a separate ticket, don't know how much work it is.

#6 Updated by Andreas Müller 3 months ago

Also we should add the doubtful flag to the "Set flags" method in the taxon navigator right click menu.

#7 Updated by Andreas Müller 3 months ago

  • % Done changed from 0 to 30

#8 Updated by Katja Luther 3 months ago

Andreas Müller wrote:

The new field should be close to the taxon node information as it is from taxon node. Currently it is in the middle of taxon information.

So we should move "Taxon is published" up and Placement doubtful down.

Also we should indicate the state in the taxon navigator somehow. E.g. by symbol "?" that we normally use for doubtful information. But we use ? already for unplaced. Maybe we find a better symbol for unplaced. If not maybe we use "??" to distinguish. => This might be a separate ticket, don't know how much work it is.

the last points I will move to a new ticket

#9 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

the checkbox is moved below the publish checkbox.

#10 Updated by Katja Luther 3 months ago

  • Related to feature request #8486: Indicating doubtful state in navigator and add set-doubtful to Set-Flags menu added

#11 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 30 to 70

Andreas Müller wrote:

Also we should add the doubtful flag to the "Set flags" method in the taxon navigator right click menu.

Seems to be missing still.

#12 Updated by Andreas Müller 3 months ago

Katja Luther wrote:

the checkbox is moved below the publish checkbox.

works as expected. Ticket can be closed once is #note-11 is fixed

#13 Updated by Katja Luther 3 months ago

Andreas Müller wrote:

Andreas Müller wrote:

Also we should add the doubtful flag to the "Set flags" method in the taxon navigator right click menu.

Seems to be missing still.

this is in the follow up ticket, therefore we need a service method, an handler and an operation, I think it would be better to do this in next release. It is not much work but still needs some time to implement everything and test it.

#14 Updated by Katja Luther 3 months ago

  • Assignee changed from Katja Luther to Andreas Müller

#15 Updated by Andreas Müller 3 months ago

ok

#16 Updated by Andreas Müller 3 months ago

  • Status changed from Feedback to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 70 to 100

#17 Updated by Katja Luther 3 months ago

the setDoubtful menu item is now implemented for the navigator, but it was not possible to set the menu to invisible for the classification because when clicking on a classification the menu is removed and afterwards it is not available anymore. So at the moment there is a workaround with disabled menu items for the classification.

#18 Updated by Andreas Müller 3 months ago

  • Status changed from Closed to Feedback
  • % Done changed from 100 to 90

A minor issue: can we have the order of the flags in the same order as in the assistent. That makes it more intuitive. There it is doubtful, unplaced, excluded which is a good order I think.

#19 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

the labels are moved

#20 Updated by Andreas Müller 3 months ago

  • Related to bug #8498: Set Flags should show the current status of the flags added

#21 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 90 to 100

We could still add symbols with the current state of the flag to the "Set Flags" submenu. I created a new ticket for this #8498

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)