Project

General

Profile

Actions
Copy link

bug #825

closed

DefinedTermDaoImpl - missleading method names

Added by Andreas Kohlbecker almost 15 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
New
Assignee:
Andreas Müller
Category:
cdmlib
Target version:
Release 5.27
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
major
Found in Version:
Tags:
fast

Description

DefinedTermDaoImpl implements 

findByTitle(String queryString);
findByTitle(String queryString, CdmBase sessionObject);

which is declared in ITitledDao. The name suggests a search by title the implementation however does a search by label. All other findByTitle methods are implemented correctly.

Actions
Copy link
 #1

Updated by Andreas Kohlbecker almost 15 years ago

  • Severity changed from normal to major
Actions
Copy link
 #2

Updated by Andreas Müller over 14 years ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Andreas K., could you please check if this has been fixed by Ben's latest work on CdmLibraryConventions?

Actions
Copy link
 #3

Updated by Andreas Kohlbecker over 14 years ago

  • Target version changed from CDM lib Release 2.0 to CDM lib Release 2.3
Actions
Copy link
 #4

Updated by Andreas Müller almost 3 years ago

  • Description updated (diff)
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • Target version changed from cdmlib - Old Next Major Release to Release 5.45

This is still an open issue.

Actions
Copy link
 #5

Updated by Andreas Müller almost 3 years ago

  • Tags set to fast
Actions
Copy link
 #6

Updated by Andreas Kohlbecker almost 3 years ago

  • Private changed from Yes to No
Actions
Copy link
 #7

Updated by Andreas Müller over 2 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions
Copy link
 #8

Updated by Andreas Müller over 2 years ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

This is fixed. Please review.

As the old method findByTitle which did override the same labeled parent method seems to be only called by test methods there seems to be no danger that this change created a regression as it is not API but dao.

Actions
Copy link
 #9

Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 5.45 to Release 5.27
Actions
Copy link
 #10

Updated by Andreas Kohlbecker over 2 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 50 to 100

fully solved

Actions
Copy link

Also available in: Atom PDF