Project

General

Profile

bug #8233

[Follow up] Creating type duplicates

Added by Patrick Plitzner about 2 years ago. Updated about 12 hours ago.

Status:
In Progress
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
04/10/2019
Due date:
% Done:

30%

Severity:
normal
Found in Version:

Description

remaining issues from #6413:

  • We should change order, first collection, then accession number.
  • Also the status are not sorted. Order should be same as in details view but on top and preselected should be the most probable status (see "note on available status" in description of this ticket).
  • After selecting the collection it would be a very helpful feature to show already existing specimen candidates for this collection. One can then choose either to use one of theses candidates or to create a new one by entering an explict accession number. If we don't do this now we should do it soon as it will prevent from creating unwanted duplicates.
  • Have we on purpose decided to only show accession number? Shouldn't we also allow barcode and/or catalogue number? Otherwise e.g. for B it will create kind of dirty data which needs to be cleaned up afterwards.
  • Any kind of accession number should not be required as sometimes such a number does not exist, but only collection and status.
  • If I enter a type designation and then add a duplicate without saving in between the first type designation gets lost. Maybe related to #8225? -- The user is now asked to save before cloning
  • If 2 existing type designations have the same field unit they should not be listed both in the "base type" list IMO. In general to me it looks like the base type list should contain field units not specimen or is there a specific reason for using specimen?
  • NK: mir ist gerade aufgefallen, dass ich im TaxEditor beim HInzufügen einer Typusdublette im Fenster (siehe Screenshot) keine Möglichkeit habe den "Preferred stable identifier" anzugeben; dazu muss ich erst schließen und dann den Beleg im Edit-Fenster neu öffnen. Da noch Platz ist und der Stable identifier gerade bei Typen eigentlich die wichtigste Angabe ist, wäre ich sehr dafür, hier noch das Feld hinzuzufügen., =>5.22

Related issues

Related to Edit - feature request #6413: [DISCUSS] How to create type duplicates (e.g. isotypes) for a taxon name Closed 02/08/2017

Associated revisions

Revision 62b9b524 (diff)
Added by Patrick Plitzner about 2 years ago

ref #8233 Move collection above accession number

Revision d46d8905 (diff)
Added by Patrick Plitzner about 2 years ago

ref #8233 Do not evaluate accession number for "Finish" button

Revision 06122990 (diff)
Added by Patrick Plitzner about 2 years ago

ref #8233 Ask for saving before cloning type designation

Revision 3262af01 (diff)
Added by Patrick Plitzner about 2 years ago

ref #8233 Add barcode and catalog number to clone type service method

Revision 59f0afe5 (diff)
Added by Patrick Plitzner about 2 years ago

ref #8233 Add barcode and catalog number to clone type functionality

Revision e978c93a (diff)
Added by Patrick Plitzner about 2 years ago

ref #8233 Add barcode and catalog number to clone type functionality

Revision e600002d (diff)
Added by Patrick Plitzner about 2 years ago

ref #8233 Add barcode and catalog number to clone type service method

Revision 8d3e080c (diff)
Added by Katja Luther 7 days ago

ref #8233: add pref stable identifier field in duplicate type designation wizard

Revision 2119bbcd (diff)
Added by Katja Luther 7 days ago

ref #8233: add pref stable identifier to cloneTypedesignation method

Revision a9d8d871 (diff)
Added by Katja Luther 7 days ago

ref #8233: adapt method call for clone typedesignation

Revision 031d9fa1 (diff)
Added by Katja Luther 7 days ago

ref #8233: restructure clone type designation wizard

History

#1 Updated by Patrick Plitzner about 2 years ago

  • Subject changed from Creatiny type duplicates follow-up to [Follow up] Creating type duplicates

#2 Updated by Patrick Plitzner about 2 years ago

  • Related to feature request #6413: [DISCUSS] How to create type duplicates (e.g. isotypes) for a taxon name added

#3 Updated by Patrick Plitzner about 2 years ago

  • Description updated (diff)

#4 Updated by Patrick Plitzner about 2 years ago

  • Target version changed from Release 5.7 to Release 5.6

#5 Updated by Patrick Plitzner about 2 years ago

  • Description updated (diff)

#6 Updated by Patrick Plitzner about 2 years ago

  • Description updated (diff)
  • Status changed from New to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

@Andreas: Could you review the fixed issues and, if everything works, move this ticket to 5.7 again?

#7 Updated by Andreas Müller about 2 years ago

  • Status changed from Resolved to In Progress
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • Target version changed from Release 5.6 to Release 5.7

The fixes work as expected. A minor issue: as type status is a required field but Accession number etc are not we should maybe move type status up below collection (or above?). Alternatively we could do indentation for Accession number etc. to show they are not on the same level as collection and type status. My preferred solution would even be to put Accession number etc. all to 1 row beside each other to show that they are alternatives and should not usually filled all.

However this is not release critical and can be done in 5.7 if there is no time for it now.

#8 Updated by Patrick Plitzner almost 2 years ago

  • Target version changed from Release 5.7 to Release 5.8

#9 Updated by Patrick Plitzner almost 2 years ago

  • Target version changed from Release 5.8 to Release 5.10

Move to next milestone for 5.8 release

#10 Updated by Patrick Plitzner over 1 year ago

  • Target version changed from Release 5.10 to Release 5.11

#11 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.11 to Release 5.12

#12 Updated by Andreas Müller over 1 year ago

  • Assignee changed from Patrick Plitzner to Katja Luther

#13 Updated by Katja Luther over 1 year ago

  • Target version changed from Release 5.12 to Release 5.13

#14 Updated by Katja Luther about 1 year ago

  • Target version changed from Release 5.13 to Release 5.14

#15 Updated by Andreas Müller about 1 year ago

  • Description updated (diff)

#16 Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 5.14 to Release 5.15

#17 Updated by Andreas Müller about 1 year ago

  • % Done changed from 0 to 20

#18 Updated by Katja Luther 12 months ago

  • Target version changed from Release 5.15 to Release 5.18

#19 Updated by Katja Luther 5 months ago

  • Target version changed from Release 5.18 to Release 5.19

#20 Updated by Andreas Müller 3 months ago

  • Target version changed from Release 5.19 to Release 5.21

#21 Updated by Katja Luther about 1 month ago

  • Target version changed from Release 5.21 to Release 5.22

#22 Updated by Andreas Müller about 1 month ago

  • Tags set to fast

I add the "fast" tag for the last issue ("Add "Preferred Stable Identifier" to the list of available identifiers"). It can be removed once this issue is implemented.

#23 Updated by Andreas Müller about 1 month ago

  • Priority changed from New to Highest

#24 Updated by Katja Luther 8 days ago

Andreas Müller wrote:

I add the "fast" tag for the last issue ("Add "Preferred Stable Identifier" to the list of available identifiers"). It can be removed once this issue is implemented.

There is already a field preferredStableUri in SpecimenOrObservationBase, shouldn't we use this, instead of adding the stable identifier to the identifiers?

#25 Updated by Katja Luther 7 days ago

  • Description updated (diff)

#26 Updated by Katja Luther 7 days ago

  • Description updated (diff)

#27 Updated by Andreas Müller 7 days ago

  • Description updated (diff)

Katja Luther wrote:

Andreas Müller wrote:

I add the "fast" tag for the last issue ("Add "Preferred Stable Identifier" to the list of available identifiers"). It can be removed once this issue is implemented.

There is already a field preferredStableUri in SpecimenOrObservationBase, shouldn't we use this, instead of adding the stable identifier to the identifiers?

This is how it was meant. Therefore I removed the first "NK" issue as it is a duplicate.

#28 Updated by Katja Luther 7 days ago

  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

I add the "fast" tag for the last issue ("Add "Preferred Stable Identifier" to the list of available identifiers"). It can be removed once this issue is implemented.

There is already a field preferredStableUri in SpecimenOrObservationBase, shouldn't we use this, instead of adding the stable identifier to the identifiers?

This is how it was meant. Therefore I removed the first "NK" issue as it is a duplicate.

Ok, then please review this issue.

#29 Updated by Katja Luther 7 days ago

  • Assignee changed from Andreas Müller to Katja Luther

#30 Updated by Katja Luther 7 days ago

  • Assignee changed from Katja Luther to Andreas Müller

Sorry I missed to push some files, please review now.

#31 Updated by Andreas Müller 7 days ago

  • Status changed from In Progress to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Katja Luther wrote:

Andreas Müller wrote:

...
This is how it was meant. Therefore I removed the first "NK" issue as it is a duplicate.

Ok, then please review this issue.

The stable URI is not yet persisted.
Also it should appear below the other identifiers (and there for above the type category which should come at the bottom.

#32 Updated by Katja Luther 7 days ago

  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

...
This is how it was meant. Therefore I removed the first "NK" issue as it is a duplicate.

Ok, then please review this issue.

The stable URI is not yet persisted.

see above.

Also it should appear below the other identifiers (and there for above the type category which should come at the bottom.

I moved the type category above the base type to have the type informations and the specimen information together

#33 Updated by Andreas Müller 6 days ago

  • Tags deleted (fast)
  • Description updated (diff)
  • Status changed from Feedback to In Progress
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 20 to 30

The persistent identifier issue works now. I set the ticket back to "In progress" as there are other remaining issues.

#34 Updated by Andreas Müller 6 days ago

  • Description updated (diff)

#35 Updated by Katja Luther about 12 hours ago

  • Target version changed from Release 5.22 to Release 5.23

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)