Project

General

Profile

Actions

bug #8176

closed

WeaklyRelatedEntityCombobox is slow

Added by Andreas Kohlbecker almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Highest
Category:
cdm-vaadin
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Description

on setting values

The WeaklyRelatedEntityCombobox needs to check if the value to set is at all contained in the list of available values.

This check is currently implemented by making use of the lazySelect.getOptions().contains() method:

// WeaklyRelatedEntityCombobox.setValue()

if(lazySelect.getOptions().contains(newFieldValue)){
    lazySelect.setValue(newFieldValue);
}

This however causes the LazyList to page through all elements until the supplied object is found.

during re-paint calls

This problem is harder to fix.

In the ReloadableLazyComboBox.reload() it is necessary to set the combobox to scrollToSelectedItem=true otherwise the combobox will not have the matching set of options items and this will fail to set the select attribute to the value which set to the component.

Actions #1

Updated by Andreas Kohlbecker almost 4 years ago

  • Subject changed from WeaklyRelatedEntityCombobox is sloooooooow on setting value to WeaklyRelatedEntityCombobox is slow
  • Description updated (diff)
Actions #2

Updated by Andreas Kohlbecker almost 4 years ago

  • Description updated (diff)
  • Status changed from New to In Progress
Actions #3

Updated by Andreas Kohlbecker almost 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 50

test TaxonNamePopupEditor Genus field, replaced Synonym and Basionym also some ToManyRelatedEntitiesComboboxes and ToOneRelatedComboboxes

Actions #4

Updated by Andreas Kohlbecker almost 4 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

The WeaklyRelatedEntityCombobox is no longer causing performance problems and edit as well create buttons are working as well as the updating of the WeaklyRelatedEntityCombobox in the TaxonNamePopupEditor

Actions

Also available in: Atom PDF