Project

General

Profile

bug #8176

WeaklyRelatedEntityCombobox is slow

Added by Andreas Kohlbecker 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Highest
Category:
cdm-vaadin
Target version:
Start date:
03/12/2019
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

on setting values

The WeaklyRelatedEntityCombobox needs to check if the value to set is at all contained in the list of available values.

This check is currently implemented by making use of the lazySelect.getOptions().contains() method:

// WeaklyRelatedEntityCombobox.setValue()

if(lazySelect.getOptions().contains(newFieldValue)){
    lazySelect.setValue(newFieldValue);
}

This however causes the LazyList to page through all elements until the supplied object is found.

during re-paint calls

This problem is harder to fix.

In the ReloadableLazyComboBox.reload() it is necessary to set the combobox to scrollToSelectedItem=true otherwise the combobox will not have the matching set of options items and this will fail to set the select attribute to the value which set to the component.

Associated revisions

Revision af0633ea (diff)
Added by Andreas Kohlbecker 7 months ago

ref #8176 WeaklyRelatedEntityCombobox solving minor performance on setValue

Revision eb8d2f54 (diff)
Added by Andreas Kohlbecker 7 months ago

ref #8176 bugfix in TaxonNameStringFilterablePagingProvider.idFor()

Revision aec76ebb (diff)
Added by Andreas Kohlbecker 7 months ago

ref #8176 removing workaround with bad performance which was need for broken TaxonNameStringFilterablePagingProvider.idFor()

Revision 572b86b7 (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8176 fixing edit button functionality in WeaklyRelatedEntityCombobox

Revision 521f90aa (diff)
Added by Andreas Kohlbecker 6 months ago

ref #8176 fixing refreshing of specificEpithet after editing the name via the WeaklyRelatedEntityCombobox edit button

History

#1 Updated by Andreas Kohlbecker 7 months ago

  • Subject changed from WeaklyRelatedEntityCombobox is sloooooooow on setting value to WeaklyRelatedEntityCombobox is slow
  • Description updated (diff)

#2 Updated by Andreas Kohlbecker 7 months ago

  • Description updated (diff)
  • Status changed from New to In Progress

#3 Updated by Andreas Kohlbecker 7 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 50

test TaxonNamePopupEditor Genus field, replaced Synonym and Basionym also some ToManyRelatedEntitiesComboboxes and ToOneRelatedComboboxes

#4 Updated by Andreas Kohlbecker 6 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

The WeaklyRelatedEntityCombobox is no longer causing performance problems and edit as well create buttons are working as well as the updating of the WeaklyRelatedEntityCombobox in the TaxonNamePopupEditor

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)