Project

General

Profile

feature request #8153

Adapt cdmlib to FeatureNode/FeatureTree model changes

Added by Patrick Plitzner 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
New
Category:
cdmlib
Target version:
Start date:
02/28/2019
Due date:
% Done:

70%

Severity:
normal

Description

  • Since the introduction of term trees with the last model change (5.6.0) FeatureNode.getFeature() is deprecated and could lead to potential ClassCastExceptions. The usages of this method should be inspected and corrected.
  • Reflect the termType of term trees where possible

Related issues

Related to Edit - feature request #8146: Adapt taxeditor UI to structure and property term type Closed 02/27/2019

Associated revisions

Revision cc0fa0be (diff)
Added by Patrick Plitzner 6 months ago

ref #8153 Adapt cdmlib to model changes

  • Add constructor for creating a FeatureNode for a given termType
  • Adjust feature node service to model changes

Revision cb9ebcd2 (diff)
Added by Patrick Plitzner 6 months ago

ref #8153 Further adapt cdmlib to model changes

  • Adjust feature node service to model changes

Revision 983949ab (diff)
Added by Patrick Plitzner 6 months ago

ref #8153 Fix feature tree type check for distinct features

Revision 6ae3aa93 (diff)
Added by Andreas Müller 5 months ago

ref #8153 adapt ColumnAdder and ColumnTypeChanger to handle NOT NULL correctly for auditing tables

Revision 291febb1 (diff)
Added by Patrick Plitzner 4 months ago

ref #8153 Adapt cdmlib to model changes

  • Add constructor for creating a FeatureNode for a given termType
  • Adjust feature node service to model changes

Revision 9779f8dc (diff)
Added by Patrick Plitzner 4 months ago

ref #8153 Further adapt cdmlib to model changes

  • Adjust feature node service to model changes

Revision f61c00e5 (diff)
Added by Patrick Plitzner 4 months ago

ref #8153 Fix feature tree type check for distinct features

Revision 4e55f365 (diff)
Added by Andreas Müller 4 months ago

ref #8153 adapt ColumnAdder and ColumnTypeChanger to handle NOT NULL correctly for auditing tables

History

#1 Updated by Patrick Plitzner 6 months ago

  • Subject changed from Clean up usage of deprecated FeatureNode.getFeature() to Adapt cdmlib to FeatureNode/FeatureTree model changes
  • Description updated (diff)

#2 Updated by Andreas Müller 5 months ago

  • Status changed from New to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

is this still an open issue? If yes, can you give more inside?

#3 Updated by Patrick Plitzner 5 months ago

By introducing the generics this is probably done. There is still some code which does not use/specify generics but this canbe adapted if necessary.

Should we close this?

#4 Updated by Patrick Plitzner 5 months ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

#5 Updated by Andreas Müller 5 months ago

#6 Updated by Andreas Müller 5 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 70

from my side we can close it, but I didn't check full code.
Patrick, could you still add "open issues" if you know where something is still missing.

However, this is not critical as Generics are only developping convenience here.

Katja, can you have a look on it and close if you think it is correct.

#7 Updated by Katja Luther 5 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Patrick Plitzner

I had a look on the changesets and it looks ok, so I close this ticket. For the generics we can open a new ticket.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)