Project

General

Profile

Actions
Copy link

feature request #8153

closed

Adapt cdmlib to FeatureNode/FeatureTree model changes

Added by Patrick Plitzner almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
New
Assignee:
Patrick Plitzner
Category:
cdmlib
Target version:
Release 5.6
Start date:
Due date:
% Done:

70%

Estimated time:
Severity:
normal

Description

  • Since the introduction of term trees with the last model change (5.6.0) FeatureNode.getFeature() is deprecated and could lead to potential ClassCastExceptions. The usages of this method should be inspected and corrected.
  • Reflect the termType of term trees where possible

Related issues

Related to EDIT - feature request #8146: Adapt taxeditor UI to structure and property term typeClosedPatrick Plitzner

Actions
Actions
Copy link
 #1

Updated by Patrick Plitzner almost 4 years ago

  • Subject changed from Clean up usage of deprecated FeatureNode.getFeature() to Adapt cdmlib to FeatureNode/FeatureTree model changes
  • Description updated (diff)
Actions
Copy link
 #2

Updated by Andreas Müller almost 4 years ago

  • Status changed from New to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

is this still an open issue? If yes, can you give more inside?

Actions
Copy link
 #3

Updated by Patrick Plitzner almost 4 years ago

By introducing the generics this is probably done. There is still some code which does not use/specify generics but this canbe adapted if necessary.

Should we close this?

Actions
Copy link
 #4

Updated by Patrick Plitzner almost 4 years ago

  • Assignee changed from Patrick Plitzner to Andreas Müller
Actions
Copy link
 #5

Updated by Andreas Müller almost 4 years ago

Actions
Copy link
 #6

Updated by Andreas Müller almost 4 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 70

from my side we can close it, but I didn't check full code.
Patrick, could you still add "open issues" if you know where something is still missing.

However, this is not critical as Generics are only developping convenience here.

Katja, can you have a look on it and close if you think it is correct.

Actions
Copy link
 #7

Updated by Katja Luther almost 4 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Katja Luther to Patrick Plitzner

I had a look on the changesets and it looks ok, so I close this ticket. For the generics we can open a new ticket.

Actions
Copy link

Also available in: Atom PDF