Project

General

Profile

feature request #8134

Implement verbatim type information in dataportal

Added by Andreas Müller over 1 year ago. Updated about 2 months ago.

Status:
In Progress
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
02/24/2019
Due date:
% Done:

20%

Severity:
normal

Description

For details see also #7653#note-5.

Implementation of verbatim type information in cdm in #7470


Related issues

Related to Edit - feature request #7653: [DISCUSS] Delete NameFacts => Result: no Closed 08/14/2018
Related to Edit - feature request #8135: Implement verbatim type information in TaxEditor Closed 02/24/2019
Related to Edit - feature request #8137: Implement sources for type designations in data portal New 02/24/2019
Blocked by Edit - feature request #8538: add text_l10n for TextualTypeDesignation.text to web service respones Closed 09/11/2019

Associated revisions

Revision 2d95e99f (diff)
Added by Andreas Kohlbecker 9 months ago

ref #8134 displaying textual type designations in the taxon synonymy and in the name page

Revision 85ac09e7 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #8134 reverting change which caused duplication of annotation footnotes

Revision 0fd965ee (diff)
Added by Andreas Kohlbecker 8 months ago

ref #8134 simplifying code

Revision bd131507 (diff)
Added by Andreas Kohlbecker 8 months ago

ref #8134 fixing wrong case in type designation status labels

History

#1 Updated by Andreas Müller over 1 year ago

#2 Updated by Andreas Müller over 1 year ago

#3 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#4 Updated by Andreas Müller over 1 year ago

#5 Updated by Andreas Müller over 1 year ago

#6 Updated by Andreas Kohlbecker about 1 year ago

  • Target version changed from Release 5.6 to Release 5.7

#7 Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 5.7 to Release 5.8

#8 Updated by Andreas Kohlbecker 10 months ago

  • Target version changed from Release 5.8 to Release 5.10

#9 Updated by Andreas Müller 10 months ago

  • Target version changed from Release 5.10 to Release 5.9

related to issues in 5.9 so maybe we can implement it then

#10 Updated by Andreas Kohlbecker 10 months ago

  • Target version changed from Release 5.9 to Release 5.10

#11 Updated by Andreas Kohlbecker 9 months ago

  • Status changed from New to Feedback
  • Assignee changed from Andreas Kohlbecker to Andreas Müller

Hi Andreas,

the verbatim type information is represented by the class TextualTypeDesignation. This class has a boolean flag isVerbatim. The documentation of this flag is

    /**
     * Flag indicating if this textual type designation is a citation (e.g. original citation).
     * This may have influence on the correct formatting of type designations.
     */

why is the flag not named like isCitation and how do you expect the portal to behave with respect to this flag?

#12 Updated by Andreas Kohlbecker 9 months ago

  • Blocked by feature request #7696: use compact type representations in the synonymy as provided by the typedesignations/byTaxon/{taxon_uuid} service added

#13 Updated by Andreas Kohlbecker 9 months ago

  • Blocked by deleted (feature request #7696: use compact type representations in the synonymy as provided by the typedesignations/byTaxon/{taxon_uuid} service)

#14 Updated by Andreas Kohlbecker 9 months ago

  • Blocked by feature request #8538: add text_l10n for TextualTypeDesignation.text to web service respones added

#15 Updated by Andreas Kohlbecker 9 months ago

#16 Updated by Andreas Müller 9 months ago

Andreas Kohlbecker wrote:

Hi Andreas,

the verbatim type information is represented by the class TextualTypeDesignation. This class has a boolean flag isVerbatim. The documentation of this flag is

    /**
     * Flag indicating if this textual type designation is a citation (e.g. original citation).
     * This may have influence on the correct formatting of type designations.
     */

why is the flag not named like isCitation and how do you expect the portal to behave with respect to this flag?

isVerbatim was the label agreed with the users, I think semantics is very similar.

How shoul it look like: finally the users must decide. Maybe those listening to this ticket may give advise. Until then we may start with "text"

#17 Updated by Andreas Müller 9 months ago

  • Status changed from Feedback to New
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

#18 Updated by Andreas Kohlbecker 9 months ago

[Feedback from Walter]

Hallo,

mit Bezug auf das Portal folgender Vorschlag meinerseits:
Wenn nach dem Ausgabetext die Quelle zitiert wird, dann sollte der Text in Anführungszeichen gesetzt werden, wenn isVerbatim gesetzt ist.

verbatim heißt wörtlich, das ist also eine Untermenge von Zitat (zitieren kann man auch in indirekter Form).
Die Quellreferenz impliziert indirekte Zitate.

Herzlichen Gruß
Walter

#19 Updated by Andreas Kohlbecker 9 months ago

  • Status changed from New to In Progress

#20 Updated by Andreas Kohlbecker 9 months ago

The textual type designation are now at least shown in the taxon synonymy and in the name page.

Open issues are:

  • show verbatim type information in
    • registration page
    • various specimen views
  • show sources and annotations (The cdm-dataportal|2d95e99f already contains some code for this but there are still problems to be solved)
  • Implement tests

#21 Updated by Andreas Kohlbecker 9 months ago

  • % Done changed from 0 to 20

#22 Updated by Andreas Kohlbecker 9 months ago

test data dumped and stored in testdata/edit-int/testdb/5.10/cdm_integrationreference-2019-09-11-001.sql.bz2

#23 Updated by Andreas Müller 9 months ago

Andreas Kohlbecker wrote:

The textual type designation are now at least shown in the taxon synonymy and in the name page.

Open issues are:

  • show verbatim type information in
    • registration page
    • various specimen views
  • show sources and annotations (The cdm-dataportal|2d95e99f already contains some code for this but there are still problems to be solved)
  • Implement tests

How far can this be shown on specimen views? As it is purely textual there is no structured relationship to specimen.

#24 Updated by Andreas Kohlbecker 8 months ago

  • Target version changed from Release 5.10 to Release 5.11

#25 Updated by Andreas Kohlbecker 7 months ago

  • Target version changed from Release 5.11 to Release 5.12

#26 Updated by Andreas Kohlbecker 5 months ago

  • Target version changed from Release 5.12 to Release 5.13

#27 Updated by Andreas Kohlbecker 2 months ago

  • Target version changed from Release 5.13 to Release 5.14

#28 Updated by Andreas Kohlbecker about 2 months ago

  • Target version changed from Release 5.14 to Release 5.15

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)