Project

General

Profile

feature request #8134

Implement verbatim type information in dataportal

Added by Andreas Müller over 1 year ago. Updated 4 months ago.

Status:
Closed
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
02/24/2019
Due date:
% Done:

100%

Severity:
normal

Description

For details see also #7653#note-5.

Implementation of verbatim type information in cdm in #7470


Related issues

Related to Edit - feature request #7653: [DISCUSS] Delete NameFacts => Result: no Closed 08/14/2018
Related to Edit - feature request #8135: Implement verbatim type information in TaxEditor Closed 02/24/2019
Related to Edit - feature request #8137: Implement sources for type designations in data portal New 02/24/2019
Related to Edit - feature request #7470: Verbatim type designation information Closed 06/12/2018
Blocked by Edit - feature request #8538: add text_l10n for TextualTypeDesignation.text to web service respones Closed 09/11/2019
Copied to Edit - bug #9087: typedesignation/{uuid}/annotations must return pager objects Closed 06/22/2020
Copied to Edit - feature request #9117: show textual type information in registration page New 02/24/2019

Associated revisions

Revision 2d95e99f (diff)
Added by Andreas Kohlbecker about 1 year ago

ref #8134 displaying textual type designations in the taxon synonymy and in the name page

Revision 85ac09e7 (diff)
Added by Andreas Kohlbecker about 1 year ago

ref #8134 reverting change which caused duplication of annotation footnotes

Revision 0fd965ee (diff)
Added by Andreas Kohlbecker about 1 year ago

ref #8134 simplifying code

Revision bd131507 (diff)
Added by Andreas Kohlbecker about 1 year ago

ref #8134 fixing wrong case in type designation status labels

Revision 0c720425 (diff)
Added by Andreas Kohlbecker 4 months ago

ref #8134 refactoring theme to render function

Revision 79904336 (diff)
Added by Andreas Kohlbecker 4 months ago

ref #8134 moving render_type_designations() to include file

Revision 829d7f26 (diff)
Added by Andreas Kohlbecker 4 months ago

ref #8134 render_type_designations() cleaning code

Revision 6325c7ad (diff)
Added by Andreas Kohlbecker 4 months ago

ref #8134 test for TextualTypeDesignation (requires new page class: NamePage)

Revision 1ce6e8ce (diff)
Added by Andreas Kohlbecker 4 months ago

ref #8134 trimming text

Revision a6c4c53c (diff)
Added by Andreas Kohlbecker 4 months ago

ref #8134 dealing with web service problems returning list instead of pagers and better placement of footnotes

Revision 45b496bc (diff)
Added by Andreas Kohlbecker 4 months ago

ref #8134 fixing missing initialization of TaonNode.statusNode and source.citation

Revision 867d1f58 (diff)
Added by Andreas Kohlbecker 4 months ago

ref #8134 fixing missing render_type_designations()

Revision 04d5812b (diff)
Added by Andreas Kohlbecker 4 months ago

ref #8134 deterministic sort order for type designations

Revision f639f3b7 (diff)
Added by Andreas Kohlbecker 4 months ago

ref #8134 deterministic sort order for type designations - adapting test

Revision e5a89a58 (diff)
Added by Andreas Kohlbecker 4 months ago

ref #8134 deterministic sort order for type designations - bug fix

Revision 3a81b245 (diff)
Added by Andreas Kohlbecker 4 months ago

ref #8134 using other error message channel

History

#1 Updated by Andreas Müller over 1 year ago

#2 Updated by Andreas Müller over 1 year ago

#3 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#4 Updated by Andreas Müller over 1 year ago

#5 Updated by Andreas Müller over 1 year ago

#6 Updated by Andreas Kohlbecker over 1 year ago

  • Target version changed from Release 5.6 to Release 5.7

#7 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.7 to Release 5.8

#8 Updated by Andreas Kohlbecker over 1 year ago

  • Target version changed from Release 5.8 to Release 5.10

#9 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 5.10 to Release 5.9

related to issues in 5.9 so maybe we can implement it then

#10 Updated by Andreas Kohlbecker about 1 year ago

  • Target version changed from Release 5.9 to Release 5.10

#11 Updated by Andreas Kohlbecker about 1 year ago

  • Status changed from New to Feedback
  • Assignee changed from Andreas Kohlbecker to Andreas Müller

Hi Andreas,

the verbatim type information is represented by the class TextualTypeDesignation. This class has a boolean flag isVerbatim. The documentation of this flag is

    /**
     * Flag indicating if this textual type designation is a citation (e.g. original citation).
     * This may have influence on the correct formatting of type designations.
     */

why is the flag not named like isCitation and how do you expect the portal to behave with respect to this flag?

#12 Updated by Andreas Kohlbecker about 1 year ago

  • Blocked by feature request #7696: use compact type representations in the synonymy as provided by the typedesignations/byTaxon/{taxon_uuid} service added

#13 Updated by Andreas Kohlbecker about 1 year ago

  • Blocked by deleted (feature request #7696: use compact type representations in the synonymy as provided by the typedesignations/byTaxon/{taxon_uuid} service)

#14 Updated by Andreas Kohlbecker about 1 year ago

  • Blocked by feature request #8538: add text_l10n for TextualTypeDesignation.text to web service respones added

#15 Updated by Andreas Kohlbecker about 1 year ago

#16 Updated by Andreas Müller about 1 year ago

Andreas Kohlbecker wrote:

Hi Andreas,

the verbatim type information is represented by the class TextualTypeDesignation. This class has a boolean flag isVerbatim. The documentation of this flag is

    /**
     * Flag indicating if this textual type designation is a citation (e.g. original citation).
     * This may have influence on the correct formatting of type designations.
     */

why is the flag not named like isCitation and how do you expect the portal to behave with respect to this flag?

isVerbatim was the label agreed with the users, I think semantics is very similar.

How shoul it look like: finally the users must decide. Maybe those listening to this ticket may give advise. Until then we may start with "text"

#17 Updated by Andreas Müller about 1 year ago

  • Status changed from Feedback to New
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

#18 Updated by Andreas Kohlbecker about 1 year ago

[Feedback from Walter]

Hallo,

mit Bezug auf das Portal folgender Vorschlag meinerseits:
Wenn nach dem Ausgabetext die Quelle zitiert wird, dann sollte der Text in Anführungszeichen gesetzt werden, wenn isVerbatim gesetzt ist.

verbatim heißt wörtlich, das ist also eine Untermenge von Zitat (zitieren kann man auch in indirekter Form).
Die Quellreferenz impliziert indirekte Zitate.

Herzlichen Gruß
Walter

#19 Updated by Andreas Kohlbecker about 1 year ago

  • Status changed from New to In Progress

#20 Updated by Andreas Kohlbecker about 1 year ago

The textual type designation are now at least shown in the taxon synonymy and in the name page.

Open issues are:

  • show verbatim type information in
    • registration page
    • various specimen views
  • show sources and annotations (The cdm-dataportal|2d95e99f already contains some code for this but there are still problems to be solved)
  • Implement tests

#21 Updated by Andreas Kohlbecker about 1 year ago

  • % Done changed from 0 to 20

#22 Updated by Andreas Kohlbecker about 1 year ago

test data dumped and stored in testdata/edit-int/testdb/5.10/cdm_integrationreference-2019-09-11-001.sql.bz2

#23 Updated by Andreas Müller about 1 year ago

Andreas Kohlbecker wrote:

The textual type designation are now at least shown in the taxon synonymy and in the name page.

Open issues are:

  • show verbatim type information in
    • registration page
    • various specimen views
  • show sources and annotations (The cdm-dataportal|2d95e99f already contains some code for this but there are still problems to be solved)
  • Implement tests

How far can this be shown on specimen views? As it is purely textual there is no structured relationship to specimen.

#24 Updated by Andreas Kohlbecker about 1 year ago

  • Target version changed from Release 5.10 to Release 5.11

#25 Updated by Andreas Kohlbecker 12 months ago

  • Target version changed from Release 5.11 to Release 5.12

#26 Updated by Andreas Kohlbecker 10 months ago

  • Target version changed from Release 5.12 to Release 5.13

#27 Updated by Andreas Kohlbecker 7 months ago

  • Target version changed from Release 5.13 to Release 5.14

#28 Updated by Andreas Kohlbecker 7 months ago

  • Target version changed from Release 5.14 to Release 5.15

#29 Updated by Andreas Kohlbecker 4 months ago

Andreas Müller wrote:

Andreas Kohlbecker wrote:

The textual type designation are now at least shown in the taxon synonymy and in the name page.

Open issues are:

  • show verbatim type information in
    • registration page
    • various specimen views
  • show sources and annotations (The cdm-dataportal|2d95e99f already contains some code for this but there are still problems to be solved)
  • Implement tests

How far can this be shown on specimen views? As it is purely textual there is no structured relationship to specimen.

Your are right, the requirement to show textual type designations on specimen pages is nonsense.

So the open issues are:

Open issues are:

  • show verbatim type information registration page
  • show sources and annotations (The cdm-dataportal|2d95e99f already contains some code for this but there are still problems to be solved)
  • Implement tests

#30 Updated by Andreas Kohlbecker 4 months ago

  • % Done changed from 20 to 40

TextualTypeDesignation are not supposed to contain validly published type designations, therefore it makes no sense to implement their display for registration pages. There never should be a Registration for a name without published type designation.

Open issues are:

  • show sources and annotations (The cdm-dataportal|2d95e99f already contains some code for this but there are still problems to be solved)
  • Implement tests just implemented

#31 Updated by Andreas Müller 4 months ago

Andreas Kohlbecker wrote:

TextualTypeDesignation are not supposed to contain validly published type designations, therefore it makes no sense to implement their display for registration pages. There never should be a Registration for a name without published type designation.

I am not sure if this is true. There no reason why TextualTypeDesignations should not be used for validly published type designations. The only difference between textual and specimen based type designations is that the specimen is explicitly linked in the latter case while it is not in first case. There is even a discussion if TextualTypeDesingations should only be used for real type designations (but maybe some of them not valid).

#32 Updated by Andreas Müller 4 months ago

#33 Updated by Andreas Kohlbecker 4 months ago

  • Copied to bug #9087: typedesignation/{uuid}/annotations must return pager objects added

#34 Updated by Andreas Kohlbecker 4 months ago

  • % Done changed from 40 to 20

Andreas Müller wrote:

Andreas Kohlbecker wrote:

TextualTypeDesignation are not supposed to contain validly published type designations, therefore it makes no sense to implement their display for registration pages. There never should be a Registration for a name without published type designation.

I am not sure if this is true. There no reason why TextualTypeDesignations should not be used for validly published type designations. The only difference between textual and specimen based type designations is that the specimen is explicitly linked in the latter case while it is not in first case. There is even a discussion if TextualTypeDesingations should only be used for real type designations (but maybe some of them not valid).

You are right, the textual type information is also intended to be used for information that can not be atomized with current data model.

So there is one last bit to do here:

  • show textual type information in registration page

#35 Updated by Andreas Kohlbecker 4 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 20 to 50

#36 Updated by Andreas Kohlbecker 4 months ago

#37 Updated by Andreas Kohlbecker 4 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

Andreas Kohlbecker wrote:

So there is one last bit to do here:

  • show textual type information in registration page

this last task has been copied to #9117

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)