Project

General

Profile

Actions

feature request #8134

closed

Implement verbatim type information in dataportal

Added by Andreas Müller almost 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

For details see also #7653#note-5.

Implementation of verbatim type information in cdm in #7470


Related issues

Related to EDIT - feature request #7653: [DISCUSS] Delete NameFacts => Result: noClosedAndreas Müller

Actions
Related to EDIT - feature request #8135: Implement verbatim type information in TaxEditorClosedPatrick Plitzner

Actions
Related to EDIT - feature request #8137: Implement sources for type designations in data portalNewKatja Luther

Actions
Related to EDIT - feature request #7470: Verbatim type designation informationClosedAndreas Müller

Actions
Blocked by EDIT - feature request #8538: add text_l10n for TextualTypeDesignation.text to web service responesClosedAndreas Kohlbecker

Actions
Copied to EDIT - bug #9087: typedesignation/{uuid}/annotations must return pager objectsClosedAndreas Kohlbecker

Actions
Copied to EDIT - feature request #9117: show textual type information in registration pageNewAndreas Kohlbecker

Actions
Actions #1

Updated by Andreas Müller almost 4 years ago

Actions #2

Updated by Andreas Müller almost 4 years ago

Actions #3

Updated by Andreas Müller almost 4 years ago

  • Description updated (diff)
Actions #4

Updated by Andreas Müller almost 4 years ago

Actions #5

Updated by Andreas Müller almost 4 years ago

Actions #6

Updated by Andreas Kohlbecker over 3 years ago

  • Target version changed from Release 5.6 to Release 5.7
Actions #7

Updated by Andreas Müller over 3 years ago

  • Target version changed from Release 5.7 to Release 5.8
Actions #8

Updated by Andreas Kohlbecker over 3 years ago

  • Target version changed from Release 5.8 to Release 5.10
Actions #9

Updated by Andreas Müller over 3 years ago

  • Target version changed from Release 5.10 to Release 5.9

related to issues in 5.9 so maybe we can implement it then

Actions #10

Updated by Andreas Kohlbecker over 3 years ago

  • Target version changed from Release 5.9 to Release 5.10
Actions #11

Updated by Andreas Kohlbecker about 3 years ago

  • Status changed from New to Feedback
  • Assignee changed from Andreas Kohlbecker to Andreas Müller

Hi Andreas,

the verbatim type information is represented by the class TextualTypeDesignation. This class has a boolean flag isVerbatim. The documentation of this flag is

    /**
     * Flag indicating if this textual type designation is a citation (e.g. original citation).
     * This may have influence on the correct formatting of type designations.
     */

why is the flag not named like isCitation and how do you expect the portal to behave with respect to this flag?

Actions #12

Updated by Andreas Kohlbecker about 3 years ago

  • Blocked by feature request #7696: use compact type representations in the synonymy as provided by the typedesignations/byTaxon/{taxon_uuid} service added
Actions #13

Updated by Andreas Kohlbecker about 3 years ago

  • Blocked by deleted (feature request #7696: use compact type representations in the synonymy as provided by the typedesignations/byTaxon/{taxon_uuid} service)
Actions #14

Updated by Andreas Kohlbecker about 3 years ago

  • Blocked by feature request #8538: add text_l10n for TextualTypeDesignation.text to web service respones added
Actions #15

Updated by Andreas Kohlbecker about 3 years ago

Actions #16

Updated by Andreas Müller about 3 years ago

Andreas Kohlbecker wrote:

Hi Andreas,

the verbatim type information is represented by the class TextualTypeDesignation. This class has a boolean flag isVerbatim. The documentation of this flag is

    /**
     * Flag indicating if this textual type designation is a citation (e.g. original citation).
     * This may have influence on the correct formatting of type designations.
     */

why is the flag not named like isCitation and how do you expect the portal to behave with respect to this flag?

isVerbatim was the label agreed with the users, I think semantics is very similar.

How shoul it look like: finally the users must decide. Maybe those listening to this ticket may give advise. Until then we may start with "text"

Actions #17

Updated by Andreas Müller about 3 years ago

  • Status changed from Feedback to New
  • Assignee changed from Andreas Müller to Andreas Kohlbecker
Actions #18

Updated by Andreas Kohlbecker about 3 years ago

[Feedback from Walter]

Hallo,

mit Bezug auf das Portal folgender Vorschlag meinerseits:
Wenn nach dem Ausgabetext die Quelle zitiert wird, dann sollte der Text in Anführungszeichen gesetzt werden, wenn isVerbatim gesetzt ist.

verbatim heißt wörtlich, das ist also eine Untermenge von Zitat (zitieren kann man auch in indirekter Form).
Die Quellreferenz impliziert indirekte Zitate.

Herzlichen Gruß
Walter

Actions #19

Updated by Andreas Kohlbecker about 3 years ago

  • Status changed from New to In Progress
Actions #20

Updated by Andreas Kohlbecker about 3 years ago

The textual type designation are now at least shown in the taxon synonymy and in the name page.

Open issues are:

  • show verbatim type information in
    • registration page
    • various specimen views
  • show sources and annotations (The cdm-dataportal|2d95e99f already contains some code for this but there are still problems to be solved)
  • Implement tests
Actions #21

Updated by Andreas Kohlbecker about 3 years ago

  • % Done changed from 0 to 20
Actions #22

Updated by Andreas Kohlbecker about 3 years ago

test data dumped and stored in _testdata/edit-int/testdb/5.10/cdm_integration_reference-2019-09-11-001.sql.bz2

Actions #23

Updated by Andreas Müller about 3 years ago

Andreas Kohlbecker wrote:

The textual type designation are now at least shown in the taxon synonymy and in the name page.

Open issues are:

  • show verbatim type information in
    • registration page
    • various specimen views
  • show sources and annotations (The cdm-dataportal|2d95e99f already contains some code for this but there are still problems to be solved)
  • Implement tests

How far can this be shown on specimen views? As it is purely textual there is no structured relationship to specimen.

Actions #24

Updated by Andreas Kohlbecker about 3 years ago

  • Target version changed from Release 5.10 to Release 5.11
Actions #25

Updated by Andreas Kohlbecker about 3 years ago

  • Target version changed from Release 5.11 to Release 5.12
Actions #26

Updated by Andreas Kohlbecker almost 3 years ago

  • Target version changed from Release 5.12 to Release 5.13
Actions #27

Updated by Andreas Kohlbecker over 2 years ago

  • Target version changed from Release 5.13 to Release 5.14
Actions #28

Updated by Andreas Kohlbecker over 2 years ago

  • Target version changed from Release 5.14 to Release 5.15
Actions #29

Updated by Andreas Kohlbecker over 2 years ago

Andreas Müller wrote:

Andreas Kohlbecker wrote:

The textual type designation are now at least shown in the taxon synonymy and in the name page.

Open issues are:

  • show verbatim type information in
    • registration page
    • various specimen views
  • show sources and annotations (The cdm-dataportal|2d95e99f already contains some code for this but there are still problems to be solved)
  • Implement tests

How far can this be shown on specimen views? As it is purely textual there is no structured relationship to specimen.

Your are right, the requirement to show textual type designations on specimen pages is nonsense.

So the open issues are:

Open issues are:

  • show verbatim type information registration page
  • show sources and annotations (The cdm-dataportal|2d95e99f already contains some code for this but there are still problems to be solved)
  • Implement tests
Actions #30

Updated by Andreas Kohlbecker over 2 years ago

  • % Done changed from 20 to 40

TextualTypeDesignation are not supposed to contain validly published type designations, therefore it makes no sense to implement their display for registration pages. There never should be a Registration for a name without published type designation.

Open issues are:

  • show sources and annotations (The cdm-dataportal|2d95e99f already contains some code for this but there are still problems to be solved)
  • Implement tests just implemented
Actions #31

Updated by Andreas Müller over 2 years ago

Andreas Kohlbecker wrote:

TextualTypeDesignation are not supposed to contain validly published type designations, therefore it makes no sense to implement their display for registration pages. There never should be a Registration for a name without published type designation.

I am not sure if this is true. There no reason why TextualTypeDesignations should not be used for validly published type designations. The only difference between textual and specimen based type designations is that the specimen is explicitly linked in the latter case while it is not in first case. There is even a discussion if TextualTypeDesingations should only be used for real type designations (but maybe some of them not valid).

Actions #32

Updated by Andreas Müller over 2 years ago

Actions #33

Updated by Andreas Kohlbecker over 2 years ago

  • Copied to bug #9087: typedesignation/{uuid}/annotations must return pager objects added
Actions #34

Updated by Andreas Kohlbecker over 2 years ago

  • % Done changed from 40 to 20

Andreas Müller wrote:

Andreas Kohlbecker wrote:

TextualTypeDesignation are not supposed to contain validly published type designations, therefore it makes no sense to implement their display for registration pages. There never should be a Registration for a name without published type designation.

I am not sure if this is true. There no reason why TextualTypeDesignations should not be used for validly published type designations. The only difference between textual and specimen based type designations is that the specimen is explicitly linked in the latter case while it is not in first case. There is even a discussion if TextualTypeDesingations should only be used for real type designations (but maybe some of them not valid).

You are right, the textual type information is also intended to be used for information that can not be atomized with current data model.

So there is one last bit to do here:

  • show textual type information in registration page
Actions #35

Updated by Andreas Kohlbecker over 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 20 to 50
Actions #36

Updated by Andreas Kohlbecker over 2 years ago

Actions #37

Updated by Andreas Kohlbecker over 2 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

Andreas Kohlbecker wrote:

So there is one last bit to do here:

  • show textual type information in registration page

this last task has been copied to #9117

Actions

Also available in: Atom PDF