feature request #8124
closedActivate Name Facts in Taxeditor
50%
Description
Namefacts should be shown for names in bulk editor. (see discussion in #7653)
Therefore following is needed:
- activate factual data view for name bulkeditor
- implement operation to create new NameDescription
implement correct use of nameFeature vocabulary for menu
activation like supplemental data activation when name is selected in details view
adapt factual data view label
adapt cache strategy to create a titleCache reflecting that it is a name fact
the topics above are implemented.
Files
Related issues
Updated by Katja Luther about 5 years ago
- Status changed from New to In Progress
Updated by Andreas Müller about 5 years ago
Can we also activate name facts in the same way as supplemental data are activated => if focus is explicitly on a name then name facts are shown in the facts view?
Updated by Andreas Müller about 5 years ago
- Related to feature request #8128: Add indicator for feature facts and/or vocabularies which description type they support added
Updated by Andreas Müller about 5 years ago
Also consider #8128 for future implementations.
Updated by Katja Luther about 5 years ago
for the name bulk editor the name facts are activated now.
still missing is the activation if name is selected in details view.
Updated by Katja Luther about 5 years ago
when activating the name facts for the name displayed in the details view, the details view is the selectionProviding part for the factual data view and the the factual data view is the selection providing part of the details view.
This leads to an endless loop in findSavablePart.
Updated by Katja Luther about 5 years ago
Katja Luther wrote:
when activating the name facts for the name displayed in the details view, the details view is the selectionProviding part for the factual data view and the the factual data view is the selection providing part of the details view.
This leads to an endless loop in findSavablePart.
this is fixed
Updated by Katja Luther about 5 years ago
- Status changed from In Progress to Resolved
- Assignee changed from Katja Luther to Andreas Müller
please review
Updated by Andreas Müller about 5 years ago
- Assignee changed from Andreas Müller to Patrick Plitzner
please do first review on nightly
Updated by Patrick Plitzner about 5 years ago
- File picture908-1.png picture908-1.png added
- Assignee changed from Patrick Plitzner to Andreas Müller
Tested on nightly:
- I selected a name in the bulk editor
- Creation of name description works
- The list of available features is filtered (see image). I don't know if this is correct, though.
- I created a description element and saved
- I opened the taxon belonging to this name, selected the name in the details view and it showes the description + the element
- I edited the element and saved again
- minor (refresh) issue: Going back to the bulk editor, the change of the description element did not show until I closed and re-opened the bulk editor
Updated by Andreas Müller about 5 years ago
- Assignee changed from Andreas Müller to Katja Luther
When entering via NameDetailsView and name selection the facts view still contains menu element "Move fact data set to other taxon". It should be disabled or should allow moving to another name, not taxon. This is the case for data sets and for single data records.
If selected via bulk editor it is either disabled or invisible (not sure why sometimes disabled and sometimes invisible, could not reproduce, but at least it is kind of correct).
Updated by Andreas Müller about 5 years ago
It would be nice to have a separate label to point out that we are working on name level, not taxon level now. E.g Name facts instead of Factual data or so.
Also the cache strategy for the description could be adapted to "Name facts for xxx" or "Factual data set for name xxxx".
Updated by Andreas Müller about 5 years ago
- Status changed from Resolved to Feedback
I wonder if we should explicitly remove "Protologue" from the feature list. Protologues will soon be handled differently in the source part of the name. To avoid users to create protologue data which is not according to our current standards filtering the feature might be helpful. We remove the filter later if users still wish to have it as freetext feature.
Updated by Andreas Müller about 5 years ago
In bulk editor there are 2 strange behaviors which are may be more bulk editor related then name facts related.
If I open 2 bulk editor searching for the same name, e.g. "Gattung art*" in rem_conf_am. Then I add additional name facts to the name in 1 one the bulk editors and save.
Switching to the other name bulk editor does not change the currently shown data in facts view, but only because name facts view seems not to be updated (but should! Maybe difficult because same object, but in other state because edited in 2 different sessions!).
Changing focus to some other object and back now shows the old data, which is expected because the other bulk editor was not yet refreshed.
Runnting the search again in the other bulk editor does still not change the data in facts view => this is unexpected because re-search is expected to completely reload all data.
If these issues are primarily bulk editor related we may open new tickets, but with high priority. By the way you can also reproduce if the editing is done not in a bulk editor by via selection of scientific name in details view.
Updated by Katja Luther about 5 years ago
Andreas Müller wrote:
In bulk editor there are 2 strange behaviors which are maybe more bulk editor related then name facts related.
If I open 2 bulk editor searching for the same name, e.g. "Gattung art*" in rem_conf_am. Then I add additional name facts to the name in 1 one the bulk editors and save.
Switching to the other name bulk editor does not change the currently shown data in facts view, but only because name facts view seems not to be updated (but should! Maybe difficult because same object, but in other state because edited in 2 different sessions!).
This is because it is the same object, I will have a look if it is easy to fix, otherwise I create a new ticket.
Changing focus to some other object and back now shows the old data, which is expected because the other bulk editor was not yet refreshed.
Runnting the search again in the other bulk editor does still not change the data in facts view => this is unexpected because re-search is expected to completely reload all data.
This seems to be a problem of the bulk editor, too.
If these issues are primarily bulk editor related we may open new tickets, but with high priority.
By the way you can also reproduce if the editing is done not in a bulk editor by via selection of scientific name in details view.
Updated by Katja Luther about 5 years ago
Katja Luther wrote:
Andreas Müller wrote:
In bulk editor there are 2 strange behaviors which are maybe more bulk editor related then name facts related.
If I open 2 bulk editor searching for the same name, e.g. "Gattung art*" in rem_conf_am. Then I add additional name facts to the name in 1 one the bulk editors and save.
Switching to the other name bulk editor does not change the currently shown data in facts view, but only because name facts view seems not to be updated (but should! Maybe difficult because same object, but in other state because edited in 2 different sessions!).
This is because it is the same object, I will have a look if it is easy to fix, otherwise I create a new ticket.
To avoid too many new rendering of the details view the actual and the previous selection are compared and when they are the same nothing is refreshed. -> #8228
Updated by Katja Luther about 5 years ago
Andreas Müller wrote:
It would be nice to have a separate label to point out that we are working on name level, not taxon level now. E.g Name facts instead of Factual data or so.
Also the cache strategy for the description could be adapted to "Name facts for xxx" or "Factual data set for name xxxx".
The label and the cacheStrategy for NameDescriptions are adapted.
Updated by Katja Luther about 5 years ago
- Description updated (diff)
- Status changed from Feedback to Resolved
- Assignee changed from Katja Luther to Andreas Müller
the issues mentioned above are fixed and for the bulk editor issue a new ticket is created. So I close this ticket.
Updated by Andreas Müller about 5 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
Can you please link the bulk editor tickets?
The switching between 2 bulk editors with same name seems to work now.
Updating the data via a new search in same bulk editor does not seem to work yet. Is there a ticket for this? Please either link to ticket or create new one (or fix if simple to fix).
Updated by Katja Luther about 5 years ago
- Status changed from Feedback to Closed
the ticket for the updating of bulkeditors is #8229, the rest is implemented and reviewed so I close this ticket.
Updated by Katja Luther about 5 years ago
- Related to bug #8229: reload of the bulkeditor does not work correctly added
Updated by Andreas Müller almost 5 years ago
- Related to deleted (bug #8229: reload of the bulkeditor does not work correctly)
Updated by Andreas Müller almost 5 years ago
- Copied to bug #8229: reload of the bulkeditor does not work correctly added