Project

General

Profile

task #8047

Remaining issues in TaxDistributionEditor

Added by Andreas Müller over 1 year ago. Updated 6 months ago.

Status:
Feedback
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
01/31/2019
Due date:
% Done:

60%

Severity:
normal

Description

Copied from #7854

  • Correct tooltips for "Add Source" and "Remove sources"
  • Disable "Add Source" or "Remove Source" depending on the current state of source selection
  • Use icon (delete icon) for "Remove Source" and move button down beside the label for the selected source
  • ... or alternatively to all the above use only 1 button which changes label and functionality depending on a source already being selected or not, either "add" or "remove"
  • Make the number of dropdown items (for status selection) configurable (see #7854#note-66)
  • Try to optimize the column width at start or after area selection. Details may be discussed. We have/had a similar discussion for the bulk editor in some other ticket. / der Verbreitungseditor erinnert sich auch nicht, wenn ich die Spaltenbreite verändert habe. Könnte man ihn dazu bringen, die Spaltenbreite automatisch an die Länge der Bezeichnungen in der Kopfzeile anzupassen? (see description in #7854 and #7854#note-20
  • In preferences translate possible configuration terms "ID in Vocabulary" => "ID im Vokabular"
  • Multiple cell selection in table is currently possible. As there is no function related to this we should remove this feature for now.
  • Think about synchronization strategies for name editor and distribution editor
  • Documentation e.g. how to use only with keystrokes (#7854#note-80)
  • implement comparator which is related to the tree structure in the navigator, so children of a taxon come first though they have a lower rank, but best ordering should be configurable (let the user choose from the 3 typical ordering + the ordering described here - which has again 2 versions, alphabetic or rank + alphabetic) #7854#note-87
  • warning before opening if number of opened taxa is large (e.g. >200), this may take time
  • handling of factual data view when switching between name editor and distribution editor #7854#note-85
  • If no area is selected add a message to the white space beside the table to choose an area first. Or, alternatively, automatically open the area selection dialog or open a dialog that asks you if you want to open the area selection because no area is selected yet
  • Check performance with large datasets (and related to this) #6159#note-9
  • Allow multi-select when opening the distribution editor to better define the taxon sets to work with (important for flat hierarchies) - #7860
    • if selected nodes have children ask whether they should be opened too or not
    • open selected taxon
  • Filtering for taxon names works only after leaving the cell, better would be after key stroke + delay
  • Filter: use same label as shown in the cells, currently it shows same value as in the dropbox of cells (also needs discussion if the cell label should also be shown (additionally) in the dropbox
  • Preferences: Group preferences for areas together and preferences for status together each with an according title
  • Show also taxon name in details view
  • Sort status in drop down alphabetically
  • possibility to configure the label in status drop down

Also interesting:

  • editing multiple status (currently multiple status are only displayed, is there a way to edit multiple status?)

picture589-1.png View (10.6 KB) Andreas Müller, 03/21/2020 12:20 PM


Related issues

Related to Edit - bug #6159: improve distribution editor in TaxEditor Closed 10/24/2016
Related to Edit - feature request #7860: [Master] Remaining E+M editor issues New 09/28/2018
Related to Edit - bug #8939: Exception when opening Distribution Editor because of missing Preference Closed 04/06/2020
Copied from Edit - task #7854: Open issues in TaxDistributionEditor Closed 10/23/2018
Copied to Edit - feature request #8889: Remaining issues for distribution editor - continue New 03/10/2020

Associated revisions

Revision 942a8769 (diff)
Added by Katja Luther over 1 year ago

ref #8047: show symbol and label in drop down of distribution editor

Revision 11847891 (diff)
Added by Katja Luther over 1 year ago

ref #8047: configurable display of status in drop down

Revision 9f2fa4a8 (diff)
Added by Katja Luther over 1 year ago

ref #8047: configurable display of status in drop down, new enum and predicate

Revision cb36db97 (diff)
Added by Katja Luther 7 months ago

ref #8047: move remove button to status bar

Revision a4469da8 (diff)
Added by Katja Luther 7 months ago

ref #8047: use icon for remove button

Revision ab40ab80 (diff)
Added by Katja Luther 7 months ago

ref #8047: handling of factual data view when switching between name editor and distribution editor

Revision 884aefac (diff)
Added by Katja Luther 7 months ago

ref #8047: allow multiselect for open distribution editor

Revision 466d5ea5 (diff)
Added by Katja Luther 7 months ago

ref #8047: allow multiselect for open distribution editor - continue

Revision a093f2b1 (diff)
Added by Katja Luther 7 months ago

ref #8047: improve handling of factual data view when switching views

Revision 53dde875 (diff)
Added by Katja Luther 7 months ago

ref #8047: open list of taxa in distribution editor

Revision 1c7218c8 (diff)
Added by Katja Luther 7 months ago

ref #8047: adapt menu item for multi select

Revision 68278258 (diff)
Added by Katja Luther 7 months ago

ref #8047: avoid NPE in filter

Revision 51270199 (diff)
Added by Katja Luther 7 months ago

ref #8047: show taxon name in details

Revision f47160a6 (diff)
Added by Katja Luther 7 months ago

ref #8047: show taxon name in details - continue

Revision c822b3aa (diff)
Added by Katja Luther 7 months ago

ref #8047: missing WorkbenchEventConstants changes

Revision 8cf9ef9f (diff)
Added by Katja Luther 7 months ago

ref #8047: add preference for number of visible status in drop down

Revision 1e4fc9a9 (diff)
Added by Katja Luther 7 months ago

ref #8047: add preference for number of visible status in drop down - check in cell editor

Revision 0017e5a7 (diff)
Added by Katja Luther 7 months ago

ref #8047: add preferencePredicate NUmberOfStatus

Revision ec05977a (diff)
Added by Katja Luther 7 months ago

ref #8047: add preferencePredicate for status order

Revision 0eccefea (diff)
Added by Katja Luther 7 months ago

ref #8047: status order in drop down

Revision 7ef1ca71 (diff)
Added by Katja Luther 7 months ago

ref #8047: status order in drop down - continue

Revision fe6bf49c (diff)
Added by Katja Luther 7 months ago

ref #8047: code cleaning

Revision f18e2af7 (diff)
Added by Katja Luther 7 months ago

ref #8047: fix handling of integer preference values

Revision 736d82ea (diff)
Added by Katja Luther 7 months ago

ref #8047: adapt column width to length of header label

Revision 7d915639 (diff)
Added by Katja Luther 6 months ago

ref #8047: fix number of status in drop down preference

Revision d23eff06 (diff)
Added by Katja Luther 6 months ago

ref #8047: fix number of status in drop down preference

Revision 0ac4c430 (diff)
Added by Katja Luther 6 months ago

ref #8047: switch button label depending of existing default source

Revision 0f76f092 (diff)
Added by Katja Luther 6 months ago

ref #8047: add l10n files

Revision 3afc2686 (diff)
Added by Katja Luther 6 months ago

ref #8047: fixing number of status issues

Revision fc0e5d0a (diff)
Added by Katja Luther 6 months ago

ref #8047: fixing number of status issues - layout

History

#1 Updated by Andreas Müller over 1 year ago

  • Copied from task #7854: Open issues in TaxDistributionEditor added

#2 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#3 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#4 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#5 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#6 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#7 Updated by Katja Luther over 1 year ago

  • Description updated (diff)

#8 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#9 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#10 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#11 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#12 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#13 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#14 Updated by Andreas Müller over 1 year ago

  • Related to bug #6159: improve distribution editor in TaxEditor added

#15 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#16 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#17 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#18 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#19 Updated by Katja Luther over 1 year ago

  • Priority changed from New to Highest
  • Target version changed from Release 5.6 to Release 5.7

#20 Updated by Andreas Müller over 1 year ago

#21 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#22 Updated by Katja Luther over 1 year ago

  • Target version changed from Release 5.7 to Release 5.8

#23 Updated by Katja Luther over 1 year ago

  • Description updated (diff)

#24 Updated by Katja Luther over 1 year ago

  • Description updated (diff)

#25 Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 5.8 to Release 5.10

#26 Updated by Katja Luther about 1 year ago

  • Target version changed from Release 5.10 to Release 5.11

#27 Updated by Andreas Müller 11 months ago

  • Target version changed from Release 5.11 to Release 5.12

#28 Updated by Katja Luther 9 months ago

  • Target version changed from Release 5.12 to Release 5.13

#29 Updated by Katja Luther 8 months ago

  • Description updated (diff)

#30 Updated by Katja Luther 8 months ago

  • Description updated (diff)

Disable "Add Source" or "Remove Source" depending on the current state of source selection
* Use icon (delete icon) for "Remove Source" and move button down beside the label for the selected source

  • ... or alternatively to all the above use only 1 button which changes label and functionality depending on a source already being selected or not, either "add" or "remove"

Now I implemented it in a way that the remove button is disabled if no source is selected, but the select source button is still enabled when a source is selected to have the possibility to change the selection.

#31 Updated by Katja Luther 8 months ago

  • Description updated (diff)

#32 Updated by Katja Luther 8 months ago

  • Description updated (diff)

#33 Updated by Katja Luther 8 months ago

  • Description updated (diff)

#34 Updated by Katja Luther 7 months ago

  • Description updated (diff)

#35 Updated by Katja Luther 7 months ago

  • Sort status in drop down alphabetically

I think a few weeks ago we decided to sort the status by the id in Vocabulary. I have to search for the ticket entry.

#36 Updated by Katja Luther 7 months ago

  • Description updated (diff)

#37 Updated by Andreas Müller 7 months ago

Katja Luther wrote:

  • Sort status in drop down alphabetically

I think a few weeks ago we decided to sort the status by the id in Vocabulary. I have to search for the ticket entry.

The sorting (if alphabetically) should always depend on the representation used. Which one to use is defined in the preferences. So we can't say it is always "by idInVoc" or always by "label".

#38 Updated by Katja Luther 7 months ago

  • Description updated (diff)

#39 Updated by Katja Luther 7 months ago

  • Description updated (diff)

#40 Updated by Katja Luther 7 months ago

  • Description updated (diff)

#41 Updated by Katja Luther 7 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

for the missing issues created a new ticket #8889 and close this ticket.
please review.

#42 Updated by Andreas Müller 7 months ago

#43 Updated by Andreas Müller 7 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

"Choose Source" does not change label if a source is already selected. It may change label to "Change source" (and back if source is deleted).

#44 Updated by Andreas Müller 7 months ago

Make the number of dropdown items (for status selection) configurable

The field in the preferences is not a pure integer field, but it also allows characters like "a". Generally it should allow only numbers or at least an error should be shown when trying to save a value like 'aaa20'
Also the field could be a bit wider to make sure all numbers are shown and not only hidden.

#45 Updated by Andreas Müller 7 months ago

  • % Done changed from 0 to 40

Also the width of the field differs in DB prefs and in local prefs. In DB prefs it is definetely to small as only 1 number is fully shown.

#46 Updated by Andreas Müller 7 months ago

... no it looks like the 2 influence each other. If I store a new value in DB prefs this value is also shown in local prefs but should not. So override does not work. Please check functionality and independency of both values.

#47 Updated by Andreas Müller 7 months ago

Allow multi-select when opening the distribution editor to better define the taxon sets to work with (important for flat hierarchies)
if selected nodes have children ask whether they should be opened too or not

The later issue seems not to be implemented yet. If I select Arenaria serpyllifolia the children are automatically opened without asking if this should happen.

#48 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

Allow multi-select when opening the distribution editor to better define the taxon sets to work with (important for flat hierarchies)
if selected nodes have children ask whether they should be opened too or not

The later issue seems not to be implemented yet. If I select Arenaria serpyllifolia the children are automatically opened without asking if this should happen.

this is part of the follow up ticket.

#49 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

... no it looks like the 2 influence each other. If I store a new value in DB prefs this value is also shown in local prefs but should not. So override does not work. Please check functionality and independency of both values.

This is only the case if the local value was not set before so the default value is shown and this is the db value.

But the field was not disabled if allowOverride was false, this is fixed.

#50 Updated by Katja Luther 6 months ago

Katja Luther wrote:

Andreas Müller wrote:

... no it looks like the 2 influence each other. If I store a new value in DB prefs this value is also shown in local prefs but should not. So override does not work. Please check functionality and independency of both values.

This is only the case if the local value was not set before so the default value is shown and this is the db value.

But the field was not disabled if allowOverride was false, this is fixed.

Now also the exception label is shown correctly when something else then a number is entered.

#51 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

"Choose Source" does not change label if a source is already selected. It may change label to "Change source" (and back if source is deleted).

this is implemented now.

#52 Updated by Katja Luther 6 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review the issues, mentioned above

#53 Updated by Andreas Müller 6 months ago

  • Assignee changed from Andreas Müller to Katja Luther

The number field in the preferences is still not wide enough

#54 Updated by Andreas Müller 6 months ago

Katja Luther wrote:

Katja Luther wrote:

Andreas Müller wrote:

... no it looks like the 2 influence each other. If I store a new value in DB prefs this value is also shown in local prefs but should not. So override does not work. Please check functionality and independency of both values.

This is only the case if the local value was not set before so the default value is shown and this is the db value.

But the field was not disabled if allowOverride was false, this is fixed.

Now also the exception label is shown correctly when something else then a number is entered.

This is already better as it shows that there is an error. But some open issues:

  • The label should be red as for other such error messages (e.g. URLs)
  • The label should say "... positive integer" instead of "... number"
  • negative numbers are still allowed but shouldn't
  • if an incorrect "number" is entered, e.g. 1,3 saving is still possible but instead 13 is persisted which is not correct; saving should not be possible if an error exist

In general I think it is a better solution for number fields to not allow entering anything else than numbers while entering data. So if someone tries to enter a letter or anything else it should simply not be shown (not be entered). This is quite easy for positive integer fields and a bit more complicated for decimal numbers or negative numbers. Isn't it possible to define a regex or something similar for such text fields or are there predefined textfields for such cases? Entering pos. is a very basic issue so others may also have the same problem (and solutions).
Note: for dates we have a limited number of characters that can be entered maybe this shows how to solve such issues (but unfortunately also there it is still possible to enter something else then numbers, so this should also be fixed if possible).
Of course this may be moved to a new ticket if it is not easy to fix.

#55 Updated by Andreas Müller 6 months ago

Andreas Müller wrote:

The number field in the preferences is still not wide enough

The problem is it changes the size according to the previous value. This does not make sense or should be implemented in a way that entering data is also possible if you want to more digits. But here we can simply use a fixed width as we do not expect more than 2 digits. So with a width showing a max of 3 digits we are always on the save side.

#56 Updated by Andreas Müller 6 months ago

It is not possible to define "use default" for the number of dropdown items, neither for DB prefs nor for local prefs.

#57 Updated by Andreas Müller 6 months ago

Try to optimize the column width at start or after area selection. Details may be discussed. We have/had a similar discussion for the bulk editor in some other ticket. / der Verbreitungseditor erinnert sich auch nicht, wenn ich die Spaltenbreite verändert habe. Könnte man ihn dazu bringen, die Spaltenbreite automatisch an die Länge der Bezeichnungen in der Kopfzeile anzupassen?

To me it looks like this is not yet implemented though it is crossed out and also not moved to the follow up ticket.
If it is implemented can you please explain what the current expected behavior is if you open the distribution editor or if you selected a new set of areas

#58 Updated by Andreas Müller 6 months ago

  • Status changed from Resolved to Feedback

Currently it is not possible to enter the status in the details view (the field is disabled). I do not fully remember if this was always the case. In general there is no reason for disabling this field (other then the area and taxon name field which should be fixed as they are fixed in the table itself.
If this is a regression or if there is no technical reason for disabling we should enable the field, otherwise we can leave it as it is as it not an urgent issue.

#59 Updated by Andreas Müller 6 months ago

Sort status in drop down alphabetically

This mostly seems to be fixed but I found 1 case in rem_conf_am where it was not correct:

#60 Updated by Andreas Müller 6 months ago

Andreas Müller wrote:

Sort status in drop down alphabetically

This mostly seems to be fixed but I found 1 case in rem_conf_am where it was not correct:

Sorry I did not see that the ordering is configurable now. So this issue is solved (only we could discuss what the default should be - idInVoc or label, but this is of minor importance)

#61 Updated by Andreas Müller 6 months ago

Andreas Müller wrote:

Andreas Müller wrote:

Sort status in drop down alphabetically

This mostly seems to be fixed but I found 1 case in rem_conf_am where it was not correct:

Sorry I did not see that the ordering is configurable now. So this issue is solved (only we could discuss what the default should be - idInVoc or label, but this is of minor importance)

hmm, probably the best default (and also still missing alternative) is to always sort according to the label shown in the dropdown. It does not make sense to order alphabetically by something which is not shown (so ordering by idInVoc does not make sense if the term.label or term.symbol or something else is shown in the dropdown). Is it possible to implement it this way? (we may move this to the follow up ticket)

#62 Updated by Andreas Müller 6 months ago

  • % Done changed from 40 to 60

This ticket is now fully reviewed. Only the issues I mentioned are still open (as far as I can see).

#63 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

Currently it is not possible to enter the status in the details view (the field is disabled). I do not fully remember if this was always the case. In general there is no reason for disabling this field (other then the area and taxon name field which should be fixed as they are fixed in the table itself.
If this is a regression or if there is no technical reason for disabling we should enable the field, otherwise we can leave it as it is as it not an urgent issue.

this was never possible. the distribution part of the details view was completely disabled.

#64 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

Try to optimize the column width at start or after area selection. Details may be discussed. We have/had a similar discussion for the bulk editor in some other ticket. / der Verbreitungseditor erinnert sich auch nicht, wenn ich die Spaltenbreite verändert habe. Könnte man ihn dazu bringen, die Spaltenbreite automatisch an die Länge der Bezeichnungen in der Kopfzeile anzupassen?

To me it looks like this is not yet implemented though it is crossed out and also not moved to the follow up ticket.
If it is implemented can you please explain what the current expected behavior is if you open the distribution editor or if you selected a new set of areas

Remembering the size is still missing, but adapting the width of the solumns should work.

#65 Updated by Katja Luther 6 months ago

Andreas Müller wrote:

Andreas Müller wrote:

The number field in the preferences is still not wide enough

The problem is it changes the size according to the previous value. This does not make sense or should be implemented in a way that entering data is also possible if you want to more digits. But here we can simply use a fixed width as we do not expect more than 2 digits. So with a width showing a max of 3 digits we are always on the save side.

this should be fixed.

#66 Updated by Andreas Müller 6 months ago

  • Related to bug #8939: Exception when opening Distribution Editor because of missing Preference added

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)