Project

General

Profile

Actions

feature request #8045

open

Improve handling of default values and override in local preferences

Added by Katja Luther about 5 years ago. Updated over 2 years ago.

Status:
Feedback
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

50%

Estimated time:
Severity:
normal
Tags:

Description

For selection of default, dbPreference or explicit local value the local preference pages should have combo boxes.

Depending on its selection the local preference should be handled:

  • default: save the default value
  • db preference: delete the value in local preferences if exist
  • explicit value: save to preference file

Also check restore behavior (see #7849#note-80


Related issues

Related to EDIT - bug #7856: Allow local override for distribution vocabulariesClosedKatja Luther

Actions
Related to EDIT - bug #7849: Improve DB Preferences handling and saving in TaxEditorClosedKatja Luther

Actions
Related to EDIT - feature request #8092: set default for term and vocabulary selection preferences in selection wizardClosedKatja Luther

Actions
Related to EDIT - feature request #8309: Implement preferences with predicate and subject in local preferencesNewKatja Luther

Actions
Related to EDIT - feature request #8062: Make default preferences deletable serversideClosedAndreas Müller

Actions
Related to EDIT - task #9826: Move pure TaxEditor predicates back to taxeditor codeNewKatja Luther

Actions
Actions #1

Updated by Andreas Müller about 5 years ago

I don't know if we really need "db preference" as explicit value. It makes it more difficult to understand and there is almost no added value (compared to "default". So we only need "default" and the list of explicit values. If "default" is chosen then the preference is deleted from the local preferences.

Actions #2

Updated by Katja Luther about 5 years ago

I would show the value of the db preference in the drop down, but with ("global") or ("db") behind

Actions #3

Updated by Andreas Müller about 5 years ago

Katja Luther wrote:

I would show the value of the db preference in the drop down, but with ("global") or ("db") behind

OK, if this is not an explicit entry but if it is only added to the anyway existing entry for this value. Maybe "recommended" is another possible label. A bit long but standard for many such cases.

Actions #4

Updated by Katja Luther about 5 years ago

  • Related to bug #7856: Allow local override for distribution vocabularies added
Actions #5

Updated by Andreas Müller about 5 years ago

  • Related to bug #7849: Improve DB Preferences handling and saving in TaxEditor added
Actions #6

Updated by Andreas Müller about 5 years ago

  • Subject changed from local preferences pages with drop down to Improve handling of default values and override in local preferences
Actions #7

Updated by Andreas Müller about 5 years ago

  • Target version changed from Release 5.6 to Reviewed Next Major Release
Actions #8

Updated by Andreas Müller almost 5 years ago

  • Status changed from New to Feedback
  • Target version changed from Reviewed Next Major Release to Release 5.8

Looks like this has been implemented in 5.8 so I switch milestone.
Are there open issues?

Actions #9

Updated by Andreas Müller almost 5 years ago

  • % Done changed from 0 to 50

Choosing "default" for local preference "nomenclatural status" has no effect. It uses the explicitly chosen values from the list above. Anyway, if "default" is chosen the list should select only those status which are available according to the default/dbPrefs. Also the list should be disabled I guess.

Actions #10

Updated by Andreas Müller almost 5 years ago

For nomencl.Code. implementation is still missing or incorrect. Also we may discuss if in DB prefs we should allow "Use default" which is currently not available but by default nom.code is set to ICNAFP

Actions #11

Updated by Andreas Müller almost 5 years ago

  • Related to feature request #8092: set default for term and vocabulary selection preferences in selection wizard added
Actions #12

Updated by Andreas Müller almost 5 years ago

  • Description updated (diff)
Actions #13

Updated by Andreas Müller almost 5 years ago

Andreas Müller wrote:

Choosing "default" for local preference "nomenclatural status" has no effect. It uses the explicitly chosen values from the list above. Anyway, if "default" is chosen the list should select only those status which are available according to the default/dbPrefs. Also the list should be disabled I guess.

For ranks it is the opposite.

Actions #14

Updated by Andreas Müller almost 5 years ago

  • Description updated (diff)
Actions #15

Updated by Andreas Müller almost 5 years ago

  • Description updated (diff)
Actions #16

Updated by Andreas Müller almost 5 years ago

For the above issues see also #8323#note-4

Actions #17

Updated by Andreas Müller almost 5 years ago

with the new implementation of distribution status with different subjects if allowOverride=false in DB prefs this does not disable the local pref button for this pref. I did not check if the local pref is used in this case.

We need to guarantee that even for disallowOverride the local pref is always disabled. This must be the case even if the DB pref subject is defined more generic. Only if a specific subject allows override while a more generic disallows especially for this subject local prefs should be available.
Anyway, the area specific distribution status still needs to be implemented for local prefs. Currently it only exists for DB prefs.

See also #7920#note-19

Actions #18

Updated by Andreas Müller over 4 years ago

  • Related to feature request #8309: Implement preferences with predicate and subject in local preferences added
Actions #19

Updated by Andreas Müller over 2 years ago

Actions #20

Updated by Andreas Müller over 2 years ago

  • Description updated (diff)
Actions #21

Updated by Andreas Müller over 2 years ago

  • Related to task #9826: Move pure TaxEditor predicates back to taxeditor code added
Actions #22

Updated by Andreas Müller over 2 years ago

  • Tags set to preferences
Actions

Also available in: Atom PDF