EDIT

Closing this ticket because it is implemented but still experimental.

As the term editor is not experimental this feature is also not experimental. Therefore it should be tested for correctness.

I would name it move feature as child or something like this because in the wizard you can choose the parent. Maybe you also should add some more description to the wizard.

Moving to 5.7 where it can be reviewed when set to non-experimental

Move to next milestone because this is still considered experimental

This is not not experimental anymore.

Known issues when reviewing:

• It is still possible to select multiple terms in the term search dialog but a warning will appear if you select more than one term.
• The focus is not directly set on the search button. So pressing "Enter" will press OK which does not do anything when nothing is selected
• it is not possible to select vocabularies with the term search

Created a ticket for remaining issues -> #8763

• For this usecase the title and the description in the term selection wizard needs to be adapted. It should be something like "Choose parent term".

• Also the vocabularies should be choosable from to move a term to another vocabulary as top level term (maybe we can take the state if exactly 1 vocabulary is selected but no term is selected).

• The term itself should not show up in the list

• Multi-select should not be possbile immediately when selecting the terms (currently a warning comes after "Finish" that this is not possible)

this is fixed now, please review

Applied in changeset taxeditor|bac71f46b6eb8bf94a76efbb9217525700259da2.

Vocabulary search is an exact search now while term search is a "contains"-search. The later is what is more expected for the general term search. Also *-Search does not work vor vocabularies.

I discovered a dangerous behavior of the "Choose Parent" dialog:

When the focus is set to the filter text field one would expect that hitting ENTER would trigger the search to be executed.
But instead the Enter-Key seems to be bound only to the "Finish" button so that the move operation can be triggered unintentionally.

(BTW, a button should be highlighted if it is the active button, that is when the pressing the ENTER key will trigger its action.)

I suggest to change the dialog behavior so that only the search is triggered when hitting enter.
The action of the finish button should never be executed this way.

In windows the finish button is highlighted after selecting the parent and when no parent is selected disabled.

I think this is the normal behaviour? But why this is not the case in linux, I have to do some research.

Applied in changeset taxeditor|29f07c5dca339559d9bc5e7efd351ec4fa5f3869.

Excellently solved!

I could not find further problems or glitches which are not yet handled in other tickets.