Project

General

Profile

Actions

feature request #8030

closed

Cache updater service methods externalized and base class specific

Added by Andreas Kohlbecker about 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Highest
Category:
cdm
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

copied from #7874

Generally at the moment I do not fully understand how far we need the lines after line 439. The call

entitiesToUpdate.add(entity);

is not really required I think as the entities all belong to the session already. If not, are the .getTitleCache or .getAbbrevTitleCace calls important here? Or can we completely delete this part. If not I wonder why the calls are alternative, e.g. if olcTitleCache <> newTitleCache the entity instanceof Team part is not called anymore. Is this on purpose?

Also the whole method is only called if entity.isProtectedTitleCache() == false which might be unwanted e.g. for Teams. If the titleCache is protected but nomenclaturalTitleCache is not protected we may still want to update it.

Generally we need to refactor this part and move away the specific class handling from IdentifiableServiceBase (e.g. we could move the update routines to the model classes as the knowledge about the model classes is best here)


Related issues

Related to EDIT - feature request #8096: Implement CacheUpdater as long running task with correct progress monitoringClosedKatja Luther

Actions
Copied from EDIT - bug #7874: TeamOrPersonBase entity can become unusable due to replacement of the title caches on using gettersClosedAndreas Müller

Actions
Actions #1

Updated by Andreas Kohlbecker about 4 years ago

  • Copied from bug #7874: TeamOrPersonBase entity can become unusable due to replacement of the title caches on using getters added
Actions #2

Updated by Andreas Müller about 4 years ago

  • Description updated (diff)
Actions #3

Updated by Andreas Müller almost 4 years ago

  • Status changed from New to In Progress
  • Priority changed from New to Highest
  • Target version changed from Unassigned CDM tickets to Release 5.5
  • % Done changed from 0 to 30
Actions #4

Updated by Andreas Müller almost 4 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

I think this is fixed now. Please review.

Actions #5

Updated by Andreas Müller almost 4 years ago

  • Related to feature request #8096: Implement CacheUpdater as long running task with correct progress monitoring added
Actions #6

Updated by Andreas Kohlbecker almost 4 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 30 to 100

review completed, no issues found

Actions

Also available in: Atom PDF