Project

General

Profile

feature request #8030

Cache updater service methods externalized and base class specific

Added by Andreas Kohlbecker 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Highest
Category:
cdm
Target version:
Start date:
01/29/2019
Due date:
% Done:

100%

Severity:
normal

Description

copied from #7874

Generally at the moment I do not fully understand how far we need the lines after line 439. The call

entitiesToUpdate.add(entity);

is not really required I think as the entities all belong to the session already. If not, are the .getTitleCache or .getAbbrevTitleCace calls important here? Or can we completely delete this part. If not I wonder why the calls are alternative, e.g. if olcTitleCache <> newTitleCache the entity instanceof Team part is not called anymore. Is this on purpose?

Also the whole method is only called if entity.isProtectedTitleCache() == false which might be unwanted e.g. for Teams. If the titleCache is protected but nomenclaturalTitleCache is not protected we may still want to update it.

Generally we need to refactor this part and move away the specific class handling from IdentifiableServiceBase (e.g. we could move the update routines to the model classes as the knowledge about the model classes is best here)


Related issues

Related to Edit - feature request #8096: Implement CacheUpdater as long running task with correct progress monitoring Closed 02/13/2019
Copied from Edit - bug #7874: TeamOrPersonBase entity can become unusable due to replacement of the title caches on using getters Closed 10/26/2018

Associated revisions

Revision 5d2a77b2 (diff)
Added by Andreas Müller 5 months ago

ref #8030 Move cache updating to model classes, no tests yet

Revision bfa30d38 (diff)
Added by Andreas Müller 5 months ago

ref #8030 add tests for nameService (not yet finished) and fixing updateCache handling in TaxonName

Revision e11d18c9 (diff)
Added by Andreas Müller 5 months ago

ref #8030 further tests

Revision 57d5b579 (diff)
Added by Andreas Müller 5 months ago

ref #8030 rename updateTitleCache to updateCaches

Revision 784fe709 (diff)
Added by Andreas Müller 5 months ago

ref #8030 rename updateTitleCacheImpl to updateCachesImpl

History

#1 Updated by Andreas Kohlbecker 6 months ago

  • Copied from bug #7874: TeamOrPersonBase entity can become unusable due to replacement of the title caches on using getters added

#2 Updated by Andreas Müller 6 months ago

  • Description updated (diff)

#3 Updated by Andreas Müller 5 months ago

  • Status changed from New to In Progress
  • Priority changed from New to Highest
  • Target version changed from Unassigned CDM tickets to Release 5.5
  • % Done changed from 0 to 30

#4 Updated by Andreas Müller 5 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

I think this is fixed now. Please review.

#5 Updated by Andreas Müller 5 months ago

  • Related to feature request #8096: Implement CacheUpdater as long running task with correct progress monitoring added

#6 Updated by Andreas Kohlbecker 5 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Kohlbecker to Andreas Müller
  • % Done changed from 30 to 100

review completed, no issues found

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)