https://dev.e-taxonomy.eu/redmine/https://dev.e-taxonomy.eu/redmine/redmine/favicon.ico?14691914852019-01-15T13:28:09ZEDIT Project ManagementEDIT - bug #7995: Registration.registrationDate not set when status is set PUBLISHEDhttps://dev.e-taxonomy.eu/redmine/issues/7995?journal_id=428582019-01-15T13:28:09ZAndreas Kohlbecker
<ul><li><strong>Related to</strong> <i><a class="issue tracker-5 status-6 priority-10 priority-lowest closed" href="/redmine/issues/6655">feature request #6655</a>: Implement a RegistrationManager with state machine</i> added</li></ul> EDIT - bug #7995: Registration.registrationDate not set when status is set PUBLISHEDhttps://dev.e-taxonomy.eu/redmine/issues/7995?journal_id=428592019-01-15T13:39:30ZAndreas Kohlbecker
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>50</i></li></ul><p>Applied in changeset <a class="changeset" title="fix #7995 set and unset registrationDate when registration status changes" href="https://dev.e-taxonomy.eu/redmine/projects/edit/repository/cdmlib/revisions/f33a82a7e547ddcd3b084d7a6c53b3920f6db5fc">cdmlib|f33a82a7e547ddcd3b084d7a6c53b3920f6db5fc</a>.</p>
EDIT - bug #7995: Registration.registrationDate not set when status is set PUBLISHEDhttps://dev.e-taxonomy.eu/redmine/issues/7995?journal_id=428612019-01-15T16:10:15ZAndreas Müller
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Andreas Kohlbecker</i></li></ul><p>This is dangerous behaviour. For phycobank it might be correct as we edit the data within the database. However, for handling external registrations it is not correct. For the later usecase the user/developer must know that setting the date should be done after setting the state which is hidden knowledge only available in Javadoc or so which is dangerous. Also when accidentally changing the state and change it back to PUBLISHED the date is changed without realizing by the user maybe.</p>
<p>So I strongly recommend to implement this on application side if it is a wanted feature for phycobank but remove it from cdmlib-model. We could add a method in service layer if you want to encapsulate it within one operation. This method should have an according name, e.g. setStatusAndDate</p>
EDIT - bug #7995: Registration.registrationDate not set when status is set PUBLISHEDhttps://dev.e-taxonomy.eu/redmine/issues/7995?journal_id=428622019-01-15T16:33:27ZAndreas Kohlbecker
<ul></ul><blockquote>
<p>So I strongly recommend to implement this on application side</p>
</blockquote>
<p>So this means implementing it in <code>cdm-vaadin</code> and in the registration controller methods (<code>cdmlib-remote</code>) which allow state changes. Especially in the remote layer it is crucial for the digital workflow that the <code>registrationDate</code> is always set to <em>now</em> when status is set PUBLISHED.</p>
EDIT - bug #7995: Registration.registrationDate not set when status is set PUBLISHEDhttps://dev.e-taxonomy.eu/redmine/issues/7995?journal_id=428632019-01-15T16:54:49ZAndreas Müller
<ul></ul><p>Andreas Kohlbecker wrote:</p>
<blockquote>
<blockquote>
<p>So I strongly recommend to implement this on application side</p>
</blockquote>
<p>So this means implementing it in <code>cdm-vaadin</code> and in the registration controller methods (<code>cdmlib-remote</code>) which allow state changes. Especially in the remote layer it is crucial for the digital workflow that the <code>registrationDate</code> is always set to <em>now</em> when status is set PUBLISHED.</p>
</blockquote>
<p>sounds reasonable</p>
EDIT - bug #7995: Registration.registrationDate not set when status is set PUBLISHEDhttps://dev.e-taxonomy.eu/redmine/issues/7995?journal_id=428642019-01-16T07:19:33ZAndreas Kohlbecker
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>There is now a <code>updateStatusAndDate(RegistrationStatus status)</code> method in Registration which can be used if needed. The algorithm is centralized that way.</p>
EDIT - bug #7995: Registration.registrationDate not set when status is set PUBLISHEDhttps://dev.e-taxonomy.eu/redmine/issues/7995?journal_id=432692019-01-29T15:16:53ZAndreas Kohlbecker
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>100</i></li></ul><p>works now also in the RegistrationPopupEditor</p>
EDIT - bug #7995: Registration.registrationDate not set when status is set PUBLISHEDhttps://dev.e-taxonomy.eu/redmine/issues/7995?journal_id=440072019-02-14T12:07:41ZAndreas Müller
<ul><li><strong>Category</strong> changed from <i>cdmlib</i> to <i>cdm-vaadin</i></li></ul>