Project

General

Profile

bug #7944

TaxonNamePopEditor: name part fields are required

Added by Andreas Kohlbecker 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Highest
Category:
cdm-vaadin
Target version:
Start date:
12/10/2018
Due date:
% Done:

100%

Severity:
normal
Found in Version:
Tags:

Description

Depending on the chosen rank, the name part fields 'Uninomial', 'Specific epithet', ... should be set required in order to avoid saving in complete data.


Related issues

Related to Edit - bug #7945: TaxonNamePopupEditor: missing genus causes exception when updating name parts visibility Rejected 12/10/2018
Copied to Edit - bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks Feedback 12/10/2018

Associated revisions

Revision 8647ca02 (diff)
Added by Andreas Kohlbecker 3 months ago

fix #7944 TaxonNamePopEditor: name part fields are required

History

#1 Updated by Andreas Kohlbecker 3 months ago

  • Related to bug #7945: TaxonNamePopupEditor: missing genus causes exception when updating name parts visibility added

#2 Updated by Andreas Kohlbecker 3 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#3 Updated by Andreas Kohlbecker 3 months ago

  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber

ready for review

#4 Updated by Wolf-Henning Kusber 3 months ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 80

Review:
I agree, that this is needed for data integrity, but I think this will slow down data entry by users and curation.

In most cases the implementation is as expected, except the following ranks:

I checked the complete list. With some ranks (mostly not relevant for PhycoBank, I have problems).

"species aggegate" should also have an additional uninominal (to link it to a given genus).

"species group" should also have an additional uninominal (to link it to a given genus).

"candidate" is not relevant to PhycoBank, but I would expect that 99-100% of candidates in bacteriology will be a species -> delete "infraspecific epithet" there.

"unknown rank": I would suggest to offer just a "uninominal" because if there are genus and one epithet it should be a species, if it is unknown infraspecific, we have an own entry.

#5 Updated by Andreas Kohlbecker 3 months ago

  • Copied to bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks added

#6 Updated by Andreas Kohlbecker about 2 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 80 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)