bug #7944
closedTaxonNamePopEditor: name part fields are required
100%
Description
Depending on the chosen rank, the name part fields 'Uninomial', 'Specific epithet', ... should be set required in order to avoid saving in complete data.
Related issues
Updated by Andreas Kohlbecker about 4 years ago
- Related to bug #7945: TaxonNamePopupEditor: missing genus causes exception when updating name parts visibility added
Updated by Andreas Kohlbecker about 4 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 50
Applied in changeset cdm-vaadin|8647ca02a990685e381409ca7b127b438766eeae.
Updated by Andreas Kohlbecker about 4 years ago
- Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber
ready for review
Updated by Wolf-Henning Kusber about 4 years ago
- Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
- % Done changed from 50 to 80
Review:
I agree, that this is needed for data integrity, but I think this will slow down data entry by users and curation.
In most cases the implementation is as expected, except the following ranks:
I checked the complete list. With some ranks (mostly not relevant for PhycoBank, I have problems).
"species aggegate" should also have an additional uninominal (to link it to a given genus).
"species group" should also have an additional uninominal (to link it to a given genus).
"candidate" is not relevant to PhycoBank, but I would expect that 99-100% of candidates in bacteriology will be a species -> delete "infraspecific epithet" there.
"unknown rank": I would suggest to offer just a "uninominal" because if there are genus and one epithet it should be a species, if it is unknown infraspecific, we have an own entry.
Updated by Andreas Kohlbecker about 4 years ago
- Copied to bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks added
Updated by Andreas Kohlbecker about 4 years ago
- Status changed from Resolved to Closed
- % Done changed from 80 to 100