Project

General

Profile

Actions

feature request #7942

closed

SpecimenTypeDesignationEditor: Explanation on why editor can not be saved without type designation

Added by Andreas Kohlbecker about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
New
Category:
cdm-vaadin
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:

Description

Das Speichern eines TypedesignationWorkingsets geht erst wenn mind. ein Type angelegt ist.
Andernfalls würde die SpecimenInformation verloren gehen, da sie nicht mit der Registrierung verküpft werden könnte.

Actions #1

Updated by Andreas Kohlbecker about 4 years ago

  • Status changed from New to Feedback
  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber

We have two options:

  1. Show a message in the footer of the editor as long as the save button is blocked: "Editor can not be saved without a type designation"
  2. Enable the "Save" button always and make the fields "Type status", "Kind of unit", "Collection", "Accession number" of the first row required.

I prefer the second solution.

What do you think, Henning?

Actions #2

Updated by Wolf-Henning Kusber about 4 years ago

Den zweiten Text verstehe ich sprachlich nicht.

proposed wording: "Typedesignation editor can not be saved without filling in at least the mandatory fields"

Actions #3

Updated by Wolf-Henning Kusber about 4 years ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
Actions #4

Updated by Andreas Kohlbecker about 4 years ago

  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber

We agreed on using the required flag of the "Type status", "Kind of unit" field ("Collection", "Accession number" must not be required) and showing the text suggested by Henning.

"Type status", "Kind of unit" are already set to required but the flag is not evaluated yet.

Actions #5

Updated by Andreas Kohlbecker about 4 years ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
Actions #6

Updated by Andreas Kohlbecker about 4 years ago

  • Status changed from Feedback to In Progress
Actions #7

Updated by Andreas Kohlbecker about 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 50
Actions #8

Updated by Andreas Kohlbecker about 4 years ago

  • Assignee changed from Andreas Kohlbecker to Wolf-Henning Kusber

implemented as discussed, ready for reviewing as soon as the test-server has been rebuild.

Actions #9

Updated by Wolf-Henning Kusber about 4 years ago

  • Assignee changed from Wolf-Henning Kusber to Andreas Kohlbecker
  • % Done changed from 50 to 100

Two warnings if required fields Kindof Unit & Type Status are not filled when saving.

Unspecific Vaadin popup: "The entered data in 1 field is incomplete or invalid"
Comment: this warning is acceptable because the more specific mouse over is implemented (see below)

Specific warning:
!Types
Mouse over: "Can't save as long as type designations are missing"

This is fine with me.

The ticket may be closed.

Comment:
For the second (third etc.) type invalid data (missing mandatory fields) can be entered but not be stored, this is okay.

Actions #10

Updated by Andreas Kohlbecker about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF