Project

General

Profile

feature request #7912

Enhance checkbox tree viewer

Added by Patrick Plitzner 11 months ago. Updated 8 months ago.

Status:
Closed
Priority:
New
Category:
taxeditor
Target version:
Start date:
11/19/2018
Due date:
% Done:

100%

Severity:
normal

Description

Implement buttons:

  • to (de-)select all children
  • select all children recursively or only direct children

Visualize selection state:

  • Text of tree node
    • italic when some children are selected
    • bold when all children are selected
    • default otherwise
  • Checkboxes
    • checked when item is selected
    • grayed when item is not selected but some or all children are selected

picture672-1.png View (6.85 KB) Andreas Müller, 01/27/2019 09:16 AM

picture900-1.png View (3.06 KB) Andreas Müller, 02/01/2019 12:22 PM


Related issues

Related to Edit - feature request #7063: Improve the area selection wizard for distribution editor Closed 11/07/2017
Copied to Edit - feature request #8054: Remaing issues - CheckBoxTreeComposite New 02/01/2019

Associated revisions

Revision 05d18da0 (diff)
Added by Patrick Plitzner 11 months ago

ref #7912 Add toolbar to checkbox viewer + visualize selection state

Revision 9ab27a32 (diff)
Added by Patrick Plitzner 11 months ago

ref #7912 Fix selection states in checkbox viewer

Revision bfe8226d (diff)
Added by Patrick Plitzner 11 months ago

ref #7912 Centralize layout

Revision 1d035f5d (diff)
Added by Patrick Plitzner 9 months ago

ref #7912 Fix font evaluation in checkbox tree composite

Revision 2204e24e (diff)
Added by Patrick Plitzner 9 months ago

ref #7912 Add "Select direct children" button

Revision d52bc40e (diff)
Added by Patrick Plitzner 9 months ago

ref #7912 Add flag to allow selection of top level nodes

  • default is false
  • currently only allowed in area vocabulary selection in distribution editor preferences

History

#1 Updated by Patrick Plitzner 11 months ago

  • Status changed from New to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 0 to 50

#2 Updated by Patrick Plitzner 11 months ago

  • Assignee changed from Andreas Müller to Katja Luther

#3 Updated by Katja Luther 10 months ago

  • Status changed from Resolved to Feedback

this seems to work, but the checkboxes are not grayed when a child or some children are selected.

#4 Updated by Katja Luther 10 months ago

  • Assignee changed from Katja Luther to Patrick Plitzner

#5 Updated by Patrick Plitzner 9 months ago

  • Assignee changed from Patrick Plitzner to Katja Luther

Katja Luther wrote:

this seems to work, but the checkboxes are not grayed when a child or some children are selected.

Setting the checkboxes to gray seems to be platform dependant. On the Lubuntu linux distribution, for example, this state cannot be shown. Therefore the font is changed according to the selection state. bold if all children are selected, italic if some children are selected and standard if nothing is selected.

Can you please test in some cases if this works for you especially when re-opening a dialog with saved areas? If the grayed state is not that important we may close this ticket.

#6 Updated by Andreas Müller 9 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

To remind me to review.

#7 Updated by Andreas Müller 9 months ago

  • File picture672-1.png View added
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

It works already very good. 2 minor issues:

  1. The state check should always include all children AND recursive children. E.g. here

MyAreas should have state "some" not "all" as Area1 is not selected (though all of it's subareas are selected so the current behaviour has some logic).

  1. Even if greying the checkbox does not work on Ubuntu for some reason I think we should still try to do it and see if it works e.g. on Windows. A grey checkbox is more intuitive then italics. But of course we will keep the italics too to make sure that the dialog generally works on all systems.

#8 Updated by Andreas Müller 9 months ago

Patrick Plitzner wrote:

Implement buttons:

  • to (de-)select all children
  • select all children recursively or only direct children

The second issue does not seem to be implemented yet, but it is helpful if you want to check down to a certain hierarchie level.

#9 Updated by Patrick Plitzner 9 months ago

  • Status changed from Feedback to Closed
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 50 to 80

all implemented

#10 Updated by Andreas Müller 9 months ago

  • Status changed from Closed to Resolved

#11 Updated by Andreas Müller 9 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

Andreas Müller wrote:

  1. Even if greying the checkbox does not work on Ubuntu for some reason I think we should still try to do it and see if it works e.g. on Windows. A grey checkbox is more intuitive then italics. But of course we will keep the italics too to make sure that the dialog generally works on all systems.

The checkboxes are still not grey on Windows. Is this not possible? Then leave a message. Or just forgot?

#12 Updated by Andreas Müller 9 months ago

  • % Done changed from 80 to 90

All the rest works as expected now as far as I can see.

#13 Updated by Andreas Müller 9 months ago

There is still an issue with the usage e.g. for distribution editor. Here you may not want that the vocabulary itself can be selected. So the top level nodes must not be selectable only the state should change depending on the selection of the (recursive) children. But of course it would be nice to have the typical tristate behavior here (empty if no child is selected, unknown state if some children are selected and checked state if all children are selected.
I think it should be configurable if the topmost level can be selected or not.

#14 Updated by Andreas Müller 9 months ago

  • % Done changed from 90 to 80

#15 Updated by Patrick Plitzner 9 months ago

Andreas Müller wrote:

Andreas Müller wrote:

  1. Even if greying the checkbox does not work on Ubuntu for some reason I think we should still try to do it and see if it works e.g. on Windows. A grey checkbox is more intuitive then italics. But of course we will keep the italics too to make sure that the dialog generally works on all systems.

The checkboxes are still not grey on Windows. Is this not possible? Then leave a message. Or just forgot?

I cannot really test this because I have no working environment on Windows. If I just implement this blindly I am afraid of breaking something. Maybe I can pair up with a Windows user and try it there.

#16 Updated by Patrick Plitzner 9 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

Andreas Müller wrote:

There is still an issue with the usage e.g. for distribution editor. Here you may not want that the vocabulary itself can be selected. So the top level nodes must not be selectable only the state should change depending on the selection of the (recursive) children. But of course it would be nice to have the typical tristate behavior here (empty if no child is selected, unknown state if some children are selected and checked state if all children are selected.
I think it should be configurable if the topmost level can be selected or not.

This is implemented

#17 Updated by Andreas Müller 9 months ago

  • File picture900-1.png View added
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

Patrick Plitzner wrote:

Andreas Müller wrote:

There is still an issue with the usage e.g. for distribution editor. Here you may not want that the vocabulary itself can be selected. So the top level nodes must not be selectable only the state should change depending on the selection of the (recursive) children. But of course it would be nice to have the typical tristate behavior here (empty if no child is selected, unknown state if some children are selected and checked state if all children are selected.
I think it should be configurable if the topmost level can be selected or not.

This is implemented

OK, this works. Only it feels a bit strange that there is a checkbox which is always empty and can not be clicked and at the same time all the childrens are selected, e.g.:

So best would be to handle this checkbox as standard checkbox with in trees with unchecked=no child selected, checked=all children selected, tristate=some children selected. Alternatively, if possible, we could simply remove the checkbox.
However, this has no high priority, so if not easy to implement we can move it to a follow up ticket.

#18 Updated by Andreas Müller 9 months ago

Patrick Plitzner wrote:

Andreas Müller wrote:

Andreas Müller wrote:

  1. Even if greying the checkbox does not work on Ubuntu for some reason I think we should still try to do it and see if it works e.g. on Windows. A grey checkbox is more intuitive then italics. But of course we will keep the italics too to make sure that the dialog generally works on all systems.

The checkboxes are still not grey on Windows. Is this not possible? Then leave a message. Or just forgot?

I cannot really test this because I have no working environment on Windows. If I just implement this blindly I am afraid of breaking something. Maybe I can pair up with a Windows user and try it there.

@Katja: could you have a look if this can be done on Windows somehow. Also not high priority.

#19 Updated by Patrick Plitzner 9 months ago

I created a new ticket for the top-level checkbox -> #8054

#20 Updated by Patrick Plitzner 9 months ago

Andreas Müller wrote:

Patrick Plitzner wrote:

Andreas Müller wrote:

Andreas Müller wrote:

  1. Even if greying the checkbox does not work on Ubuntu for some reason I think we should still try to do it and see if it works e.g. on Windows. A grey checkbox is more intuitive then italics. But of course we will keep the italics too to make sure that the dialog generally works on all systems.

The checkboxes are still not grey on Windows. Is this not possible? Then leave a message. Or just forgot?

I cannot really test this because I have no working environment on Windows. If I just implement this blindly I am afraid of breaking something. Maybe I can pair up with a Windows user and try it there.

@Katja: could you have a look if this can be done on Windows somehow. Also not high priority.

@Katja: We can do this together next week.

#21 Updated by Andreas Müller 9 months ago

#22 Updated by Patrick Plitzner 8 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 100

Added remaining issues to #8054

#23 Updated by Andreas Müller 8 months ago

Please always add the follow up tickets to the "related issues" section, too.

#24 Updated by Andreas Müller 8 months ago

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)