feature request #7912
closedEnhance checkbox tree viewer
100%
Description
Implement buttons:
- to (de-)select all children
- select all children recursively or only direct children
Visualize selection state:
- Text of tree node
- italic when some children are selected
- bold when all children are selected
- default otherwise
- Checkboxes
- checked when item is selected
- grayed when item is not selected but some or all children are selected
Files
Related issues
Updated by Patrick Plitzner about 5 years ago
- Status changed from New to Resolved
- Assignee changed from Patrick Plitzner to Andreas Müller
- % Done changed from 0 to 50
Updated by Patrick Plitzner about 5 years ago
- Assignee changed from Andreas Müller to Katja Luther
Updated by Katja Luther almost 5 years ago
- Status changed from Resolved to Feedback
this seems to work, but the checkboxes are not grayed when a child or some children are selected.
Updated by Katja Luther almost 5 years ago
- Assignee changed from Katja Luther to Patrick Plitzner
Updated by Patrick Plitzner almost 5 years ago
- Assignee changed from Patrick Plitzner to Katja Luther
Katja Luther wrote:
this seems to work, but the checkboxes are not grayed when a child or some children are selected.
Setting the checkboxes to gray seems to be platform dependant. On the Lubuntu linux distribution, for example, this state cannot be shown. Therefore the font is changed according to the selection state. bold if all children are selected, italic if some children are selected and standard if nothing is selected.
Can you please test in some cases if this works for you especially when re-opening a dialog with saved areas? If the grayed state is not that important we may close this ticket.
Updated by Andreas Müller almost 5 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Katja Luther to Andreas Müller
To remind me to review.
Updated by Andreas Müller almost 5 years ago
- File picture672-1.png picture672-1.png added
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Patrick Plitzner
It works already very good. 2 minor issues:
- The state check should always include all children AND recursive children. E.g. here
MyAreas should have state "some" not "all" as Area1 is not selected (though all of it's subareas are selected so the current behaviour has some logic).
- Even if greying the checkbox does not work on Ubuntu for some reason I think we should still try to do it and see if it works e.g. on Windows. A grey checkbox is more intuitive then italics. But of course we will keep the italics too to make sure that the dialog generally works on all systems.
Updated by Andreas Müller almost 5 years ago
Patrick Plitzner wrote:
Implement buttons:
- to (de-)select all children
- select all children recursively or only direct children
The second issue does not seem to be implemented yet, but it is helpful if you want to check down to a certain hierarchie level.
Updated by Patrick Plitzner almost 5 years ago
- Status changed from Feedback to Closed
- Assignee changed from Patrick Plitzner to Andreas Müller
- % Done changed from 50 to 80
all implemented
Updated by Andreas Müller almost 5 years ago
- Status changed from Closed to Resolved
Updated by Andreas Müller almost 5 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Patrick Plitzner
Andreas Müller wrote:
- Even if greying the checkbox does not work on Ubuntu for some reason I think we should still try to do it and see if it works e.g. on Windows. A grey checkbox is more intuitive then italics. But of course we will keep the italics too to make sure that the dialog generally works on all systems.
The checkboxes are still not grey on Windows. Is this not possible? Then leave a message. Or just forgot?
Updated by Andreas Müller almost 5 years ago
- % Done changed from 80 to 90
All the rest works as expected now as far as I can see.
Updated by Andreas Müller almost 5 years ago
There is still an issue with the usage e.g. for distribution editor. Here you may not want that the vocabulary itself can be selected. So the top level nodes must not be selectable only the state should change depending on the selection of the (recursive) children. But of course it would be nice to have the typical tristate behavior here (empty if no child is selected, unknown state if some children are selected and checked state if all children are selected.
I think it should be configurable if the topmost level can be selected or not.
Updated by Patrick Plitzner almost 5 years ago
Andreas Müller wrote:
Andreas Müller wrote:
- Even if greying the checkbox does not work on Ubuntu for some reason I think we should still try to do it and see if it works e.g. on Windows. A grey checkbox is more intuitive then italics. But of course we will keep the italics too to make sure that the dialog generally works on all systems.
The checkboxes are still not grey on Windows. Is this not possible? Then leave a message. Or just forgot?
I cannot really test this because I have no working environment on Windows. If I just implement this blindly I am afraid of breaking something. Maybe I can pair up with a Windows user and try it there.
Updated by Patrick Plitzner almost 5 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Patrick Plitzner to Andreas Müller
Andreas Müller wrote:
There is still an issue with the usage e.g. for distribution editor. Here you may not want that the vocabulary itself can be selected. So the top level nodes must not be selectable only the state should change depending on the selection of the (recursive) children. But of course it would be nice to have the typical tristate behavior here (empty if no child is selected, unknown state if some children are selected and checked state if all children are selected.
I think it should be configurable if the topmost level can be selected or not.
This is implemented
Updated by Andreas Müller almost 5 years ago
- File picture900-1.png picture900-1.png added
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Patrick Plitzner
Patrick Plitzner wrote:
Andreas Müller wrote:
There is still an issue with the usage e.g. for distribution editor. Here you may not want that the vocabulary itself can be selected. So the top level nodes must not be selectable only the state should change depending on the selection of the (recursive) children. But of course it would be nice to have the typical tristate behavior here (empty if no child is selected, unknown state if some children are selected and checked state if all children are selected.
I think it should be configurable if the topmost level can be selected or not.This is implemented
OK, this works. Only it feels a bit strange that there is a checkbox which is always empty and can not be clicked and at the same time all the childrens are selected, e.g.:
So best would be to handle this checkbox as standard checkbox with in trees with unchecked=no child selected, checked=all children selected, tristate=some children selected. Alternatively, if possible, we could simply remove the checkbox.
However, this has no high priority, so if not easy to implement we can move it to a follow up ticket.
Updated by Andreas Müller almost 5 years ago
Patrick Plitzner wrote:
Andreas Müller wrote:
Andreas Müller wrote:
- Even if greying the checkbox does not work on Ubuntu for some reason I think we should still try to do it and see if it works e.g. on Windows. A grey checkbox is more intuitive then italics. But of course we will keep the italics too to make sure that the dialog generally works on all systems.
The checkboxes are still not grey on Windows. Is this not possible? Then leave a message. Or just forgot?
I cannot really test this because I have no working environment on Windows. If I just implement this blindly I am afraid of breaking something. Maybe I can pair up with a Windows user and try it there.
@Katja: could you have a look if this can be done on Windows somehow. Also not high priority.
Updated by Patrick Plitzner almost 5 years ago
I created a new ticket for the top-level checkbox -> #8054
Updated by Patrick Plitzner almost 5 years ago
Andreas Müller wrote:
Patrick Plitzner wrote:
Andreas Müller wrote:
Andreas Müller wrote:
- Even if greying the checkbox does not work on Ubuntu for some reason I think we should still try to do it and see if it works e.g. on Windows. A grey checkbox is more intuitive then italics. But of course we will keep the italics too to make sure that the dialog generally works on all systems.
The checkboxes are still not grey on Windows. Is this not possible? Then leave a message. Or just forgot?
I cannot really test this because I have no working environment on Windows. If I just implement this blindly I am afraid of breaking something. Maybe I can pair up with a Windows user and try it there.
@Katja: could you have a look if this can be done on Windows somehow. Also not high priority.
@Katja: We can do this together next week.
Updated by Andreas Müller almost 5 years ago
- Related to feature request #7063: Improve the area selection wizard for distribution editor added
Updated by Patrick Plitzner almost 5 years ago
- Status changed from Feedback to Closed
- % Done changed from 80 to 100
Added remaining issues to #8054
Updated by Andreas Müller almost 5 years ago
Please always add the follow up tickets to the "related issues" section, too.
Updated by Andreas Müller almost 5 years ago
- Copied to feature request #8054: Remaing issues - CheckBoxTreeComposite added