feature request #7887
Use DTOs in term editor
100%
Related issues
Associated revisions
ref #7887 Add operations framework to term editor
ref #7887 Fix potential NPE
ref #7887 Extract AbstractTermDto + add vocabulary dto service method
ref #7887 Use DTOs in term editor (experimental)
ref #7887 Add idInVocabulary and kindOfUuid to DTO + refactoring
ref #7887 USe idInVocabulary and kindOfUuid of DTO
ref #7887 Change idInVocabulary to String
ref #7887 Change idInVocabulary to String
ref #7887 Adapt term creation handler/operation to DTO (experimental)
ref #7887 code cleanup
ref #7887 Add service methods for term move and create
ref #7887 Use service for term creation directly
ref #7887 Add service method for term create
ref #7887 Use vocabulary service for term creation directly
ref #7887 Refactor IPostOperationEnabled.postOperation() to Object
ref #7887 Refactor AbstractPostOperation.postExecute() to Object
ref #7887 Adapt postOperation in term editor
- do not set dirty flag
- expand parent node
ref #7887 Refactor isModifiable() property test
ref #7887 Implement editing of DTOs in details view
ref #7887 Adapt moving terms based on DTOs
ref #7887 Adapt moving terms based on DTOs
ref #7887 Implement moving terms for ordered terms
ref #7887 Implement moving terms for ordered terms
ref #7887 Fix term moving to new vocabulary
ref #7887 Add generalizations to term DTO
ref #7887 Fix potential NPE
ref #7887 Add generalizations to term content provider
ref #7887 Convert delete handler/operation to DTOs
ref #7887 Get kindOfs in term content provider
ref #7887 Fix kindOf query
ref #7887 Prompt user if editor is dirty
ref #7887 i18n
ref #7887 Prompt user if editor is dirty (part II)
ref #7887 Pass DTO to move method
ref #7887 Pass DTO to move method
ref #7887 Fix showViewer() for details view
ref #7887 Rename service methods
ref #7887 Use DTOs in term editor
ref #7887 Implement term service methods based on DTOs
ref #7887 Use term DTOs in feature selection dialog for feature trees
ref #7887 Use term DTOs for distribution wizards
ref #7887 code cleanup
ref #7887 Sort vocabularies in term editor
ref #7887 Refresh term editor when new vocabulary is created
ref #7887 Speed up saving
- Fix multiple saving of the same term base
ref #7887 Fix preference persisting (based on DTOs)
ref #7887 Catch potential preference initialization problem
ref #7887 code cleanup
ref #7887 Remove getParent()
ref #7887 Refactor TermDto usage
ref #7887 Add "parent" DTOs to TermDto
ref #7887 Set parent DTOs during initialization
ref #7887 Fix preference persisting (based on DTOs)
ref #7887 code cleanup
ref #7887 Adapt to service layer changes
ref #7887 Fix javadoc
ref #7887 Fix initial grayed state in checkbox composite
ref #7887 Remove grayed value preferences from distributon wizards
ref #7887 Code cleanup
ref #7887 Remove unused classes
ref #7887 Return newly created DTO from service method
ref #7887 Select newly created term
ref #7887 Correctly evaluate children in term content provider
ref #7887 Enable supplemental data view for term DTOs
ref #7887 Fix possible NPE when dropping on same term
ref #7887: fix deletion of terms
ref #7887 Avoid moving a term onto itself or its children
ref #7887 i18n
ref #7887 Terms cannot be dropped above or below TermVocabulary any more
ref #7887 Fixed term sorting for ordered terms
ref #7887 Compare labels on lower case strings
History
#1 Updated by Patrick Plitzner almost 3 years ago
- Related to feature request #7875: Add multiple area selection to descriptive data set editor added
#2 Updated by Katja Luther almost 3 years ago
some issues I recognized while testing:
- the details view updates with every keystroke
- sometimes saving takes really long
- after creating a new vocabulary the editor does not update, you have to reopen the editor to see the new vocabulary
#3 Updated by Patrick Plitzner almost 3 years ago
- Status changed from New to Resolved
- Assignee changed from Patrick Plitzner to Katja Luther
- Target version changed from Unassigned CDM tickets to Release 5.5
- % Done changed from 0 to 50
Katja Luther wrote:
some issues I recognized while testing:
- after creating a new vocabulary the editor does not update, you have to reopen the editor to see the new vocabulary
I fixed the refresh problem for new vocabularies.
- the details view updates with every keystroke
Do you mean keystrokes in the details view? I don't see such behavior but it may depend on the hardware.
- sometimes saving takes really long
This should also be fixed. It used to save the same element multiple times.
#4 Updated by Katja Luther almost 3 years ago
- Status changed from Resolved to Closed
looks fine now!
#5 Updated by Katja Luther almost 3 years ago
- Status changed from Closed to Feedback
One open issue:
when creating a new defined term, the selection is still on the vocabulary, for lists with several entries, it is difficult to find the new term
#6 Updated by Katja Luther almost 3 years ago
- Assignee changed from Katja Luther to Patrick Plitzner
#7 Updated by Patrick Plitzner almost 3 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Patrick Plitzner to Katja Luther
Katja Luther wrote:
One open issue:
when creating a new defined term, the selection is still on the vocabulary, for lists with several entries, it is difficult to find the new term
This should be fixed now
#8 Updated by Patrick Plitzner almost 3 years ago
- Related to bug #7649: Term editor loads/saves extremely slow added
#9 Updated by Patrick Plitzner almost 3 years ago
@Katja: Please also check and close #7649 when this is reviewed.
#10 Updated by Patrick Plitzner almost 3 years ago
- Related to bug #7367: Deleting a term in the term editor does not update the UI added
#11 Updated by Patrick Plitzner almost 3 years ago
- Related to bug #6952: Deleting terms does not get reflected in the UI and in the DB added
#12 Updated by Patrick Plitzner almost 3 years ago
- Related to bug #6951: Drag and drop does not update term hierarchy in the UI added
#13 Updated by Katja Luther almost 3 years ago
- Status changed from Resolved to Closed
- Assignee changed from Katja Luther to Patrick Plitzner
- % Done changed from 50 to 100
after creating a new namedArea the deletion does not work because it is referenced by its parent. This is fixed with revision c5802825b
everything else seems to work fine.
#14 Updated by Andreas Müller almost 3 years ago
- Status changed from Closed to Feedback
- % Done changed from 100 to 50
Ein Problem ... ist, dass wenn ich ein Area mit mind. 1 Kind habe, und dieses Area dann zu einem Kind von sich selbst mache (schiebe) versehentlich, dann verschwindet der Term gänzlich samt aller Kinder. IN der DB ist das dann als Kind von sich selbst gespeichert. Ein solcher Drop sollte möglichst gar nicht erlaubt sein.
#15 Updated by Andreas Müller almost 3 years ago
… und wenn ich einen Term auf Top Level oberhalb eines Vokabulars versuche zu schieben wird er an die letzte Position dieses Vokabulars geschoben. Wenn dann würde es Sinn machen ihn an die letzte Position des darüber liegenden Vokabulars zu schieben, am besten wäre es aber, ein drop auf Toplevel (also im Prinzip auf Vokabularebene) überhaupt nicht zuzulassen.
#16 Updated by Andreas Müller almost 3 years ago
- Related to bug #7850: Further problems with term editor added
#17 Updated by Andreas Müller almost 3 years ago
- Related to deleted (bug #7850: Further problems with term editor)
#18 Updated by Andreas Müller almost 3 years ago
- Duplicated by bug #7850: Further problems with term editor added
#19 Updated by Patrick Plitzner almost 3 years ago
Andreas Müller wrote:
Ein Problem ... ist, dass wenn ich ein Area mit mind. 1 Kind habe, und dieses Area dann zu einem Kind von sich selbst mache (schiebe) versehentlich, dann verschwindet der Term gänzlich samt aller Kinder. IN der DB ist das dann als Kind von sich selbst gespeichert. Ein solcher Drop sollte möglichst gar nicht erlaubt sein.
this is fixed now
#20 Updated by Patrick Plitzner almost 3 years ago
- Assignee changed from Patrick Plitzner to Andreas Müller
- % Done changed from 50 to 60
Andreas Müller wrote:
… und wenn ich einen Term auf Top Level oberhalb eines Vokabulars versuche zu schieben wird er an die letzte Position dieses Vokabulars geschoben. Wenn dann würde es Sinn machen ihn an die letzte Position des darüber liegenden Vokabulars zu schieben, am besten wäre es aber, ein drop auf Toplevel (also im Prinzip auf Vokabularebene) überhaupt nicht zuzulassen.
We have to allow dropping onto vocabularies in order to either move a term from one vocabulary to another or to move it from a lower level to the top level of its vocabulary
#21 Updated by Andreas Müller almost 3 years ago
- Assignee changed from Andreas Müller to Patrick Plitzner
Patrick Plitzner wrote:
Andreas Müller wrote:
… und wenn ich einen Term auf Top Level oberhalb eines Vokabulars versuche zu schieben wird er an die letzte Position dieses Vokabulars geschoben. Wenn dann würde es Sinn machen ihn an die letzte Position des darüber liegenden Vokabulars zu schieben, am besten wäre es aber, ein drop auf Toplevel (also im Prinzip auf Vokabularebene) überhaupt nicht zuzulassen.
We have to allow dropping onto vocabularies in order to either move a term from one vocabulary to another or to move it from a lower level to the top level of its vocabulary
yes, but I drop it above the vocabulary, this should not result in adding it to the vocabulary, but, if at all to the above vocabulary
#22 Updated by Patrick Plitzner over 2 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Patrick Plitzner to Andreas Müller
- % Done changed from 60 to 80
Terms cannot be dropped above or below TermVocabulary any more
#23 Updated by Andreas Müller over 2 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Patrick Plitzner
- % Done changed from 80 to 60
Patrick Plitzner wrote:
Terms cannot be dropped above or below TermVocabulary any more
This seems to work now.
#24 Updated by Andreas Müller over 2 years ago
Ordering does not seem to work anymore. I tested with a user defined named area vocabulary with 7 no hiearchical areas.
I tried to move an area but nothing happened in UI. Also not after reopening Term Editor and also not after TaxEditor restart. Though something changed in NamedArea.orderindex in DB. But this also looks corrupted. E.g. after a while orderindex 0 did not exist anymore. Maybe the later also might be a cdmlib issue.
This is an important issue but we have to have in mind that ordering will be handled differently in future cdmlib versions so only simple fixes should be implemented.
#25 Updated by Patrick Plitzner over 2 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Patrick Plitzner to Andreas Müller
Andreas Müller wrote:
Ordering does not seem to work anymore. I tested with a user defined named area vocabulary with 7 no hiearchical areas.
I tried to move an area but nothing happened in UI. Also not after reopening Term Editor and also not after TaxEditor restart. Though something changed in NamedArea.orderindex in DB. But this also looks corrupted. E.g. after a while orderindex 0 did not exist anymore. Maybe the later also might be a cdmlib issue.
This is an important issue but we have to have in mind that ordering will be handled differently in future cdmlib versions so only simple fixes should be implemented.
This is fixed now. I forgot to return the order index when fixing another sorting issue.
#26 Updated by Andreas Müller over 2 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Patrick Plitzner
- % Done changed from 60 to 80
Patrick Plitzner wrote:
Andreas Müller wrote:
Ordering does not seem to work anymore. I tested with a user defined named area vocabulary with 7 no hiearchical areas.
I tried to move an area but nothing happened in UI. Also not after reopening Term Editor and also not after TaxEditor restart. Though something changed in NamedArea.orderindex in DB. But this also looks corrupted. E.g. after a while orderindex 0 did not exist anymore. Maybe the later also might be a cdmlib issue.
This is an important issue but we have to have in mind that ordering will be handled differently in future cdmlib versions so only simple fixes should be implemented.
This is fixed now. I forgot to return the order index when fixing another sorting issue.
It seems to work now in user interface. Still the orderIndex in the DB does have missing number in between if moving back and forth in the UI. This might be a cdmlib issue. As ordering will be changed in future anyway this is not considered to be critical.
#27 Updated by Andreas Müller over 2 years ago
Are there still open issues that need to be handled in separate tickets? I remember you said that vocabularies do not yet use DTOs. Is this fixed or does an other ticket exist? Please link if the later is true.
Also we decided that immediate saving for moving or deleting should be removed. This requires a new ticket but I can't see a link. Please create new ticket or link to existing ticket.
Afterwards this ticket can be closed.
#28 Updated by Patrick Plitzner over 2 years ago
- Status changed from Feedback to Closed
- % Done changed from 80 to 100
Andreas Müller wrote:
Are there still open issues that need to be handled in separate tickets? I remember you said that vocabularies do not yet use DTOs. Is this fixed or does an other ticket exist? Please link if the later is true.
Also we decided that immediate saving for moving or deleting should be removed. This requires a new ticket but I can't see a link. Please create new ticket or link to existing ticket.
Afterwards this ticket can be closed.
Added a new ticket for saving -> #8067
I was wrong, the term editor already works with DTOs for term vocabularies.
#29 Updated by Patrick Plitzner over 2 years ago
- Related to feature request #8067: Remove immediate saving after operations from term editor added
