Project

General

Profile

Actions

feature request #7865

open

Remaining factual data view label issues

Added by Patrick Plitzner over 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

80%

Estimated time:
Severity:
normal

Description

Copied from #7775:

  • If a source is added in the details view, and the titleCache is not protected, it should be generated into the label
  • we should allow to set titleCache to protected, otherwise it is not possible to use user defined labels for descriptions
  • Use titleCache field instead of label text field for descriptions

Related issues

Related to EDIT - bug #8200: Changing title(cache) for factual data set not possibleClosedPatrick Plitzner

Actions
Related to EDIT - bug #8234: Move description elements issuesClosedKatja Luther

Actions
Copied from EDIT - feature request #7775: Factual Data label issueClosedPatrick Plitzner

Actions
Actions #1

Updated by Patrick Plitzner over 5 years ago

  • Tracker changed from bug to feature request
Actions #2

Updated by Patrick Plitzner over 5 years ago

Actions #3

Updated by Patrick Plitzner over 5 years ago

  • Target version changed from Release 5.5 to Release 5.6
Actions #4

Updated by Patrick Plitzner about 5 years ago

  • Priority changed from New to Highest
Actions #5

Updated by Patrick Plitzner about 5 years ago

  • Target version changed from Release 5.6 to Reviewed Next Major Release
Actions #6

Updated by Patrick Plitzner about 5 years ago

  • Related to bug #8200: Changing title(cache) for factual data set not possible added
Actions #7

Updated by Patrick Plitzner about 5 years ago

  • Status changed from New to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • Target version changed from Reviewed Next Major Release to Release 5.6
  • % Done changed from 0 to 50

this should be fixed by fixing #8200

Actions #8

Updated by Patrick Plitzner about 5 years ago

  • Assignee changed from Andreas Müller to Patrick Plitzner
Actions #9

Updated by Patrick Plitzner about 5 years ago

  • Assignee changed from Patrick Plitzner to Katja Luther
Actions #10

Updated by Katja Luther about 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller

Works as excpected.
Tested on nightly. Added a factual data set and open the lock to edit the label, after save the user defined label was ok. Open the lock again and the label was generated again.
The same for factual data set with source.

Actions #11

Updated by Andreas Müller about 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

When I move a description (with no protected title cache) from 1 taxon to another taxon now the label of the new description is the standard label "Factual data set for xxx". Not long time ago it was something like "Data moved from taxon A" (not sure what it was exactly). This was important information and it is a serious regression. However, it did not come with the fix of this ticket but a bit earlier I think.

I don't know exactly how we can fix this best. We could put it to protected and use the old created text. But what, if we move it againg and it is protected, can we then simply change the label again?
Any ideas?

Maybe as a first step we could investigate how it was before and why the "moved" text is not shown anymore.

Actions #12

Updated by Patrick Plitzner about 5 years ago

  • Related to bug #8234: Move description elements issues added
Actions #13

Updated by Patrick Plitzner about 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 50 to 80

The titlecache issue is solved. Some other issues came up while fixing this ticket -> #8234

Actions #14

Updated by Andreas Müller about 5 years ago

Patrick Plitzner wrote:

The titlecache issue is solved. Some other issues came up while fixing this ticket -> #8234

It is solved according to the description of this ticket. But also a regression (described in #note-11) has been implemented in this ticket or in the previous ticket #7775. This is a critical regression because it removed a user requirement which was in place for many years and which the users want to have. Regressions should be fixed before closing a ticket.

Actions #15

Updated by Andreas Müller about 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

As mentioned in note-11 the solution for the problem is not so easy. First of all we should have a look how it was implemented before and why it does not work anymore.

One step to solve could be to use the old text for "Moved from ..." and set the titleCache to protected then to avoid that the text gets lost. Difficult question is how to handle already protected caches. Should we simply attache the text to the already existing text (concatenated with ". "). Or is there a better solution?

A completely differen solution could be to simply attache a source of source type "Lineage" which keeps the "moved from" text in the original info field. To me this seems to be a reasonable solution but it needs to be discussed with the users. Maybe also a combination of both might be the best.

Actions #16

Updated by Patrick Plitzner about 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

It has now be solved like this:

  • TitleCache is protected -> <old TitleCache> - <Move message>
  • TitleCache is not protected -> <Move message>
Actions

Also available in: Atom PDF