Project

General

Profile

task #7854

Open issues in TaxDistributionEditor

Added by Andreas Müller 3 months ago. Updated 4 days ago.

Status:
Feedback
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
10/23/2018
Due date:
% Done:

0%

Severity:
normal
Tags:

Description

  • use NAT tables
  • improve area selection dialog #7063
  • remove factual data view, wenn opening distribution editor
  • sorting does not always work correctly (see attachment)
  • warning before opening if number of opened taxa is large (e.g. >200), this may take time

mail from Eckhard:

  • Da ich in diesem Fall (der eher selten vorkommt) tatsächlich über 40 Areale in einer Tabelle habe, wäre es schön, wenn ich zwischen den Tabellenfeldern mit den Tabulatortasten navigieren könnte, und nicht die Maus benutzen müsste
  • aus dem gleichen Grund wäre es schön, wenn die erste Spalte mit den Taxa fixiert werden könnte, damit sie nicht verschwindet, wenn ich an das rechte Ende der Tabelle gehe und dann nicht mehr weiß, bei welchem Taxon ich gerade bin
  • der Verbreitungseditor erinnert sich auch nicht, wenn ich die Spaltenbreite verändert habe. Könnte man ihn dazu bringen, die Spaltenbreite automatisch an die Länge der Bezeichnungen in der Kopfzeile anzupassen?

picture829-1.png View (12.1 KB) Andreas Müller, 10/24/2018 05:52 PM

picture798-1.png View (29.6 KB) Andreas Müller, 01/16/2019 11:28 PM


Related issues

Related to Edit - bug #7856: Allow local override for distribution vocabularies Feedback 10/23/2018
Related to Edit - feature request #7063: improve the area selection wizard for distribution editor Resolved 11/07/2017
Related to Edit - bug #6159: improve distribution editor in TaxEditor Resolved 10/24/2016
Related to Edit - bug #7999: Allow override does not work correctly for distribution areas Resolved 01/17/2019

Associated revisions

Revision 01d7c5e7 (diff)
Added by Katja Luther about 1 month ago

ref #7854: add ComboBox for status selection and merge distributionElements

Revision 5618ca88 (diff)
Added by Katja Luther about 1 month ago

ref #7854: add service method to merge a set of descriptionelements

Revision 48fb701d (diff)
Added by Katja Luther about 1 month ago

ref #7854: correct saving, details view and default source handling

Revision 943e9b24 (diff)
Added by Katja Luther about 1 month ago

ref #7854: show details for distributions and reload after changing the areas in distribution editor

Revision 9d0707c1 (diff)
Added by Katja Luther about 1 month ago

ref #7854: fix reload

Revision 331c7265 (diff)
Added by Katja Luther about 1 month ago

ref #7854: freezing taxon column

Revision b55fd194 (diff)
Added by Katja Luther about 1 month ago

ref #7854: add methods to get DTOs for distribution editor

Revision 9245724f (diff)
Added by Katja Luther about 1 month ago

ref #7854: improve removing of distributions in NAT table distribution editor

Revision f32128b6 (diff)
Added by Katja Luther about 1 month ago

ref #7854: add filter to taxon row

Revision da628899 (diff)
Added by Katja Luther about 1 month ago

ref #7854: add filter column to distribution columns

Revision f5832048 (diff)
Added by Katja Luther about 1 month ago

ref #7854: changes in details view and supplemental data view need to result in dirty state of the distribution editor

Revision 343fcdde (diff)
Added by Katja Luther about 1 month ago

ref #7854: adapt to changes in DescriptionDTO

Revision 2afca98f (diff)
Added by Katja Luther about 1 month ago

ref #7854: add taxon to descriptionDTO

Revision 278a5e0a (diff)
Added by Katja Luther about 1 month ago

ref #7854 Implement NatTable for distribution editor

Revision 97d21185 (diff)
Added by Katja Luther about 1 month ago

ref #7854: minor changes in session handling

Revision c5d906bd (diff)
Added by Katja Luther about 1 month ago

ref #7854: implement getRootEnteties for the session view in distributioneditorPart

Revision 576b283c (diff)
Added by Katja Luther about 1 month ago

ref #7854: changes in taxonDistributionDTO

Revision 2e385b93 (diff)
Added by Katja Luther about 1 month ago

ref #7854: session handling in distribution editor

Revision 0747234f (diff)
Added by Katja Luther about 1 month ago

ref #7854: continue session handling in distribution editor

Revision 16833e53 (diff)
Added by Katja Luther about 1 month ago

ref #7854: adapt DTOs

Revision 3971a637 (diff)
Added by Katja Luther about 1 month ago

ref #7854: adapt DTOs and merge Method for Distributions

Revision ad2e9ab4 (diff)
Added by Katja Luther about 1 month ago

ref #7854: continue session handling in distribution editor

Revision 5ab46e89 (diff)
Added by Katja Luther about 1 month ago

ref #7854: show label corresponding to preferences

Revision 2b73afd3 (diff)
Added by Katja Luther about 1 month ago

ref #7854: minor changes

Revision 1749b4af (diff)
Added by Katja Luther 13 days ago

ref #7854: avoid NPE

Revision bb082354 (diff)
Added by Katja Luther 12 days ago

ref #7854: fix exceptions in distribution editor when saving new created descriptions

Revision e0980264 (diff)
Added by Katja Luther 12 days ago

ref #7854: handling of new descriptions moved to editor

Revision 0b63dea4 (diff)
Added by Katja Luther 8 days ago

ref #7854: avoid NPEs

Revision 10aaa73f (diff)
Added by Katja Luther 8 days ago

ref #7854: allow free editing in filter row

Revision 39392527 (diff)
Added by Katja Luther 8 days ago

ref #7854: close factual data view when opening distribution editor and open it when opening name editor

Revision a893ba13 (diff)
Added by Katja Luther 7 days ago

ref #7854: update details view when editing status in distribu

Revision 54efcbc1 (diff)
Added by Katja Luther 4 days ago

ref #7854: move count and default ref in one line

History

#1 Updated by Andreas Müller 3 months ago

  • Related to bug #7656: Adapt inverse symbol for MisappliedName relationship type added

#2 Updated by Andreas Müller 3 months ago

  • Related to deleted (bug #7656: Adapt inverse symbol for MisappliedName relationship type)

#3 Updated by Andreas Müller 3 months ago

  • Related to bug #7856: Allow local override for distribution vocabularies added

#4 Updated by Andreas Müller 3 months ago

#5 Updated by Andreas Müller 3 months ago

  • Description updated (diff)

#6 Updated by Andreas Müller 3 months ago

  • Description updated (diff)

#7 Updated by Andreas Müller 3 months ago

  • Related to bug #6159: improve distribution editor in TaxEditor added

#8 Updated by Andreas Müller 3 months ago

#9 Updated by Andreas Müller 3 months ago

  • Description updated (diff)

#10 Updated by Katja Luther about 2 months ago

  • Description updated (diff)

#11 Updated by Katja Luther about 1 month ago

  • Status changed from New to In Progress
  • Priority changed from New to Highest

in branch distributionEditorNatTable a first implementation of the distribution editor with NAT tables is available.

Feature already implemented:

  • all features available in the previous implementation
  • freeze the first column
  • filter column , but at the moment it only works for the taxon column

still open:

  • remember the column widths
  • filter for distribution columns
  • rank column
  • when editing only the details or supplemental data, the dirty flag is not set!!!
  • handling of areas with more then one distribution

#12 Updated by Katja Luther about 1 month ago

the branch is now merged to develop.

There are still some problems with multiple representation exceptions.

#13 Updated by Andreas Müller 5 days ago

The dropbox for states opens on top. This leads to a cut of the list which makes it impossible to choose from the topmost states. In the following screenshot there should be more available states abover "casual: presence questionable":

#14 Updated by Andreas Müller 5 days ago

In preferences translate possible configuration terms "Show IdInVocabulary", ...

Also remove "Show" from all entries. Simply use "Label" (not title!), "Symbol 1" (please add whitespace), "Symbol 2", "ID in vocabulary" (whitespace, no camel case!)

#15 Updated by Andreas Müller 5 days ago

Multiple cell selection in table is currently possible. As there is no function related to this we should remove this feature for now.

#16 Updated by Andreas Müller 5 days ago

The dropbox for states has a checkbox. As it is only for selecting a single state this does not make sense as it gives the fealing as if multiple select is possible.

#17 Updated by Andreas Müller 5 days ago

  • Status changed from In Progress to Feedback

Critical: often the selected state is not taken over to the cell or into the details view. It simply looks like the value does not change at all, though another state was selectd. Happens sometimes/often but not always

#18 Updated by Andreas Müller 5 days ago

Horizontal scrollbar should appear only if necessary. This is the case only after resize of the part. Should also be recomputed after area selection changed.

#19 Updated by Andreas Müller 5 days ago

Below the row count (element count) there is a lot of empty space. Can this be reduced?

Also if possible change the label to "Row count" or "Taxa".

#20 Updated by Andreas Müller 5 days ago

Not urgent but todo at some time: try to optimize the column width at start or after area selection. Details may be discussed. We have/had a similar discussion for the bulk editor in some other ticket.

#21 Updated by Andreas Müller 5 days ago

Why did you move the buttons for area selection and source selection to the left. I think they look better on the right side. Also please add some spacing to the border.

#22 Updated by Andreas Müller 5 days ago

The automated source attachement often does not work or is at least not shown in the details view immediately. The later might be the case as the details view often does not update correctly after selection change.

#23 Updated by Andreas Müller 5 days ago

Andreas Müller wrote:

The dropbox for states opens on top. This leads to a cut of the list which makes it impossible to choose from the topmost states. In the following screenshot there should be more available states abover "casual: presence questionable":

This is the case only if the list is too long to show up in full below the cell.

#24 Updated by Andreas Müller 5 days ago

Critical: saving after multiple changes (maybe even of the same cell) seems to crash the application (no return from save command - "keine Rückmeldung"). Happened to me twice now within short time. Saving small amounts worked well.

#25 Updated by Andreas Müller 5 days ago

Andreas Müller wrote:

Below the row count (element count) there is a lot of empty space. Can this be reduced?

OK, I see this is the line for preselected source. If possible we should try to put it into the same line as the count. But maybe difficult because row count belongs to NAT table? If really impossible we should show the source line only if a value is given AND move it to the left.

#26 Updated by Andreas Müller 5 days ago

... or move it to the top. Needs to be tested what looks better.

#27 Updated by Andreas Müller 5 days ago

Andreas Müller wrote:

Critical: saving after multiple changes (maybe even of the same cell) seems to crash the application (no return from save command - "keine Rückmeldung"). Happened to me twice now within short time. Saving small amounts worked well.

Or maybe it is also related to usage of preselected sources? It happened again now after selecting source, before it didn't with a couple of changes.

#28 Updated by Andreas Müller 5 days ago

Andreas Müller wrote:

Critical: saving after multiple changes (maybe even of the same cell) seems to crash the application (no return from save command - "keine Rückmeldung"). Happened to me twice now within short time. Saving small amounts worked well.

After longer time we get:

login : testi
editor version : 5.5.0.201901161229
server :  (edit-test)
schema version : 
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
org.springframework.remoting.RemoteAccessException: Could not access HTTP invoker remote service at [http://test.e-taxonomy.eu:80/cdmserver/rem_conf_am/remoting/term.service]; nested exception is org.apache.http.NoHttpResponseException: Did not receive successful HTTP response: status code = 503, status message = [Service Unavailable]
    at org.springframework.remoting.httpinvoker.HttpInvokerClientInterceptor.convertHttpInvokerAccessException(HttpInvokerClientInterceptor.java:216)
    at org.springframework.remoting.httpinvoker.HttpInvokerClientInterceptor.invoke(HttpInvokerClientInterceptor.java:147)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
    at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:208)
    at com.sun.proxy.$Proxy46.findWithoutFlush(Unknown Source)
    at eu.etaxonomy.cdm.api.cache.CdmServiceCacher.findByUuid(CdmServiceCacher.java:93)
    at eu.etaxonomy.cdm.api.cache.CdmCacher.load(CdmCacher.java:134)
    at eu.etaxonomy.cdm.model.common.Language.getDefaultLanguage_aroundBody996(Language.java:1304)
    at eu.etaxonomy.cdm.model.common.Language.getDefaultLanguage(Language.java:1)
    at eu.etaxonomy.cdm.model.common.Language.DEFAULT_aroundBody982(Language.java:1148)
    at eu.etaxonomy.cdm.model.common.Language.DEFAULT(Language.java:1)
    at eu.etaxonomy.cdm.model.common.TermBase.getLabel(TermBase.java:208)
    at sun.reflect.GeneratedMethodAccessor75.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.hibernate.proxy.pojo.javassist.JavassistLazyInitializer.invoke(JavassistLazyInitializer.java:79)
    at eu.etaxonomy.cdm.model.description.PresenceAbsenceTerm_$$_jvst1eb_9.getLabel(PresenceAbsenceTerm_$$_jvst1eb_9.java)
    at eu.etaxonomy.taxeditor.editor.view.checklist.e4.DistributionColumnAccessor.lambda$0(DistributionColumnAccessor.java:80)
    at java.lang.Iterable.forEach(Iterable.java:75)
    at eu.etaxonomy.taxeditor.editor.view.checklist.e4.DistributionColumnAccessor.getDataValue(DistributionColumnAccessor.java:80)
    at eu.etaxonomy.taxeditor.editor.view.checklist.e4.DistributionColumnAccessor.getDataValue(DistributionColumnAccessor.java:1)
    at org.eclipse.nebula.widgets.nattable.data.ListDataProvider.getDataValue(ListDataProvider.java:51)
    at org.eclipse.nebula.widgets.nattable.layer.DataLayer.getDataValue(DataLayer.java:164)
    at org.eclipse.nebula.widgets.nattable.layer.DataLayer.getDataValueByPosition(DataLayer.java:447)
    at org.eclipse.nebula.widgets.nattable.layer.AbstractIndexLayerTransform.getDataValueByPosition(AbstractIndexLayerTransform.java:358)
    at org.eclipse.nebula.widgets.nattable.layer.cell.AbstractLayerCell.getDataValue(AbstractLayerCell.java:64)
    at eu.etaxonomy.taxeditor.editor.view.checklist.e4.DistributionCellSelectionListener.handleLayerEvent(DistributionCellSelectionListener.java:52)
    at org.eclipse.nebula.widgets.nattable.layer.AbstractLayer.fireLayerEvent(AbstractLayer.java:307)
    at org.eclipse.nebula.widgets.nattable.selection.SelectionLayer.fireCellSelectionEvent(SelectionLayer.java:592)
    at org.eclipse.nebula.widgets.nattable.selection.SelectCellCommandHandler.doCommand(SelectCellCommandHandler.java:42)
    at org.eclipse.nebula.widgets.nattable.selection.SelectCellCommandHandler.doCommand(SelectCellCommandHandler.java:1)
    at org.eclipse.nebula.widgets.nattable.layer.AbstractLayer.doCommand(AbstractLayer.java:186)
    at org.eclipse.nebula.widgets.nattable.layer.AbstractIndexLayerTransform.doCommand(AbstractIndexLayerTransform.java:105)
    at org.eclipse.nebula.widgets.nattable.selection.SelectionLayer.doCommand(SelectionLayer.java:579)
    at org.eclipse.nebula.widgets.nattable.layer.AbstractIndexLayerTransform.doCommand(AbstractIndexLayerTransform.java:109)
    at org.eclipse.nebula.widgets.nattable.layer.CompositeLayer.doCommandOnChildLayers(CompositeLayer.java:159)
    at org.eclipse.nebula.widgets.nattable.layer.CompositeLayer.doCommand(CompositeLayer.java:151)
    at org.eclipse.nebula.widgets.nattable.freeze.CompositeFreezeLayer.doCommand(CompositeFreezeLayer.java:148)
    at org.eclipse.nebula.widgets.nattable.grid.layer.GridLayer.doCommandOnChildLayer(GridLayer.java:113)
    at org.eclipse.nebula.widgets.nattable.grid.layer.GridLayer.doCommandOnChildLayers(GridLayer.java:99)
    at org.eclipse.nebula.widgets.nattable.layer.CompositeLayer.doCommand(CompositeLayer.java:151)
    at org.eclipse.nebula.widgets.nattable.grid.layer.GridLayer.doCommand(GridLayer.java:187)
    at org.eclipse.nebula.widgets.nattable.NatTable.doCommand(NatTable.java:820)
    at org.eclipse.nebula.widgets.nattable.selection.action.SelectCellAction.run(SelectCellAction.java:25)
    at org.eclipse.nebula.widgets.nattable.ui.mode.ConfigurableModeEventHandler.mouseDown(ConfigurableModeEventHandler.java:45)
    at org.eclipse.nebula.widgets.nattable.ui.mode.ModeSupport.mouseDown(ModeSupport.java:108)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:193)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
...
Caused by: org.apache.http.NoHttpResponseException: Did not receive successful HTTP response: status code = 503, status message = [Service Unavailable]
    at org.springframework.remoting.httpinvoker.HttpComponentsHttpInvokerRequestExecutor.validateResponse(HttpComponentsHttpInvokerRequestExecutor.java:357)
    at org.springframework.remoting.httpinvoker.HttpComponentsHttpInvokerRequestExecutor.doExecuteRequest(HttpComponentsHttpInvokerRequestExecutor.java:230)
    at eu.etaxonomy.taxeditor.service.CdmServiceRequestExecutor.doExecuteRequest(CdmServiceRequestExecutor.java:61)
    ... 71 more

#29 Updated by Andreas Müller 5 days ago

... hmm, maybe this was not the original message after save but a bit later and similar

#30 Updated by Andreas Müller 5 days ago

  • Description updated (diff)

#31 Updated by Katja Luther 5 days ago

  • Description updated (diff)
  • Status changed from Feedback to In Progress

the selection should work now, I missed to commit the changes in details view.

#32 Updated by Katja Luther 5 days ago

How long did you work with the distribution editor when the saving did not work anymore?

#33 Updated by Andreas Müller 5 days ago

  • Related to bug #7999: Allow override does not work correctly for distribution areas added

#34 Updated by Andreas Müller 5 days ago

  • Status changed from In Progress to Feedback

was the status change on purpose?

#35 Updated by Andreas Müller 5 days ago

Katja Luther wrote:

How long did you work with the distribution editor when the saving did not work anymore?

I did maybe 20-30 changes in about 10 differnt taxa

#36 Updated by Andreas Müller 5 days ago

Katja Luther wrote:

the selection should work now, I missed to commit the changes in details view.

The detail view seems now always to be synchronized, but the critical issue that the selected value from the dropdown is not taken as a value still exists. See #7854#note-17. This occurrs if you want to change a value, e.g. I never manage to change from absent to present. I need to remove absent first and then I can set present. The other way round it works, changing present to absent.

#37 Updated by Andreas Müller 5 days ago

  • Description updated (diff)

#38 Updated by Katja Luther 5 days ago

Andreas Müller wrote:

Katja Luther wrote:

the selection should work now, I missed to commit the changes in details view.

The detail view seems now always to be synchronized, but the critical issue that the selected value from the dropdown is not taken as a value still exists. See #7854#note-17. This occurrs if you want to change a value, e.g. I never manage to change from absent to present. I need to remove absent first and then I can set present. The other way round it works, changing present to absent.

I can't reproduce this.

#39 Updated by Katja Luther 5 days ago

Katja Luther wrote:

Andreas Müller wrote:

Katja Luther wrote:

the selection should work now, I missed to commit the changes in details view.

The detail view seems now always to be synchronized, but the critical issue that the selected value from the dropdown is not taken as a value still exists. See #7854#note-17. This occurrs if you want to change a value, e.g. I never manage to change from absent to present. I need to remove absent first and then I can set present. The other way round it works, changing present to absent.

I can't reproduce this.

no I think that was because the ticket was still open with the status "in process"

#40 Updated by Katja Luther 5 days ago

  • Description updated (diff)

#41 Updated by Katja Luther 4 days ago

  • Description updated (diff)

Andreas Müller wrote:

The automated source attachement often does not work or is at least not shown in the details view immediately. The later might be the case as the details view often does not update correctly after selection change.

When the source was not opened before in another details view, it is still collapsed but I could not reproduce it that it does not work.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)