Project

General

Profile

task #7854

Open issues in TaxDistributionEditor

Added by Andreas Müller 7 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
10/23/2018
Due date:
% Done:

60%

Severity:
normal
Tags:

Description

  • use NAT tables
  • improve area selection dialog #7063
  • remove factual data view, wenn opening distribution editor
  • sorting does not always work correctly (see attachment)
  • warning before opening if number of opened taxa is large (e.g. >200), this may take time

mail from Eckhard:

  • Da ich in diesem Fall (der eher selten vorkommt) tatsächlich über 40 Areale in einer Tabelle habe, wäre es schön, wenn ich zwischen den Tabellenfeldern mit den Tabulatortasten navigieren könnte, und nicht die Maus benutzen müsste
  • aus dem gleichen Grund wäre es schön, wenn die erste Spalte mit den Taxa fixiert werden könnte, damit sie nicht verschwindet, wenn ich an das rechte Ende der Tabelle gehe und dann nicht mehr weiß, bei welchem Taxon ich gerade bin
  • der Verbreitungseditor erinnert sich auch nicht, wenn ich die Spaltenbreite verändert habe. Könnte man ihn dazu bringen, die Spaltenbreite automatisch an die Länge der Bezeichnungen in der Kopfzeile anzupassen? => #8047

picture829-1.png View (12.1 KB) Andreas Müller, 10/24/2018 05:52 PM

picture798-1.png View (29.6 KB) Andreas Müller, 01/16/2019 11:28 PM

picture907-1.png View (3.98 KB) Andreas Müller, 01/29/2019 09:30 PM

picture477-1.png View (12.8 KB) Andreas Müller, 01/29/2019 11:24 PM

picture477-2.png View (11.8 KB) Andreas Müller, 01/29/2019 11:24 PM

picture562-1.png View (11.7 KB) Andreas Müller, 01/29/2019 11:27 PM

picture958-1.png View (10.1 KB) Andreas Müller, 01/29/2019 11:39 PM


Related issues

Related to Edit - bug #7856: Allow local override for distribution vocabularies Closed 10/23/2018
Related to Edit - feature request #7063: Improve the area selection wizard for distribution editor Closed 11/07/2017
Related to Edit - bug #6159: improve distribution editor in TaxEditor Closed 10/24/2016
Related to Edit - bug #7999: Allow override does not work correctly for distribution areas Closed 01/17/2019
Related to Edit - bug #8043: ConstraintViolationException in distribution editor Worksforme 01/31/2019
Copied to Edit - task #8047: Remaining issues in TaxDistributionEditor New 01/31/2019

Associated revisions

Revision 01d7c5e7 (diff)
Added by Katja Luther 5 months ago

ref #7854: add ComboBox for status selection and merge distributionElements

Revision 5618ca88 (diff)
Added by Katja Luther 5 months ago

ref #7854: add service method to merge a set of descriptionelements

Revision 48fb701d (diff)
Added by Katja Luther 5 months ago

ref #7854: correct saving, details view and default source handling

Revision 943e9b24 (diff)
Added by Katja Luther 5 months ago

ref #7854: show details for distributions and reload after changing the areas in distribution editor

Revision 9d0707c1 (diff)
Added by Katja Luther 5 months ago

ref #7854: fix reload

Revision 331c7265 (diff)
Added by Katja Luther 5 months ago

ref #7854: freezing taxon column

Revision b55fd194 (diff)
Added by Katja Luther 5 months ago

ref #7854: add methods to get DTOs for distribution editor

Revision 9245724f (diff)
Added by Katja Luther 5 months ago

ref #7854: improve removing of distributions in NAT table distribution editor

Revision f32128b6 (diff)
Added by Katja Luther 5 months ago

ref #7854: add filter to taxon row

Revision da628899 (diff)
Added by Katja Luther 5 months ago

ref #7854: add filter column to distribution columns

Revision f5832048 (diff)
Added by Katja Luther 5 months ago

ref #7854: changes in details view and supplemental data view need to result in dirty state of the distribution editor

Revision 343fcdde (diff)
Added by Katja Luther 5 months ago

ref #7854: adapt to changes in DescriptionDTO

Revision 2afca98f (diff)
Added by Katja Luther 5 months ago

ref #7854: add taxon to descriptionDTO

Revision 278a5e0a (diff)
Added by Katja Luther 5 months ago

ref #7854 Implement NatTable for distribution editor

Revision 97d21185 (diff)
Added by Katja Luther 5 months ago

ref #7854: minor changes in session handling

Revision c5d906bd (diff)
Added by Katja Luther 5 months ago

ref #7854: implement getRootEnteties for the session view in distributioneditorPart

Revision 576b283c (diff)
Added by Katja Luther 5 months ago

ref #7854: changes in taxonDistributionDTO

Revision 2e385b93 (diff)
Added by Katja Luther 5 months ago

ref #7854: session handling in distribution editor

Revision 0747234f (diff)
Added by Katja Luther 5 months ago

ref #7854: continue session handling in distribution editor

Revision 16833e53 (diff)
Added by Katja Luther 5 months ago

ref #7854: adapt DTOs

Revision 3971a637 (diff)
Added by Katja Luther 5 months ago

ref #7854: adapt DTOs and merge Method for Distributions

Revision ad2e9ab4 (diff)
Added by Katja Luther 5 months ago

ref #7854: continue session handling in distribution editor

Revision 5ab46e89 (diff)
Added by Katja Luther 5 months ago

ref #7854: show label corresponding to preferences

Revision 2b73afd3 (diff)
Added by Katja Luther 5 months ago

ref #7854: minor changes

Revision 1749b4af (diff)
Added by Katja Luther 4 months ago

ref #7854: avoid NPE

Revision bb082354 (diff)
Added by Katja Luther 4 months ago

ref #7854: fix exceptions in distribution editor when saving new created descriptions

Revision e0980264 (diff)
Added by Katja Luther 4 months ago

ref #7854: handling of new descriptions moved to editor

Revision 0b63dea4 (diff)
Added by Katja Luther 4 months ago

ref #7854: avoid NPEs

Revision 10aaa73f (diff)
Added by Katja Luther 4 months ago

ref #7854: allow free editing in filter row

Revision 39392527 (diff)
Added by Katja Luther 4 months ago

ref #7854: close factual data view when opening distribution editor and open it when opening name editor

Revision a893ba13 (diff)
Added by Katja Luther 4 months ago

ref #7854: update details view when editing status in distribu

Revision 54efcbc1 (diff)
Added by Katja Luther 4 months ago

ref #7854: move count and default ref in one line

Revision ec6c94b9 (diff)
Added by Katja Luther 4 months ago

ref #7854: fix problems in distribution editor

Revision 6ffe25c9 (diff)
Added by Katja Luther 4 months ago

ref #7854: change label for term display

Revision 018b80b2 (diff)
Added by Katja Luther 4 months ago

ref #7854: improve handling of selection changes in distribution editor

Revision 2c5f962c (diff)
Added by Katja Luther 4 months ago

ref #7854: minor

Revision 09330f46 (diff)
Added by Katja Luther 4 months ago

ref #7854: do not create new distribution without status

Revision 2fc06005 (diff)
Added by Katja Luther 4 months ago

ref #7854: add max visible items for drop down in distribution editor

Revision 22c22144 (diff)
Added by Katja Luther 4 months ago

ref #7854: ClientAreaResize to avoid scrollbars where it is not needed

Revision c3ef0593 (diff)
Added by Katja Luther 4 months ago

ref #7854: minor

Revision 48f770f5 (diff)
Added by Andreas Müller 4 months ago

ref #7854 Fix NPE in TaxonDistributionDTO

Revision b81fb3cb (diff)
Added by Katja Luther 4 months ago

ref #7854: fix saving problem

Revision ac05a823 (diff)
Added by Katja Luther 4 months ago

ref #7854: fix problem of wrong setting of values in other cell

Revision e2bf52fe (diff)
Added by Andreas Müller 4 months ago

ref #7854 Fix NPE in TaxonDistributionDTO (2nd try)

Revision a559c7f6 (diff)
Added by Katja Luther 4 months ago

ref #7854: correct handling when first entry is none-term and add rank display in distribution editor

Revision 663a45e5 (diff)
Added by Katja Luther 4 months ago

ref #7854: fix filter for none status and adapt filter to status display preference

Revision f6353ba0 (diff)
Added by Katja Luther 3 months ago

ref #7854: label of default source

Revision 3d620eb4 (diff)
Added by Katja Luther 3 months ago

ref #7854: button for removing default source

Revision b512f232 (diff)
Added by Katja Luther 3 months ago

ref #7854: string externalization

Revision 88672879 (diff)
Added by Katja Luther 3 months ago

ref #7854: use preferred terms for PA terms if none are selected for distribution editor

Revision 61240256 (diff)
Added by Katja Luther 3 months ago

ref #7854: continue order of columns in distribution editor

History

#1 Updated by Andreas Müller 7 months ago

  • Related to bug #7656: Adapt inverse symbol for MisappliedName relationship type added

#2 Updated by Andreas Müller 7 months ago

  • Related to deleted (bug #7656: Adapt inverse symbol for MisappliedName relationship type)

#3 Updated by Andreas Müller 7 months ago

  • Related to bug #7856: Allow local override for distribution vocabularies added

#4 Updated by Andreas Müller 7 months ago

#5 Updated by Andreas Müller 7 months ago

  • Description updated (diff)

#6 Updated by Andreas Müller 7 months ago

  • Description updated (diff)

#7 Updated by Andreas Müller 7 months ago

  • Related to bug #6159: improve distribution editor in TaxEditor added

#8 Updated by Andreas Müller 7 months ago

#9 Updated by Andreas Müller 7 months ago

  • Description updated (diff)

#10 Updated by Katja Luther 6 months ago

  • Description updated (diff)

#11 Updated by Katja Luther 5 months ago

  • Status changed from New to In Progress
  • Priority changed from New to Highest

in branch distributionEditorNatTable a first implementation of the distribution editor with NAT tables is available.

Feature already implemented:

  • all features available in the previous implementation
  • freeze the first column
  • filter column , but at the moment it only works for the taxon column

still open:

  • remember the column widths
  • filter for distribution columns
  • rank column
  • when editing only the details or supplemental data, the dirty flag is not set!!!
  • handling of areas with more then one distribution

#12 Updated by Katja Luther 5 months ago

the branch is now merged to develop.

There are still some problems with multiple representation exceptions.

#13 Updated by Andreas Müller 4 months ago

The dropbox for states opens on top. This leads to a cut of the list which makes it impossible to choose from the topmost states. In the following screenshot there should be more available states abover "casual: presence questionable":

#14 Updated by Andreas Müller 4 months ago

In preferences translate possible configuration terms "Show IdInVocabulary", ...

Also remove "Show" from all entries. Simply use "Label" (not title!), "Symbol 1" (please add whitespace), "Symbol 2", "ID in vocabulary" (whitespace, no camel case!)

#15 Updated by Andreas Müller 4 months ago

Multiple cell selection in table is currently possible. As there is no function related to this we should remove this feature for now.

#16 Updated by Andreas Müller 4 months ago

The dropbox for states has a checkbox. As it is only for selecting a single state this does not make sense as it gives the fealing as if multiple select is possible.

#17 Updated by Andreas Müller 4 months ago

  • Status changed from In Progress to Feedback

Critical: often the selected state is not taken over to the cell or into the details view. It simply looks like the value does not change at all, though another state was selected. Happens sometimes/often but not always

#18 Updated by Andreas Müller 4 months ago

Horizontal scrollbar should appear only if necessary. This is the case only after resize of the part. Should also be recomputed after area selection changed.

#19 Updated by Andreas Müller 4 months ago

Below the row count (element count) there is a lot of empty space. Can this be reduced?

Also if possible change the label to "Row count" or "Taxa".

#20 Updated by Andreas Müller 4 months ago

Not urgent but todo at some time: try to optimize the column width at start or after area selection. Details may be discussed. We have/had a similar discussion for the bulk editor in some other ticket.

#21 Updated by Andreas Müller 4 months ago

Why did you move the buttons for area selection and source selection to the left. I think they look better on the right side. Also please add some spacing to the border.

#22 Updated by Andreas Müller 4 months ago

The automated source attachement often does not work or is at least not shown in the details view immediately. The later might be the case as the details view often does not update correctly after selection change.

#23 Updated by Andreas Müller 4 months ago

Andreas Müller wrote:

The dropbox for states opens on top. This leads to a cut of the list which makes it impossible to choose from the topmost states. In the following screenshot there should be more available states abover "casual: presence questionable":

This is the case only if the list is too long to show up in full below the cell.

#24 Updated by Andreas Müller 4 months ago

Critical: saving after multiple changes (maybe even of the same cell) seems to crash the application (no return from save command - "keine Rückmeldung"). Happened to me twice now within short time. Saving small amounts worked well.

#25 Updated by Andreas Müller 4 months ago

Andreas Müller wrote:

Below the row count (element count) there is a lot of empty space. Can this be reduced?

OK, I see this is the line for preselected source. If possible we should try to put it into the same line as the count. But maybe difficult because row count belongs to NAT table? If really impossible we should show the source line only if a value is given AND move it to the left.

#26 Updated by Andreas Müller 4 months ago

... or move it to the top. Needs to be tested what looks better.

#27 Updated by Andreas Müller 4 months ago

Andreas Müller wrote:

Critical: saving after multiple changes (maybe even of the same cell) seems to crash the application (no return from save command - "keine Rückmeldung"). Happened to me twice now within short time. Saving small amounts worked well.

Or maybe it is also related to usage of preselected sources? It happened again now after selecting source, before it didn't with a couple of changes.

#28 Updated by Andreas Müller 4 months ago

Andreas Müller wrote:

Critical: saving after multiple changes (maybe even of the same cell) seems to crash the application (no return from save command - "keine Rückmeldung"). Happened to me twice now within short time. Saving small amounts worked well.

After longer time we get:

login : testi
editor version : 5.5.0.201901161229
server :  (edit-test)
schema version : 
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
org.springframework.remoting.RemoteAccessException: Could not access HTTP invoker remote service at [http://test.e-taxonomy.eu:80/cdmserver/rem_conf_am/remoting/term.service]; nested exception is org.apache.http.NoHttpResponseException: Did not receive successful HTTP response: status code = 503, status message = [Service Unavailable]
    at org.springframework.remoting.httpinvoker.HttpInvokerClientInterceptor.convertHttpInvokerAccessException(HttpInvokerClientInterceptor.java:216)
    at org.springframework.remoting.httpinvoker.HttpInvokerClientInterceptor.invoke(HttpInvokerClientInterceptor.java:147)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
    at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:208)
    at com.sun.proxy.$Proxy46.findWithoutFlush(Unknown Source)
    at eu.etaxonomy.cdm.api.cache.CdmServiceCacher.findByUuid(CdmServiceCacher.java:93)
    at eu.etaxonomy.cdm.api.cache.CdmCacher.load(CdmCacher.java:134)
    at eu.etaxonomy.cdm.model.common.Language.getDefaultLanguage_aroundBody996(Language.java:1304)
    at eu.etaxonomy.cdm.model.common.Language.getDefaultLanguage(Language.java:1)
    at eu.etaxonomy.cdm.model.common.Language.DEFAULT_aroundBody982(Language.java:1148)
    at eu.etaxonomy.cdm.model.common.Language.DEFAULT(Language.java:1)
    at eu.etaxonomy.cdm.model.common.TermBase.getLabel(TermBase.java:208)
    at sun.reflect.GeneratedMethodAccessor75.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.hibernate.proxy.pojo.javassist.JavassistLazyInitializer.invoke(JavassistLazyInitializer.java:79)
    at eu.etaxonomy.cdm.model.description.PresenceAbsenceTerm_$$_jvst1eb_9.getLabel(PresenceAbsenceTerm_$$_jvst1eb_9.java)
    at eu.etaxonomy.taxeditor.editor.view.checklist.e4.DistributionColumnAccessor.lambda$0(DistributionColumnAccessor.java:80)
    at java.lang.Iterable.forEach(Iterable.java:75)
    at eu.etaxonomy.taxeditor.editor.view.checklist.e4.DistributionColumnAccessor.getDataValue(DistributionColumnAccessor.java:80)
    at eu.etaxonomy.taxeditor.editor.view.checklist.e4.DistributionColumnAccessor.getDataValue(DistributionColumnAccessor.java:1)
    at org.eclipse.nebula.widgets.nattable.data.ListDataProvider.getDataValue(ListDataProvider.java:51)
    at org.eclipse.nebula.widgets.nattable.layer.DataLayer.getDataValue(DataLayer.java:164)
    at org.eclipse.nebula.widgets.nattable.layer.DataLayer.getDataValueByPosition(DataLayer.java:447)
    at org.eclipse.nebula.widgets.nattable.layer.AbstractIndexLayerTransform.getDataValueByPosition(AbstractIndexLayerTransform.java:358)
    at org.eclipse.nebula.widgets.nattable.layer.cell.AbstractLayerCell.getDataValue(AbstractLayerCell.java:64)
    at eu.etaxonomy.taxeditor.editor.view.checklist.e4.DistributionCellSelectionListener.handleLayerEvent(DistributionCellSelectionListener.java:52)
    at org.eclipse.nebula.widgets.nattable.layer.AbstractLayer.fireLayerEvent(AbstractLayer.java:307)
    at org.eclipse.nebula.widgets.nattable.selection.SelectionLayer.fireCellSelectionEvent(SelectionLayer.java:592)
    at org.eclipse.nebula.widgets.nattable.selection.SelectCellCommandHandler.doCommand(SelectCellCommandHandler.java:42)
    at org.eclipse.nebula.widgets.nattable.selection.SelectCellCommandHandler.doCommand(SelectCellCommandHandler.java:1)
    at org.eclipse.nebula.widgets.nattable.layer.AbstractLayer.doCommand(AbstractLayer.java:186)
    at org.eclipse.nebula.widgets.nattable.layer.AbstractIndexLayerTransform.doCommand(AbstractIndexLayerTransform.java:105)
    at org.eclipse.nebula.widgets.nattable.selection.SelectionLayer.doCommand(SelectionLayer.java:579)
    at org.eclipse.nebula.widgets.nattable.layer.AbstractIndexLayerTransform.doCommand(AbstractIndexLayerTransform.java:109)
    at org.eclipse.nebula.widgets.nattable.layer.CompositeLayer.doCommandOnChildLayers(CompositeLayer.java:159)
    at org.eclipse.nebula.widgets.nattable.layer.CompositeLayer.doCommand(CompositeLayer.java:151)
    at org.eclipse.nebula.widgets.nattable.freeze.CompositeFreezeLayer.doCommand(CompositeFreezeLayer.java:148)
    at org.eclipse.nebula.widgets.nattable.grid.layer.GridLayer.doCommandOnChildLayer(GridLayer.java:113)
    at org.eclipse.nebula.widgets.nattable.grid.layer.GridLayer.doCommandOnChildLayers(GridLayer.java:99)
    at org.eclipse.nebula.widgets.nattable.layer.CompositeLayer.doCommand(CompositeLayer.java:151)
    at org.eclipse.nebula.widgets.nattable.grid.layer.GridLayer.doCommand(GridLayer.java:187)
    at org.eclipse.nebula.widgets.nattable.NatTable.doCommand(NatTable.java:820)
    at org.eclipse.nebula.widgets.nattable.selection.action.SelectCellAction.run(SelectCellAction.java:25)
    at org.eclipse.nebula.widgets.nattable.ui.mode.ConfigurableModeEventHandler.mouseDown(ConfigurableModeEventHandler.java:45)
    at org.eclipse.nebula.widgets.nattable.ui.mode.ModeSupport.mouseDown(ModeSupport.java:108)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:193)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
...
Caused by: org.apache.http.NoHttpResponseException: Did not receive successful HTTP response: status code = 503, status message = [Service Unavailable]
    at org.springframework.remoting.httpinvoker.HttpComponentsHttpInvokerRequestExecutor.validateResponse(HttpComponentsHttpInvokerRequestExecutor.java:357)
    at org.springframework.remoting.httpinvoker.HttpComponentsHttpInvokerRequestExecutor.doExecuteRequest(HttpComponentsHttpInvokerRequestExecutor.java:230)
    at eu.etaxonomy.taxeditor.service.CdmServiceRequestExecutor.doExecuteRequest(CdmServiceRequestExecutor.java:61)
    ... 71 more

#29 Updated by Andreas Müller 4 months ago

... hmm, maybe this was not the original message after save but a bit later and similar

#30 Updated by Andreas Müller 4 months ago

  • Description updated (diff)

#31 Updated by Katja Luther 4 months ago

  • Description updated (diff)
  • Status changed from Feedback to In Progress

the selection should work now, I missed to commit the changes in details view.

#32 Updated by Katja Luther 4 months ago

How long did you work with the distribution editor when the saving did not work anymore?

#33 Updated by Andreas Müller 4 months ago

  • Related to bug #7999: Allow override does not work correctly for distribution areas added

#34 Updated by Andreas Müller 4 months ago

  • Status changed from In Progress to Feedback

was the status change on purpose?

#35 Updated by Andreas Müller 4 months ago

Katja Luther wrote:

How long did you work with the distribution editor when the saving did not work anymore?

I did maybe 20-30 changes in about 10 differnt taxa

#36 Updated by Andreas Müller 4 months ago

Katja Luther wrote:

the selection should work now, I missed to commit the changes in details view.

The detail view seems now always to be synchronized, but the critical issue that the selected value from the dropdown is not taken as a value still exists. See #7854#note-17. This occurrs if you want to change a value, e.g. I never manage to change from absent to present. I need to remove absent first and then I can set present. The other way round it works, changing present to absent.

#37 Updated by Andreas Müller 4 months ago

  • Description updated (diff)

#38 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

Katja Luther wrote:

the selection should work now, I missed to commit the changes in details view.

The detail view seems now always to be synchronized, but the critical issue that the selected value from the dropdown is not taken as a value still exists. See #7854#note-17. This occurrs if you want to change a value, e.g. I never manage to change from absent to present. I need to remove absent first and then I can set present. The other way round it works, changing present to absent.

I can't reproduce this.

#39 Updated by Katja Luther 4 months ago

Katja Luther wrote:

Andreas Müller wrote:

Katja Luther wrote:

the selection should work now, I missed to commit the changes in details view.

The detail view seems now always to be synchronized, but the critical issue that the selected value from the dropdown is not taken as a value still exists. See #7854#note-17. This occurrs if you want to change a value, e.g. I never manage to change from absent to present. I need to remove absent first and then I can set present. The other way round it works, changing present to absent.

I can't reproduce this.

no I think that was because the ticket was still open with the status "in process"

#40 Updated by Katja Luther 4 months ago

  • Description updated (diff)

#41 Updated by Katja Luther 4 months ago

  • Description updated (diff)

Andreas Müller wrote:

The automated source attachement often does not work or is at least not shown in the details view immediately. The later might be the case as the details view often does not update correctly after selection change.

When the source was not opened before in another details view, it is still collapsed but I could not reproduce it that it does not work.

#42 Updated by Katja Luther 4 months ago

  • Assignee changed from Katja Luther to Andreas Müller

#43 Updated by Andreas Müller 4 months ago

  • Status changed from Feedback to Resolved

#44 Updated by Andreas Müller 4 months ago

Katja Luther wrote:

Andreas Müller wrote:

The detail view seems now always to be synchronized, but the critical issue that the selected value from the dropdown is not taken as a value still exists. See #7854#note-17. This occurrs if you want to change a value, e.g. I never manage to change from absent to present. I need to remove absent first and then I can set present. The other way round it works, changing present to absent.

I can't reproduce this.

The issue still exists and is critical. For reproduction I try again to describe what I did.

  1. Open with nightly in rem_conf_am distribution editor for children of Testklass-Media test.
  2. Select some areas
  3. Select status: endemic, reported in error for Taxon A, area a
  4. click to another cell
  5. Go back to cell Taxon A, area a
  6. Select absent by clicking on the checkbox for absent => the selected value is still "endemic, reported in error"

Now I realized that it is important to click the checkbox, not the text. With clicking the text it works. This supports my first idea that the use of the checkboxes creates something like a multi-select but only the first term of the multi-select is returned or used.
Again my question, if this checkbox is necessary. It is unusual to have checkboxes for a simple dropdown.

#45 Updated by Andreas Müller 4 months ago

  • File picture907-1.png View added
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

The filter for status shows the "None" state as default toString:

Please use a suitable label, e.g. "None"

#46 Updated by Andreas Müller 4 months ago

Katja Luther wrote:

Andreas Müller wrote:

The automated source attachement often does not work or is at least not shown in the details view immediately. The later might be the case as the details view often does not update correctly after selection change.

When the source was not opened before in another details view, it is still collapsed but I could not reproduce it that it does not work.

Also this is still open. This:

is what I get, when I

  1. open the distribution editor
  2. Select a source (not to be seen in the picture)
  3. Click on Taxon Media test var. xxx, Area1
  4. Select native as status

=> no source in the details view to be seen

Even more strange:

  1. Click on Taxon Media test var. xxx, Land5
  2. Going back againg to Area1
  3. And again clicking on Land5 Shows the reference in Land5, though no status was added yet here

#47 Updated by Andreas Müller 4 months ago

Generally it happens not so seldom that I click in a cell, the dropdown immediately opens but the details view does not react:

Here, for example, Details View still shows Land 5 but I clicked afterwards into Land6 but Details View does not follow:

#48 Updated by Andreas Müller 4 months ago

  • % Done changed from 0 to 30

In general I wonder if the behaviour that clicking into the cell immediately opens the dropdown is really wanted. I often click into a cell simply to leave the current selection/dropdown. E.g. I want to go to a cell below the currently selected cell without doing any selection. This is not possible because the cell is not visible (covered by dropdown), so again I have to click in some cell which immediately opens a dropdown which is kind of annoying. It often does not feel good.
To me it seems like a second click (e.g. on the dropdown arrow) or a double click is the better solution to distinguish selection (e.g. to just show data in details view, etc.) and editing.

@Patrick: what is your configuration and experience in the matrix editor here?

#49 Updated by Andreas Müller 4 months ago

It seems to be a problem with the enter cell event. Here I opened a fresh DistrEditor and clicked on the first empty cell.

As you can see the details view is still completely empt showing the message that nothing is yet selecte. But the first cell is already selected but as it looks like the event was not passed to the Details View.

#50 Updated by Andreas Müller 4 months ago

Generally it looks like now also empty distributions (no status) do get a Source now what is not expected. Source should only be attached when creating a NEW distribution WITH status.

#51 Updated by Andreas Müller 4 months ago

Andreas Müller wrote:

The dropbox for states opens on top. This leads to a cut of the list which makes it impossible to choose from the topmost states. In the following screenshot there should be more available states abover "casual: presence questionable":

Also this is still open

#52 Updated by Andreas Müller 4 months ago

Andreas Müller wrote:

In preferences translate possible configuration terms "Show IdInVocabulary", ...

Also remove "Show" from all entries. Simply use "Label" (not title!), "Symbol 1" (please add whitespace), "Symbol 2", "ID in vocabulary" (whitespace, no camel case!)

Also still open.
Could you please check the whole ticket for open issues and if you think they should not be implemented within this ticket clearly document this by either rejecting them (with comment) or moving to another ticket.

#53 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

It seems to be a problem with the enter cell event. Here I opened a fresh DistrEditor and clicked on the first empty cell.

As you can see the details view is still completely empt showing the message that nothing is yet selecte. But the first cell is already selected but as it looks like the event was not passed to the Details View.

Maybe there is a problem with the details view. Probably it is similar to the problem Walter reported last week.(#8026)

#54 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

Andreas Müller wrote:

In preferences translate possible configuration terms "Show IdInVocabulary", ...

Also remove "Show" from all entries. Simply use "Label" (not title!), "Symbol 1" (please add whitespace), "Symbol 2", "ID in vocabulary" (whitespace, no camel case!)

Also still open.

this is fixed, but needs a server restart because it is a change in cdmlib

#55 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

The filter for status shows the "None" state as default toString:

Please use a suitable label, e.g. "None"

Now there is a " - " because None was too long.

#56 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

The dropbox for states has a checkbox. As it is only for selecting a single state this does not make sense as it gives the fealing as if multiple select is possible.

this is fixed

#57 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

Andreas Müller wrote:

The dropbox for states opens on top. This leads to a cut of the list which makes it impossible to choose from the topmost states. In the following screenshot there should be more available states abover "casual: presence questionable":

Also this is still open

now there is a max visible items set and when the number of items is higher than this value a scroll bar appeears

#58 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

Horizontal scrollbar should appear only if necessary. This is the case only after resize of the part. Should also be recomputed after area selection changed.

this is fixed

#59 Updated by Katja Luther 4 months ago

Katja Luther wrote:

Andreas Müller wrote:

It seems to be a problem with the enter cell event. Here I opened a fresh DistrEditor and clicked on the first empty cell.

As you can see the details view is still completely empt showing the message that nothing is yet selecte. But the first cell is already selected but as it looks like the event was not passed to the Details View.

Maybe there is a problem with the details view. Probably it is similar to the problem Walter reported last week.(#8026)

now there is an empty details view if no distribution exist and after creating a new one it is updated correctly.

#60 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

In general I wonder if the behaviour that clicking into the cell immediately opens the dropdown is really wanted. I often click into a cell simply to leave the current selection/dropdown. E.g. I want to go to a cell below the currently selected cell without doing any selection. This is not possible because the cell is not visible (covered by dropdown), so again I have to click in some cell which immediately opens a dropdown which is kind of annoying. It often does not feel good.
To me it seems like a second click (e.g. on the dropdown arrow) or a double click is the better solution to distinguish selection (e.g. to just show data in details view, etc.) and editing.

@Patrick: what is your configuration and experience in the matrix editor here?

the normal behaviour of the NATCombo is that with mousecklick the drop down is activated, but if you use the arrow keys to navigate through the editor and with space bar you can open the drop down and with enter set the selected value.

#61 Updated by Katja Luther 4 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

I hope that all issues are solved now. In my tests all changes of cells are passed to the details view and the sources are always added to the new distributions.

Please review.

#62 Updated by Andreas Müller 4 months ago

  • Description updated (diff)

#63 Updated by Andreas Müller 4 months ago

  • Description updated (diff)

#64 Updated by Andreas Müller 4 months ago

  • Related to bug #8043: ConstraintViolationException in distribution editor added

#65 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Now, the rows are mixed somehow. Editing the 2 or 3 lines changes the first line. What I did:

  • Open all taxa of classification edit-test/test1/Test
  • (predefined areas were all continents and all waterbodies, available status endemic, present, native)
  • In first line I set "Mein taxo"/Africa to "endemic".
  • Then I changed in 2nd line "Test drei"/Africa to present. => Also first line was changed to endemic automatically.
  • Then I changed in 3rd line "Taxon2"/Africa to native. => Also first line was changed to native automatically.

Also data were not saved. After saving and reopening the editor was empty.

#66 Updated by Andreas Müller 4 months ago

Katja Luther wrote:

Andreas Müller wrote:

Andreas Müller wrote:

The dropbox for states opens on top. This leads to a cut of the list which makes it impossible to choose from the topmost states. In the following screenshot there should be more available states abover "casual: presence questionable":

Also this is still open

now there is a max visible items set and when the number of items is higher than this value a scroll bar appeears

Maybe we can make the number of status shown in the dropdown configurable, as sometimes you may want to have a longer list always available.
I opened a new ticket for such minor issues: #8047

#67 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

Now, the rows are mixed somehow. Editing the 2 or 3 lines changes the first line. What I did:

  • Open all taxa of classification edit-test/test1/Test
  • (predefined areas were all continents and all waterbodies, available status endemic, present, native)
  • In first line I set "Mein taxo"/Africa to "endemic".
  • Then I changed in 2nd line "Test drei"/Africa to present. => Also first line was changed to endemic automatically.
  • Then I changed in 3rd line "Taxon2"/Africa to native. => Also first line was changed to native automatically.

Also data were not saved. After saving and reopening the editor was empty.

The saving issues is solved and I did not get the problem of hanging the distribution to the wrong taxon again. please review.

#68 Updated by Katja Luther 4 months ago

Katja Luther wrote:

Andreas Müller wrote:

Now, the rows are mixed somehow. Editing the 2 or 3 lines changes the first line. What I did:

  • Open all taxa of classification edit-test/test1/Test
  • (predefined areas were all continents and all waterbodies, available status endemic, present, native)
  • In first line I set "Mein taxo"/Africa to "endemic".
  • Then I changed in 2nd line "Test drei"/Africa to present. => Also first line was changed to endemic automatically.
  • Then I changed in 3rd line "Taxon2"/Africa to native. => Also first line was changed to native automatically.

Also data were not saved. After saving and reopening the editor was empty.

The saving issues is solved and I did not get the problem of hanging the distribution to the wrong taxon again. please review.

I think the constraint violation exception was caused by the problems of putting the value to another TaxonDescription, I could not reproduce them after fixing this issue.

#69 Updated by Katja Luther 4 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

#70 Updated by Andreas Müller 4 months ago

  • Copied to task #8047: Remaining issues in TaxDistributionEditor added

#71 Updated by Andreas Müller 4 months ago

Andreas Müller wrote:

Not urgent but todo at some time: try to optimize the column width at start or after area selection. Details may be discussed. We have/had a similar discussion for the bulk editor in some other ticket.

moved to #8047

#72 Updated by Andreas Müller 4 months ago

  • Description updated (diff)

#73 Updated by Andreas Müller 4 months ago

Katja Luther wrote:

still open:

  • remember the column widths
  • filter for distribution columns
  • rank column
  • when editing only the details or supplemental data, the dirty flag is not set!!!
  • handling of areas with more then one distribution
  • column width was moved to #8047
  • rank column is still open, please either implement or move to #8047 (if the later, we should remove the configuration param from preferences and leave message in #8047 to switch it on again)
  • handling of areas with more then one distribution: what is meant here? is it only the display? if yes, this is fixed I think, if not, please leave a note what is meant and/or move to other ticket

#74 Updated by Andreas Müller 4 months ago

Andreas Müller wrote:

Multiple cell selection in table is currently possible. As there is no function related to this we should remove this feature for now.

Still open issue. I moved it to #8047. If easy to fix please fix here and remove from there.

#75 Updated by Andreas Müller 4 months ago

Filtering on status NONE does not work, but is maybe the most interesting of all filters

#76 Updated by Andreas Müller 4 months ago

Is there a possiblity to enter the dropdown only by key strokes? As we allow moving in the cells with arrow keys it might be a nice entering performance feature to also allow data entry via keyboard.

#77 Updated by Andreas Müller 4 months ago

Maybe we can relabel "Default Source Reference" to "Default Source" to make it shorter. It is still clear this way.

And can we also translate it? Otherwise we have translated buttons but non translated labels in the same view.

#78 Updated by Andreas Müller 4 months ago

It should be possible to delete the default reference somehow.

#79 Updated by Andreas Müller 4 months ago

Katja Luther wrote:

Andreas Müller wrote:

The filter for status shows the "None" state as default toString:

Please use a suitable label, e.g. "None"

Now there is a " - " because None was too long.

" - " is ok I think, but I don't understand why "None" is too long. Other states have much longer labels.

#80 Updated by Andreas Müller 4 months ago

Andreas Müller wrote:

Is there a possiblity to enter the dropdown only by key strokes? As we allow moving in the cells with arrow keys it might be a nice entering performance feature to also allow data entry via keyboard.

Ahh, I see you have already answered this in #7854#note-60 . The only problem is that the user may not know it. Some documentation needed here (#8047)

#81 Updated by Andreas Müller 4 months ago

Andreas Müller wrote:

  • remove factual data view, wenn opening distribution editor

This seems to work, but maybe we should document somehow what the wanted behavior is. If you open a taxon and go back to the DistrEditor afterwords the view is there again. Is this wanted/accepted or do we expect another behavior?

Also have you checked the "Checklist perspective"? I think it is explicitly for using the distribution editor. Does it do what it should? Do we want to ask the user to if he want's to open the "Checklist persp" when opening DistrEditor? Do we want to rename the perspective to something like "Distribution (Editor?)"?

#82 Updated by Andreas Müller 4 months ago

Can you leave a message how the sorting is implemented now? To me it looks like Rank + alphabet. True? But maybe we also need something which is related to the tree structure in the navigator, so children of a taxon come first though they have a lower rank. Can go into follow up ticket.

#83 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Congratulations. The Distr. Editor seems to work correctly now (except for the minor issues and improvements starting from #7854#note-73 and those mentioned in follow up #8047 . Please decide what can be done within this ticket and what should be moved to follow up (IMO deleting default source is most important).

It is now fun to work with the editor!

#84 Updated by Andreas Müller 4 months ago

  • % Done changed from 30 to 60

#85 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

Andreas Müller wrote:

  • remove factual data view, wenn opening distribution editor

This seems to work, but maybe we should document somehow what the wanted behavior is. If you open a taxon and go back to the DistrEditor afterwords the view is there again. Is this wanted/accepted or do we expect another behavior?

no this is not the wanted behaviour, but the handling of switching between the views is not implemented yet.

Also have you checked the "Checklist perspective"? I think it is explicitly for using the distribution editor. Does it do what it should? Do we want to ask the user to if he want's to open the "Checklist persp" when opening DistrEditor? Do we want to rename the perspective to something like "Distribution (Editor?)"?

The perspective is something else, this is a perspective where the media view is hidden as default and should be used for checklist (originally it comes from the redlist project)

#86 Updated by Katja Luther 4 months ago

Andreas Müller wrote:

Can you leave a message how the sorting is implemented now? To me it looks like Rank + alphabet. True? But maybe we also need something which is related to the tree structure in the navigator, so children of a taxon come first though they have a lower rank. Can go into follow up ticket.

yes it is rank and alphabet, I move this to the follow up ticket

#87 Updated by Andreas Müller 4 months ago

Katja Luther wrote:

Andreas Müller wrote:

Can you leave a message how the sorting is implemented now? To me it looks like Rank + alphabet. True? But maybe we also need something which is related to the tree structure in the navigator, so children of a taxon come first though they have a lower rank. Can go into follow up ticket.

yes it is rank and alphabet, I move this to the follow up ticket

yes, or better make it configurable as we have discussed before (did we create a ticket for this or was it only by mail?). I left a note in #8047

#88 Updated by Katja Luther 4 months ago

  • Assignee changed from Katja Luther to Andreas Müller

Can we close this ticket, the remaining issues are moved to the follow up ticket, aren't they?

#89 Updated by Andreas Müller 4 months ago

Not all of them are moved. Some are still open here

note-73 last question
note-75
note-77
note-78
note-79 (but is only a question)

Can you either implement/answer them or move them to the follow up ticket? Afterwards we can close this ticket.

#90 Updated by Andreas Müller 4 months ago

Katja Luther wrote:

Andreas Müller wrote:

Also have you checked the "Checklist perspective"? I think it is explicitly for using the distribution editor. Does it do what it should? Do we want to ask the user to if he want's to open the "Checklist persp" when opening DistrEditor? Do we want to rename the perspective to something like "Distribution (Editor?)"?

The perspective is something else, this is a perspective where the media view is hidden as default and should be used for checklist (originally it comes from the redlist project)

But the distribution editor was originally called checklist editor. I am quite sure that this perspective was developed for the now called distribution editor orginally. And it makes sense, but should also remove the Facts View there, I think. And I still suggest to rename it to "Distribution" perspective.

#91 Updated by Katja Luther 3 months ago

Andreas Müller wrote:

Not all of them are moved. Some are still open here

note-73 last question

if the actual handling of multiple distributions for one area is ok, we can keep it as it is

note-75

this works now. see Revision 663a45e5

note-77

is implemented

note-78

there is a third button for removing the default source

note-79 (but is only a question)

I tried to use None, but I thought it does not look nice.

Can you either implement/answer them or move them to the follow up ticket? Afterwards we can close this ticket.

#92 Updated by Andreas Müller 3 months ago

  • Status changed from Feedback to Resolved

#93 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther

Ok, this now works. I add some minor issues for the "Source" buttons to the follow up ticket #8047.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)