Project

General

Profile

feature request #7809

Improve namerelationship handling in editor

Added by Katja Luther 2 months ago. Updated about 2 months ago.

Status:
Feedback
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
10/08/2018
Due date:
% Done:

70%

Severity:
normal
Tags:

Description

copied from #7793:

Namerelationships should be available for both directions in name editor details view.

We should have a formatter like for concept relations (=> AM)

Wizard:
the scientific name should be in italics (more visible) or another posibility could be to use it as label for the type combobox, then it can be read as "Abies alba is homonym of ..."

picture850-1.png View (2.29 KB) Andreas Müller, 10/24/2018 12:00 AM


Related issues

Related to Edit - feature request #7793: Master ticket for E+M editor issues Feedback 09/27/2018
Related to Edit - bug #7857: Update name relationship type representations and symmetrie New 10/23/2018

Associated revisions

Revision 85ad5f88 (diff)
Added by Katja Luther about 2 months ago

ref #7809: namerelationshiptypes should be shown in both directions

Revision f9328c66 (diff)
Added by Katja Luther about 2 months ago

ref #7809: adapt namerelationship wizard

Revision 8ce2d72b (diff)
Added by Katja Luther about 2 months ago

ref #7809: change order of inverse label and label of the namerelationshiptype term in combobox

Revision f808cb88 (diff)
Added by Katja Luther about 2 months ago

ref #7809: check if inverse representation is null instead of label

History

#1 Updated by Katja Luther 2 months ago

  • Tracker changed from bug to feature request

#2 Updated by Katja Luther 2 months ago

  • Status changed from New to In Progress

#3 Updated by Katja Luther 2 months ago

#4 Updated by Katja Luther about 2 months ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review. I adapted the wizard like it is descriped in ticket description. Maybe the text should be different??

#5 Updated by Andreas Müller about 2 months ago

  • Description updated (diff)

#6 Updated by Andreas Müller about 2 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

In yesterday evenings nightly the invers direction still is not available so I can't test.

#7 Updated by Katja Luther about 2 months ago

  • Assignee changed from Katja Luther to Andreas Müller

jenkins failed because of download problems, but the nightly build of this night contains the implementation, now.

#8 Updated by Andreas Müller about 2 months ago

  • Assignee changed from Andreas Müller to Katja Luther

still not available in nightly

#9 Updated by Andreas Müller about 2 months ago

  • % Done changed from 0 to 40

It works now if English is chosen as language for representations. I had German installed.

#10 Updated by Katja Luther about 2 months ago

  • Status changed from Feedback to Resolved

this should be fixed now

#11 Updated by Andreas Müller about 2 months ago

  • Assignee changed from Katja Luther to Andreas Müller

#12 Updated by Andreas Müller about 2 months ago

  • Related to bug #7857: Update name relationship type representations and symmetrie added

#13 Updated by Andreas Müller about 2 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 40 to 90

Works fine and can be closed. Only somehow open issue is that "symmetrical" relationships are now shown twice. In general this is no problem, but both times the "direct" representation is taken. One may say that this is possible for symmetric relation types but then we do not need to show it twice. (it was like this before I think). Generally I think whenever the labels for a symmetric relation is not exactly the same we should better not deduplicate it. There still might be a reason for using one direction.

However this problem is small especially because according to #7857 soon all curren reltypes will not be symmetric anymore (but maybe in future new types could be symmetric)

#14 Updated by Andreas Müller about 2 months ago

  • File picture850-1.png View added
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 90 to 70

I will keep this assigned to me to remember to update the symmetric values on our server DBs already and to update representations before release.

#15 Updated by Katja Luther about 2 months ago

Andreas Müller wrote:

Works fine and can be closed. Only somehow open issue is that "symmetrical" relationships are now shown twice. In general this is no problem, but both times the "direct" representation is taken. One may say that this is possible for symmetric relation types but then we do not need to show it twice. (it was like this before I think). Generally I think whenever the labels for a symmetric relation is not exactly the same we should better not deduplicate it. There still might be a reason for using one direction.

However this problem is small especially because according to #7857 soon all curren reltypes will not be symmetric anymore (but maybe in future new types could be symmetric)

this is because of the method getInverseRepresentation(Language lang), there is a check for symmetric and if it is symmetric the representation not the inverse representation is returned:

public Representation getInverseRepresentation(Language lang) {
        Representation result = null;
        if (this.isSymmetric()){
            for (Representation repr : this.getRepresentations()){
                if (lang.equals(repr.getLanguage())){
                    result = repr;
                }
            }
        }else{
            for (Representation repr : this.getInverseRepresentations()){
                if (lang.equals(repr.getLanguage())){
                    result = repr;
                }
            }
        }
        return result;
    }

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)