Project

General

Profile

Actions

feature request #7809

open

Improve namerelationship handling in editor

Added by Katja Luther over 5 years ago. Updated over 5 years ago.

Status:
Feedback
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

70%

Estimated time:
Severity:
normal
Tags:

Description

copied from #7793:

Namerelationships should be available for both directions in name editor details view.

We should have a formatter like for concept relations (=> AM)

Wizard:
the scientific name should be in italics (more visible) or another posibility could be to use it as label for the type combobox, then it can be read as "Abies alba is homonym of ..."


Files

picture850-1.png (2.29 KB) picture850-1.png Andreas Müller, 10/24/2018 12:00 AM

Related issues

Related to EDIT - feature request #7793: Master ticket for E+M editor issuesClosedKatja Luther

Actions
Related to EDIT - bug #7857: Update name relationship type representations and symmetrieClosedAndreas Müller

Actions
Related to EDIT - feature request #7860: [Master] Remaining E+M editor issuesNewKatja Luther

Actions
Actions #1

Updated by Katja Luther over 5 years ago

  • Tracker changed from bug to feature request
Actions #2

Updated by Katja Luther over 5 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Katja Luther over 5 years ago

Actions #4

Updated by Katja Luther over 5 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

please review. I adapted the wizard like it is descriped in ticket description. Maybe the text should be different??

Actions #5

Updated by Andreas Müller over 5 years ago

  • Description updated (diff)
Actions #6

Updated by Andreas Müller over 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

In yesterday evenings nightly the invers direction still is not available so I can't test.

Actions #7

Updated by Katja Luther over 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller

jenkins failed because of download problems, but the nightly build of this night contains the implementation, now.

Actions #8

Updated by Andreas Müller over 5 years ago

  • Assignee changed from Andreas Müller to Katja Luther

still not available in nightly

Actions #9

Updated by Andreas Müller over 5 years ago

  • % Done changed from 0 to 40

It works now if English is chosen as language for representations. I had German installed.

Actions #10

Updated by Katja Luther over 5 years ago

  • Status changed from Feedback to Resolved

this should be fixed now

Actions #11

Updated by Andreas Müller over 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller
Actions #12

Updated by Andreas Müller over 5 years ago

  • Related to bug #7857: Update name relationship type representations and symmetrie added
Actions #13

Updated by Andreas Müller over 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 40 to 90

Works fine and can be closed. Only somehow open issue is that "symmetrical" relationships are now shown twice. In general this is no problem, but both times the "direct" representation is taken. One may say that this is possible for symmetric relation types but then we do not need to show it twice. (it was like this before I think). Generally I think whenever the labels for a symmetric relation is not exactly the same we should better not deduplicate it. There still might be a reason for using one direction.

However this problem is small especially because according to #7857 soon all curren reltypes will not be symmetric anymore (but maybe in future new types could be symmetric)

Actions #14

Updated by Andreas Müller over 5 years ago

I will keep this assigned to me to remember to update the symmetric values on our server DBs already and to update representations before release.

Actions #15

Updated by Katja Luther over 5 years ago

Andreas Müller wrote:

Works fine and can be closed. Only somehow open issue is that "symmetrical" relationships are now shown twice. In general this is no problem, but both times the "direct" representation is taken. One may say that this is possible for symmetric relation types but then we do not need to show it twice. (it was like this before I think). Generally I think whenever the labels for a symmetric relation is not exactly the same we should better not deduplicate it. There still might be a reason for using one direction.

However this problem is small especially because according to #7857 soon all curren reltypes will not be symmetric anymore (but maybe in future new types could be symmetric)

this is because of the method getInverseRepresentation(Language lang), there is a check for symmetric and if it is symmetric the representation not the inverse representation is returned:

public Representation getInverseRepresentation(Language lang) {
        Representation result = null;
        if (this.isSymmetric()){
            for (Representation repr : this.getRepresentations()){
                if (lang.equals(repr.getLanguage())){
                    result = repr;
                }
            }
        }else{
            for (Representation repr : this.getInverseRepresentations()){
                if (lang.equals(repr.getLanguage())){
                    result = repr;
                }
            }
        }
        return result;
    }
Actions #16

Updated by Andreas Müller about 5 years ago

Actions

Also available in: Atom PDF