Project

General

Profile

Actions

feature request #7775

closed

Factual Data label issue

Added by Patrick Plitzner over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
New
Assignee:
Patrick Plitzner
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:

Description

  • change context menu entry for creation of a new description to "New Factual Data Set"
  • add alternative for description creation "New Factual Data Set .../with sources" which lets the user choose a source before creation
  • description label should contain source information
    • without source: Factual Data for <taxon>
    • with source: Factual Data from <source> for <taxon>
    • If a source is added in the details view, and the titleCache is not protected, it should be generated into the label

Related issues

Related to EDIT - feature request #7473: Replace PropertyChangeEvent architecture with e4 event bus in details viewNewKatja Luther

Actions
Related to EDIT - feature request #7864: Use short forms in cache strategy for DescriptionBaseNewAndreas Müller

Actions
Copied to EDIT - feature request #7865: Remaining factual data view label issuesResolvedAndreas Müller

Actions
Actions #1

Updated by Patrick Plitzner over 5 years ago

  • Description updated (diff)
Actions #2

Updated by Patrick Plitzner over 5 years ago

  • Description updated (diff)
Actions #3

Updated by Patrick Plitzner over 5 years ago

  • Description updated (diff)
Actions #4

Updated by Patrick Plitzner over 5 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions #5

Updated by Patrick Plitzner over 5 years ago

  • Description updated (diff)
Actions #6

Updated by Patrick Plitzner over 5 years ago

  • Assignee changed from Patrick Plitzner to Andreas Müller
  • Target version changed from Unassigned CDM tickets to Release 5.4
Actions #7

Updated by Andreas Müller over 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

If a source is added in the details view, and the titleCache is not protected, it should be generated into the label

This does not yet seem to work OR the titleCache is set to protected by default. In the later case we should consider handling this differently.

All the other functionality seems to work (I updated one English label in code myself).

Actions #8

Updated by Andreas Müller over 5 years ago

If reference selection dialog is canceled a new description is created, however AND an empty source is created.

Both I would not expect, but definetely the later is unwanted.

Generally for me Cancel completely cancels the current task therefore also the former is not expected behavior.

Actions #9

Updated by Patrick Plitzner over 5 years ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

Andreas Müller wrote:

If reference selection dialog is canceled a new description is created, however AND an empty source is created.

Both I would not expect, but definetely the later is unwanted.

Generally for me Cancel completely cancels the current task therefore also the former is not expected behavior.

This is fixed.

Actions #10

Updated by Patrick Plitzner over 5 years ago

  • Description updated (diff)
Actions #11

Updated by Patrick Plitzner over 5 years ago

The label in the factual data view is now updated when changing sources. But still it is not directly updated in the details view. If you re-select the description the details view is also updated.
I would leave this issue to the refactoring on the e4 event bus for the details view.

Actions #12

Updated by Andreas Müller over 5 years ago

  • Assignee changed from Andreas Müller to Patrick Plitzner

The "New Factual Data Set with source" menu is now above the simple "New Factual Data Set" menu, but should be below.

Actions #13

Updated by Andreas Müller over 5 years ago

After creating Description it would be nice if the description gets the focus. This way you can also see the attached source.

This has also been a requirement for new DescriptionElements for while but also seems not to be implemented yet.

Actions #14

Updated by Andreas Müller over 5 years ago

Patrick Plitzner wrote:

The label in the factual data view is now updated when changing sources. But still it is not directly updated in the details view. If you re-select the description the details view is also updated.
I would leave this issue to the refactoring on the e4 event bus for the details view.

OK, but to not forget, could we create a ticket or add this issue to the event bus ticket as "not to forget subtask"

Actions #15

Updated by Andreas Müller over 5 years ago

final task: we should allow to set titleCache to protected, otherwise it is not possible to use user defined labels for descriptions

Actions #16

Updated by Patrick Plitzner over 5 years ago

  • Related to feature request #7473: Replace PropertyChangeEvent architecture with e4 event bus in details view added
Actions #17

Updated by Andreas Müller over 5 years ago

Actions #18

Updated by Patrick Plitzner over 5 years ago

Actions #19

Updated by Patrick Plitzner over 5 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 50 to 100

remaining tasks have been moved to #7865

Actions

Also available in: Atom PDF