Project

General

Profile

feature request #7775

Factual Data label issue

Added by Patrick Plitzner 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
New
Category:
taxeditor
Target version:
Start date:
09/20/2018
Due date:
% Done:

100%

Severity:
normal
Tags:

Description

  • change context menu entry for creation of a new description to "New Factual Data Set"
  • add alternative for description creation "New Factual Data Set .../with sources" which lets the user choose a source before creation
  • description label should contain source information
    • without source: Factual Data for <taxon>
    • with source: Factual Data from <source> for <taxon>
    • If a source is added in the details view, and the titleCache is not protected, it should be generated into the label

Related issues

Related to Edit - feature request #7473: Replace PropertyChangeEvent architecture with e4 event bus in details view New 06/13/2018
Related to Edit - feature request #7864: Use short forms in cache strategy for DescriptionBase New 10/25/2018
Copied to Edit - feature request #7865: Remaining factual data view label issues New 10/25/2018

Associated revisions

Revision 1d4ca46e (diff)
Added by Patrick Plitzner 3 months ago

ref #7775 Renamed context menu label

Revision d9fbbe86 (diff)
Added by Patrick Plitzner 3 months ago

ref #7775 Add option "Create new factual data set with sources"

Revision 3c0cadbb (diff)
Added by Patrick Plitzner 3 months ago

fix #7775 Add source information to description titlecache

Revision d6455c9e (diff)
Added by Patrick Plitzner 3 months ago

ref #7775 Fix source information in description titlecache

Revision fe3f1c66 (diff)
Added by Andreas Müller 2 months ago

ref #7793 rename English command for Move Factual Data to Other Taxon to ... Data Set ...

Revision a347d48a (diff)
Added by Patrick Plitzner about 2 months ago

ref #7775 Canceling reference selection does not create a description

Revision c559d0b4 (diff)
Added by Patrick Plitzner about 2 months ago

ref #7775 Update label when changing sources

Revision 446a945a (diff)
Added by Patrick Plitzner about 2 months ago

ref #7775 Change menu order

Revision f3df0663 (diff)
Added by Patrick Plitzner about 2 months ago

ref #7775 Select newly created description in factual data view

History

#1 Updated by Patrick Plitzner 3 months ago

  • Description updated (diff)

#2 Updated by Patrick Plitzner 3 months ago

  • Description updated (diff)

#3 Updated by Patrick Plitzner 3 months ago

  • Description updated (diff)

#4 Updated by Patrick Plitzner 3 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#5 Updated by Patrick Plitzner 3 months ago

  • Description updated (diff)

#6 Updated by Patrick Plitzner 3 months ago

  • Assignee changed from Patrick Plitzner to Andreas Müller
  • Target version changed from Unassigned CDM tickets to Release 5.4

#7 Updated by Andreas Müller 2 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

If a source is added in the details view, and the titleCache is not protected, it should be generated into the label

This does not yet seem to work OR the titleCache is set to protected by default. In the later case we should consider handling this differently.

All the other functionality seems to work (I updated one English label in code myself).

#8 Updated by Andreas Müller 2 months ago

If reference selection dialog is canceled a new description is created, however AND an empty source is created.

Both I would not expect, but definetely the later is unwanted.

Generally for me Cancel completely cancels the current task therefore also the former is not expected behavior.

#9 Updated by Patrick Plitzner about 2 months ago

  • Assignee changed from Patrick Plitzner to Andreas Müller

Andreas Müller wrote:

If reference selection dialog is canceled a new description is created, however AND an empty source is created.

Both I would not expect, but definetely the later is unwanted.

Generally for me Cancel completely cancels the current task therefore also the former is not expected behavior.

This is fixed.

#10 Updated by Patrick Plitzner about 2 months ago

  • Description updated (diff)

#11 Updated by Patrick Plitzner about 2 months ago

The label in the factual data view is now updated when changing sources. But still it is not directly updated in the details view. If you re-select the description the details view is also updated.
I would leave this issue to the refactoring on the e4 event bus for the details view.

#12 Updated by Andreas Müller about 2 months ago

  • Assignee changed from Andreas Müller to Patrick Plitzner

The "New Factual Data Set with source" menu is now above the simple "New Factual Data Set" menu, but should be below.

#13 Updated by Andreas Müller about 2 months ago

After creating Description it would be nice if the description gets the focus. This way you can also see the attached source.

This has also been a requirement for new DescriptionElements for while but also seems not to be implemented yet.

#14 Updated by Andreas Müller about 2 months ago

Patrick Plitzner wrote:

The label in the factual data view is now updated when changing sources. But still it is not directly updated in the details view. If you re-select the description the details view is also updated.
I would leave this issue to the refactoring on the e4 event bus for the details view.

OK, but to not forget, could we create a ticket or add this issue to the event bus ticket as "not to forget subtask"

#15 Updated by Andreas Müller about 2 months ago

final task: we should allow to set titleCache to protected, otherwise it is not possible to use user defined labels for descriptions

#16 Updated by Patrick Plitzner about 2 months ago

  • Related to feature request #7473: Replace PropertyChangeEvent architecture with e4 event bus in details view added

#17 Updated by Andreas Müller about 2 months ago

#18 Updated by Patrick Plitzner about 2 months ago

#19 Updated by Patrick Plitzner about 2 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 50 to 100

remaining tasks have been moved to #7865

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)