EDIT

The issues mentioned above are solved except that deleting takes extremely long, I could not reproduce it anymore.

Therefore before review the server needs to be restartet.

When removing the last image of the image gallery I got:

last remote method : http://test.e-taxonomy.eu:80/cdmserver/rem_conf_am/remoting/common.service
last remote request client time : 2021-01-21T15:13:15.223
last remote request response header time : Thu, 21 Jan 2021 15:13:15 GMT
client error time : 2021-01-21T15:13:16.615
login : admin
editor version : 5.19.0.202101211238
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 5.18.6.0.20201124
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.ClassCastException: org.eclipse.ui.forms.widgets.LayoutComposite cannot be cast to org.eclipse.ui.forms.widgets.ScrolledForm)
    at org.eclipse.swt.SWT.error(SWT.java:4533)
    at org.eclipse.swt.SWT.error(SWT.java:4448)
    at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:185)
    at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
    at org.eclipse.swt.widgets.Display.msgFilterProc(Display.java:3541)
    at org.eclipse.swt.internal.win32.OS.TrackPopupMenu(Native Method)
    at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:262)
    at org.eclipse.swt.widgets.Display.runPopups(Display.java:4277)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3818)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
    at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
    at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
    at eu.etaxonomy.taxeditor.Application.start(Application.java:20)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
Caused by: java.lang.ClassCastException: org.eclipse.ui.forms.widgets.LayoutComposite cannot be cast to org.eclipse.ui.forms.widgets.ScrolledForm
    at eu.etaxonomy.taxeditor.store.StoreUtil.reflowParentScrolledForm(StoreUtil.java:86)
    at eu.etaxonomy.taxeditor.ui.element.ImageElement$1.run(ImageElement.java:102)
    at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
    at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
    ... 27 more

However, I couldn't repeat this.

Applied in changeset taxeditor|d9837e213c6caef559688ebaaac5a86f3fe31cb0.

Andreas Müller wrote:

if a transient (id>0) media is removed all volatile (id=0) media are also removed automatically

this still happens, in the ID before save they are still there but during save they are removed

How to reproduce:

• create image with 1 image, save and reopen taxon
• create a new image without saving
• delete first image (=> second image is still there)
• save => second image goes away

this should be fixed now.

The image issue seems to be fixed.

There is still one new commented line:

// descriptionElement.getInDescription().removeElement(descriptionElement);

can this be removed or is it still needed?

===

Generally I wonder a bit about the moving up of TaxonNode merge in TaxonEditorInputE4. Isn't this dangerous to do the TaxonName save for related names after the merge? I would expect exceptions but can't test because saving hybrids does not work anyway at the moment #9360 (I work on this).

Can you leave a message why it is moved up and why it is not dangerous?

This should be finally closed only when #9360 is also fixed as the code seems to be related and it needs to be tested if hybrid formula names are correctly saved with the new code.