Project

General

Profile

bug #7703

Multiple names cannot be shown in TypeDesignationDetailElement for specimens

Added by Patrick Plitzner 9 months ago. Updated 18 days ago.

Status:
New
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
08/30/2018
Due date:
% Done:

0%

Severity:
major
Found in Version:

Description

If a SpecimenTypeDesignation has more than one name set as typifiedName the DetailsView shows the following:

The code responsible for that is in class DerivedUnitTypeDesignationElement:

 @Override
    public void setEntity(SpecimenTypeDesignation entity) {
        super.setEntity(entity);
        Set<TaxonName> typifiedNames = entity.getTypifiedNames();
        if(typifiedNames.size()==1){
            selectionTaxonName.setEntity(typifiedNames.iterator().next());
        }
        else if(typifiedNames.size()>1){
            formFactory.createLabel(getLayoutComposite(), "!!!!!!!!");
        }

        SpecimenTypeDesignationStatus typeStatus = HibernateProxyHelper
                .deproxy(entity.getTypeStatus());
        combo_typeStatus.setSelection(typeStatus);
        checkbox_notDesignated.setSelection(entity.isNotDesignated());

//        for (TaxonNameBase taxonNameBase : typifiedNames) {
//            EntitySelectionElement<TaxonNameBase> selectionElement = formFactory.createSelectionElement(
//                    TaxonNameBase.class, getConversationHolder(), parentFormElement, "Scientific Name", null,
//                    EntitySelectionElement.EDITABLE | EntitySelectionElement.SELECTABLE, style);
//            selectionElement.setEntity(taxonNameBase);
//        }

    }

There is some commented code that tried to deal with this issue. We should discuss how this should be visualized in the DetailsView. Probably an EntitySelectionElement for each name has to be available

picture999-1.png View (14.1 KB) Patrick Plitzner, 08/30/2018 07:57 AM

picture991-1.png View (27.1 KB) Patrick Plitzner, 02/21/2019 03:22 PM

History

#1 Updated by Patrick Plitzner 9 months ago

  • Target version changed from Release 5.3 to Release 5.4

#2 Updated by Patrick Plitzner 7 months ago

  • Target version changed from Release 5.4 to Release 5.5

#3 Updated by Patrick Plitzner 4 months ago

  • Target version changed from Release 5.5 to Release 5.6

#4 Updated by Patrick Plitzner 3 months ago

  • Priority changed from New to Highest

#5 Updated by Patrick Plitzner 3 months ago

  • Target version changed from Release 5.6 to Reviewed Next Major Release

#6 Updated by Andreas Müller 3 months ago

This belongs content wise to our current milestone. Please decide if we should move it to 5.6 and who should work on it

#7 Updated by Patrick Plitzner 3 months ago

  • Target version changed from Reviewed Next Major Release to Release 5.6

#8 Updated by Patrick Plitzner 3 months ago

  • File picture991-1.png View added
  • Status changed from New to Feedback
  • Assignee changed from Patrick Plitzner to Andreas Müller

Before I try to fix this: Is this a frequent use case? Because you can also just create two TypeDesignation with different names so that it looks like this

#9 Updated by Andreas Müller 3 months ago

Patrick Plitzner wrote:

Before I try to fix this: Is this a frequent use case? Because you can also just create two TypeDesignation with different names so that it looks like this

It is not really a frequent issue I think. But as long as we allow adding multiple names to 1 type designation and as long as such data exists we should also try to make it visible. And it seems that such data exists as far as I understand the ticket. But I agree it has not highest priority if it takes time to fix it.

#10 Updated by Patrick Plitzner 3 months ago

Displaying the names is not the problem. What would take time is implementing the possibility of editing them. Right now the details view is designed to only handle one name.
I will anyway have a look at it. It should not be a big problem.

#11 Updated by Patrick Plitzner 3 months ago

  • Status changed from Feedback to New
  • Assignee changed from Andreas Müller to Patrick Plitzner

#12 Updated by Patrick Plitzner about 2 months ago

  • Target version changed from Release 5.6 to Release 5.7

Moving to 5.7 because it doesn't have highest priority

#13 Updated by Patrick Plitzner 18 days ago

  • Target version changed from Release 5.7 to Release 5.8

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)