Project

General

Profile

bug #7677

Nomenclatural Status is always set to nom illeg in details view

Added by Katja Luther 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
08/23/2018
Due date:
% Done:

80%

Severity:
blocker
Found in Version:

Description

Hallo,

es scheint so, dass die default-Einstellung für Nomenclatural Status als "nom. illeg." einen gefährlichen Nebeneffekt mit sich gebracht hat: Wenn ich den Details View eines Namens mit einem Eintrag im Feld "Nomenclatural Status" öffne, z. B. Stephanomeria Nutt., nom. cons., und irgdendwo im Details View eine Änderung vornehme, dann wird der ausgewählte Eintrag durch "nom. illeg." überschrieben. Sehe ich das richtig?

Beste Grüße,
Norbert

Associated revisions

Revision 451f02f6 (diff)
Added by Katja Luther 4 months ago

fix bug in nomenclatural status element

Revision 65b0eef9 (diff)
Added by Katja Luther 4 months ago

ref #7677: set default type for nomenclatural status while creating new status

Revision d6f9e690 (diff)
Added by Katja Luther 3 months ago

nomenclaturalStatus is created without status type

Revision 55f79f52 (diff)
Added by Katja Luther 3 months ago

fix nomenclatural status problems

History

#1 Updated by Katja Luther 4 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
  • Target version changed from Unassigned CDM tickets to Release 5.3

#2 Updated by Katja Luther 4 months ago

This is the statement to get all nomenclatural status changes for update and create and which are changed to nom. illeg.:


select distinct name.fullTitleCache, def.titleCache 
from NomenclaturalStatus_AUD ns join AuditEvent a on a.revisionNumber = ns.REV 
join TaxonName_NomenclaturalStatus t_ns on t_ns.status_id = ns.id 
join TaxonName name on name.id = t_ns.TaxonName_id 
join DefinedTermBase def on def.id = ns.type_id 
where a.date > '2018-06-01' and (ns.revtype = 0  or ns.revtype = 1) and def.uuid like 'b7c544cf-a375-4145-9d3e-4b97f3f18108'

#3 Updated by Andreas Müller 4 months ago

select distinct name.id nameId, name.fullTitleCache fullTitle, defNow.titleCache currentStatus, a.date, ns.revtype
from NomenclaturalStatus_AUD ns 
join AuditEvent a on a.revisionNumber = ns.REV
join TaxonName_NomenclaturalStatus t_ns on t_ns.status_id = ns.id
join TaxonName name on name.id = t_ns.TaxonName_id
join DefinedTermBase def on def.id = ns.type_id
left join TaxonName_NomenclaturalStatus MNnow on name.id = MNnow.TaxonName_id
left Join NomenclaturalStatus nsNow ON nsNow.id = MNnow.status_id
left join DefinedTermBase defNow on defNow.id = nsNow.type_id
where a.date > '2018-06-20' and (ns.revtype IN (0, 1)) and def.uuid like 'b7c544cf-a375-4145-9d3e-4b97f3f18108'
ORDER BY name.fullTitleCache, a.date

to remove duplicates remove a.date from select and order by

#4 Updated by Katja Luther 4 months ago

  • Target version changed from Release 5.3 to Release 5.2

#5 Updated by Katja Luther 4 months ago

  • % Done changed from 0 to 80

#6 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

The implementation is still not fully correct. If a NomenclaturalStatus WITHOUT type exists the type will be set to nom. illeg. whenever the name is edited.
With the current implementation of the TaxEditor such a NomenclaturalStatus can not be created because a null value for a type is not possible. But if this changes in future OR if data is imported without state or edited with another editor it is possible. And this is not forbidden because sometimes the nom.status only consists of free text "rule considered" information.

Why can't we set the default value at time when the new NomenclaturalStatus is created not at time when the UI control is created? Is the NomStatus created after UI control is created?

#7 Updated by Katja Luther 4 months ago

yes you are right, it is better to create a new status with default type nom. illeg. then we do not have to set the selection for the combo box.

#8 Updated by Katja Luther 3 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

#9 Updated by Andreas Müller 3 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther

It seems to work now as expected.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)