Project

General

Profile

Actions
Copy link

bug #7668

closed

NPE when changing author

Added by Katja Luther over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Katja Luther
Category:
taxeditor
Target version:
Release 5.5
Start date:
Due date:
% Done:

80%

Estimated time:
Severity:
normal
Found in Version:

Description

mail of Sabine:

Hallo,

beim Versuch bei der Art Arenaria brachypetala den Autor zu ändern (Auswahl eines anderen aus der Liste, T.N.Popova statt Popova), öffneten sich ganz viele Fehlerfenster mit dieser Meldung:

login : s.vonmering
editor version : 5.2.0
server : api.cybertaxonomy.org (cybertaxonomy.org) / caryophyllales_spp
schema version : 5.0.0.0.20180514
os : Windows 7 6.1 amd64
java : 1.8.0_171
org.eclipse.swt.SWTException: Failed to execute runnable (org.eclipse.e4.core.di.InjectionException: java.lang.NullPointerException)
                at org.eclipse.swt.SWT.error(SWT.java:4533)
                at org.eclipse.swt.SWT.error(SWT.java:4448)
                at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:185)
                at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
                at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
                at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
                at org.eclipse.jface.window.Window.open(Window.java:794)
                at org.eclipse.jface.dialogs.ErrorDialog.open(ErrorDialog.java:346)
                at eu.etaxonomy.taxeditor.model.MessagingUtils$1.run(MessagingUtils.java:279)
                at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
                at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
                at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
                at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
                at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
                at org.eclipse.jface.window.Window.open(Window.java:794)
                at org.eclipse.jface.dialogs.ErrorDialog.open(ErrorDialog.java:346)
                at eu.etaxonomy.taxeditor.model.MessagingUtils$1.run(MessagingUtils.java:279)
                at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
                at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
                at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
                at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
                at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
                at org.eclipse.jface.window.Window.open(Window.java:794)
                at org.eclipse.jface.dialogs.ErrorDialog.open(ErrorDialog.java:346)
                at eu.etaxonomy.taxeditor.model.MessagingUtils$1.run(MessagingUtils.java:279)
                at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
                at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
                at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
                at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
                at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
                at org.eclipse.jface.window.Window.open(Window.java:794)
                at org.eclipse.jface.dialogs.ErrorDialog.open(ErrorDialog.java:346)
                at eu.etaxonomy.taxeditor.model.MessagingUtils$1.run(MessagingUtils.java:279)
                at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
                at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
                at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
                at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
                at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
                at org.eclipse.jface.window.Window.open(Window.java:794)
                at org.eclipse.jface.dialogs.ErrorDialog.open(ErrorDialog.java:346)
                at eu.etaxonomy.taxeditor.model.MessagingUtils$1.run(MessagingUtils.java:279)
                at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
                at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
                at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
                at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
                at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
                at org.eclipse.jface.window.Window.open(Window.java:794)
                at org.eclipse.jface.dialogs.ErrorDialog.open(ErrorDialog.java:346)
                at eu.etaxonomy.taxeditor.model.MessagingUtils$1.run(MessagingUtils.java:279)
                at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
                at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
                at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
                at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
                at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
                at org.eclipse.jface.window.Window.open(Window.java:794)
                at org.eclipse.jface.dialogs.ErrorDialog.open(ErrorDialog.java:346)
                at eu.etaxonomy.taxeditor.model.MessagingUtils$1.run(MessagingUtils.java:279)
                at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
                at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
                at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
                at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
                at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
                at org.eclipse.jface.window.Window.open(Window.java:794)
                at org.eclipse.jface.dialogs.ErrorDialog.open(ErrorDialog.java:346)
                at eu.etaxonomy.taxeditor.model.MessagingUtils$1.run(MessagingUtils.java:279)
                at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
                at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
                at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
                at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
                at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
                at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
                at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
                at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
                at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
                at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
                at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
                at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
                at eu.etaxonomy.taxeditor.Application.start(Application.java:24)
                at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
                at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
                at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
                at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
                at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
                at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
                at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
                at java.lang.reflect.Method.invoke(Unknown Source)
                at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
                at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
                at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
Caused by: org.eclipse.e4.core.di.InjectionException: java.lang.NullPointerException
                at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:65)
                at org.eclipse.e4.ui.internal.di.UIEventObjectSupplier$UIEventHandler$1.run(UIEventObjectSupplier.java:56)
                at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
                at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
                ... 87 more
Caused by: java.lang.NullPointerException
                at eu.etaxonomy.taxeditor.editor.name.e4.TaxonNameEditorE4.updateView(TaxonNameEditorE4.java:741)
                at sun.reflect.GeneratedMethodAccessor126.invoke(Unknown Source)
                at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
                at java.lang.reflect.Method.invoke(Unknown Source)
                at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
                ... 90 more

Related issues

Related to EDIT - bug #8077: recursive call of errorDialog.open caused by an SWTExceptionNewKatja Luther

Actions
Actions
Copy link
 #1

Updated by Andreas Müller over 5 years ago

  • Target version changed from Unassigned CDM tickets to Release 5.3
Actions
Copy link
 #2

Updated by Katja Luther over 5 years ago

  • Target version changed from Release 5.3 to Release 5.4
Actions
Copy link
 #3

Updated by Andreas Müller over 5 years ago

  • Target version changed from Release 5.4 to Release 5.5
Actions
Copy link
 #4

Updated by Katja Luther about 5 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions
Copy link
 #5

Updated by Katja Luther about 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller

null check for all potential occurrences of NPE

Actions
Copy link
 #6

Updated by Andreas Müller about 5 years ago

this.taxon != null && this.taxon.getName().equals(cdmbase) should include an additional this.taxon.getName() != null check maybe?

Actions
Copy link
 #7

Updated by Andreas Müller about 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Also I wonder why " öffneten sich ganz viele Fehlerfenster". Has this to do with some kind of recursion? Can this be avoided for somehow for similar issues? Only if obvious, I don't think this is an issue that often happens.

Actions
Copy link
 #8

Updated by Katja Luther about 5 years ago

Andreas Müller wrote:

this.taxon != null && this.taxon.getName().equals(cdmbase) should include an additional this.taxon.getName() != null check maybe?

this is already done, see r5ba8876f

Actions
Copy link
 #9

Updated by Andreas Müller about 5 years ago

  • % Done changed from 50 to 80

Katja Luther wrote:

Andreas Müller wrote:

this.taxon != null && this.taxon.getName().equals(cdmbase) should include an additional this.taxon.getName() != null check maybe?

this is already done, see r5ba8876f

ok, sorry, I only checked the first commit.

So I think if you have no idea how to handle/fix note-7 we can close this ticket

Actions
Copy link
 #10

Updated by Katja Luther about 5 years ago

  • Status changed from Feedback to Closed

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

this.taxon != null && this.taxon.getName().equals(cdmbase) should include an additional this.taxon.getName() != null check maybe?

this is already done, see r5ba8876f

ok, sorry, I only checked the first commit.

So I think if you have no idea how to handle/fix note-7 we can close this ticket

I think there was an exception in the error dialog, maybe this is an extra ticket. (-> #8077)

Actions
Copy link
 #11

Updated by Katja Luther about 5 years ago

  • Related to bug #8077: recursive call of errorDialog.open caused by an SWTException added
Actions
Copy link

Also available in: Atom PDF