Project

General

Profile

task #7561

OccurrencePortalController and FieldUnitDTO should not allow passing the determintation, associated name as argument

Added by Andreas Kohlbecker 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
New
Category:
cdmlib-remote
Target version:
Start date:
07/18/2018
Due date:
% Done:

100%

Severity:
normal

Description

The OccurrencePortalController allows requests of the form /portal/occurrence/{uuid}/derivateHierarchy?uuid={taxonUuid}

There are multiple issues with this:

  1. The taxon passed by the taxonUuid is only used to load the related TaxonName from the database. This name is set as taxonName property to the FieldUnitDTO. The taxonName is displayed in the client application, cdm_dataportal as determination.
    • => TODO (1) completely remove taxonUuid as request parameter and the propery taxon name from the FieldUnitDTO and load the taxon name, separatey in the dataportal,
    • => TODO (2) add all determinations to the FieldUnitDTO and display all in the dataporal but mark, point out the accepted determintation in the portal. --> this will be discussed in #7562
  2. The FieldUnitDTO has a property protologue. This is semantically incorrect since the protologue is "everything associated with a name when it was first established (phyl.), validly published (bot., prok.), or made available zool.),". Typedesignations can be published in nomenclatural acts which are only covering new typedesignations for an existing name. => TODO rename protologue to publication or reference and add some java doc.
    • What it the difference of DerivateDTO.citation and FieldUnitDTO.protologue ?
      • => DerivateDTO.citation is unused as well as FieldUnitDTO.protologue, so I will remove FieldUnitDTO.protologue since DerivateDTO.citation can be used if needed.
  3. The OccurrencePortalController methods are using the return type ModelAndView. => TODO This must be changed to the type of DTO being returned (PreservedSpecimenDTO or FieldUnitDTO)

Related issues

Related to Edit - bug #6816: [Dataportal] Specimen table issues Closed 07/17/2017
Related to Edit - task #7562: Specimen table "Associated with" taxon is irritating and needs to be removed, replaced Closed 07/18/2018

Associated revisions

Revision eec520d3 (diff)
Added by Andreas Kohlbecker 5 months ago

ref #7561 removing associated name and protologue from OccurrencePortalController and FieldUnitDTO

History

#1 Updated by Andreas Kohlbecker 5 months ago

  • Description updated (diff)

#2 Updated by Andreas Kohlbecker 5 months ago

Point 1) in this issue description was also raised for the data_portal in #6816 as point 4). The "Associated with" information is irritating and incomplete.

#3 Updated by Andreas Kohlbecker 5 months ago

  • Related to bug #6816: [Dataportal] Specimen table issues added

#4 Updated by Andreas Kohlbecker 5 months ago

  • Related to task #7562: Specimen table "Associated with" taxon is irritating and needs to be removed, replaced added

#5 Updated by Andreas Kohlbecker 5 months ago

  • Description updated (diff)

#6 Updated by Andreas Kohlbecker 5 months ago

  • Description updated (diff)

#7 Updated by Andreas Kohlbecker 5 months ago

  • Description updated (diff)

#8 Updated by Andreas Kohlbecker 5 months ago

  • Subject changed from OccurrencePortalController and FieldUnitDTO should not allow passing the determintation as argument to OccurrencePortalController and FieldUnitDTO should not allow passing the determintation, associated name as argument

#9 Updated by Andreas Kohlbecker 5 months ago

  • Status changed from New to In Progress
  • Target version changed from Unassigned CDM tickets to Release 5.2

#10 Updated by Andreas Kohlbecker 5 months ago

  • Description updated (diff)
  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

all done!

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)