bug #7525
closed
IdentifiableServiceBase findByTitle(), and listByTitle() methods support cdm Restrictions and Criteria
Added by Andreas Kohlbecker almost 6 years ago.
Updated over 5 years ago.
Description
The methods findByTitle() and listByTitle() in IdentifiableServiceBase offer List<Criterion> criteria as method parameter but this is almost not used at all since it is quite useless for most situations.
Having these methods also with List<Restriction<?>> restrictions as parameter instead of List<Criterion> criteria will allow using virtually arbitrary search filters, when we have both variants.
- Status changed from New to In Progress
- Assignee changed from Andreas Müller to Andreas Kohlbecker
- Blocks bug #7523: RegistrationWorkingSetEditor: existing name combobox must only offer names which are not yet registered in phycobank added
- Tags changed from phycobank to phycobank, search
- Description updated (diff)
- Subject changed from IdentifiableServiceBase findByTitle() and listByTitle() methods support cdm Restrictions instead of Criteria to IdentifiableServiceBase findByTitle(), and listByTitle() methods support cdm Restrictions instead of Criteria
- Description updated (diff)
- Blocks deleted (bug #7523: RegistrationWorkingSetEditor: existing name combobox must only offer names which are not yet registered in phycobank)
- Related to task #7527: CdmEntityDaoBase.*ByParam() public and also available in the service layer added
- Status changed from In Progress to Resolved
- % Done changed from 0 to 50
- Subject changed from IdentifiableServiceBase findByTitle(), and listByTitle() methods support cdm Restrictions instead of Criteria to IdentifiableServiceBase findByTitle(), and listByTitle() methods support cdm Restrictions and Criteria
- Description updated (diff)
- % Done changed from 50 to 0
The methods with List<Criterion> criteria are offering a different type of flexibility than those with List<Restriction<?>> restrictions so it makes a lot of sense having both of them.
Unfortunately I missed this during my initial investigation and I will restore the removed methods.
Andreas Kohlbecker wrote:
The methods with List<Criterion> criteria are offering a different type of flexibility than those with List<Restriction<?>> restrictions so it makes a lot of sense having both of them.
Unfortunately I missed this during my initial investigation and I will restore the removed methods.
Very much agreed. I also wanted to suggest it already.
- Status changed from Resolved to Closed
- % Done changed from 0 to 100
all criteria methods restored 024d9b21 and no further problems did popup during the past two months, so we can close this issue.
Also available in: Atom
PDF