Project

General

Profile

Actions

bug #7525

closed

IdentifiableServiceBase findByTitle(), and listByTitle() methods support cdm Restrictions and Criteria

Added by Andreas Kohlbecker over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
New
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
major
Found in Version:

Description

The methods findByTitle() and listByTitle() in IdentifiableServiceBase offer List<Criterion> criteria as method parameter but this is almost not used at all since it is quite useless for most situations.

Having these methods also with List<Restriction<?>> restrictions as parameter instead of List<Criterion> criteria will allow using virtually arbitrary search filters, when we have both variants.


Related issues

Related to EDIT - feature request #7517: Make search parameters like wildcards configurableNewKatja Luther

Actions
Related to EDIT - task #7527: CdmEntityDaoBase.*ByParam() public and also available in the service layerClosedAndreas Kohlbecker

Actions
Actions #1

Updated by Andreas Kohlbecker over 4 years ago

  • Status changed from New to In Progress
  • Assignee changed from Andreas Müller to Andreas Kohlbecker
Actions #2

Updated by Andreas Kohlbecker over 4 years ago

  • Blocks bug #7523: RegistrationWorkingSetEditor: existing name combobox must only offer names which are not yet registered in phycobank added
Actions #3

Updated by Andreas Kohlbecker over 4 years ago

Actions #4

Updated by Andreas Kohlbecker over 4 years ago

  • Tags changed from phycobank to phycobank, search
Actions #5

Updated by Andreas Kohlbecker over 4 years ago

  • Description updated (diff)
Actions #6

Updated by Andreas Kohlbecker over 4 years ago

  • Subject changed from IdentifiableServiceBase findByTitle() and listByTitle() methods support cdm Restrictions instead of Criteria to IdentifiableServiceBase findByTitle(), and listByTitle() methods support cdm Restrictions instead of Criteria
  • Description updated (diff)
Actions #7

Updated by Andreas Kohlbecker over 4 years ago

  • Blocks deleted (bug #7523: RegistrationWorkingSetEditor: existing name combobox must only offer names which are not yet registered in phycobank)
Actions #8

Updated by Andreas Kohlbecker over 4 years ago

  • Related to task #7527: CdmEntityDaoBase.*ByParam() public and also available in the service layer added
Actions #9

Updated by Andreas Kohlbecker over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 50
Actions #10

Updated by Andreas Kohlbecker over 4 years ago

  • Subject changed from IdentifiableServiceBase findByTitle(), and listByTitle() methods support cdm Restrictions instead of Criteria to IdentifiableServiceBase findByTitle(), and listByTitle() methods support cdm Restrictions and Criteria
  • Description updated (diff)
  • % Done changed from 50 to 0

The methods with List<Criterion> criteria are offering a different type of flexibility than those with List<Restriction<?>> restrictions so it makes a lot of sense having both of them.

Unfortunately I missed this during my initial investigation and I will restore the removed methods.

Actions #11

Updated by Andreas Müller over 4 years ago

Andreas Kohlbecker wrote:

The methods with List<Criterion> criteria are offering a different type of flexibility than those with List<Restriction<?>> restrictions so it makes a lot of sense having both of them.

Unfortunately I missed this during my initial investigation and I will restore the removed methods.

Very much agreed. I also wanted to suggest it already.

Actions #12

Updated by Andreas Kohlbecker over 4 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100

all criteria methods restored 024d9b21 and no further problems did popup during the past two months, so we can close this issue.

Actions

Also available in: Atom PDF