Project

General

Profile

bug #7525

IdentifiableServiceBase findByTitle(), and listByTitle() methods support cdm Restrictions and Criteria

Added by Andreas Kohlbecker 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
New
Category:
cdmlib
Target version:
Start date:
06/28/2018
Due date:
% Done:

100%

Severity:
major
Found in Version:

Description

The methods findByTitle() and listByTitle() in IdentifiableServiceBase offer List<Criterion> criteria as method parameter but this is almost not used at all since it is quite useless for most situations.

Having these methods also with List<Restriction<?>> restrictions as parameter instead of List<Criterion> criteria will allow using virtually arbitrary search filters, when we have both variants.


Related issues

Related to Edit - feature request #7517: Make search parameters like wildcards configurable New 06/27/2018
Related to Edit - task #7527: CdmEntityDaoBase.*ByParam() public and also available in the service layer Closed 06/29/2018

Associated revisions

Revision a33babc0 (diff)
Added by Andreas Kohlbecker 6 months ago

fix #7525 replacing Criteria lists by cdm Restrictions in CdmEntityDaoBase.*ByTitle() methods

Revision 024d9b21 (diff)
Added by Andreas Kohlbecker 6 months ago

ref #7525 restoring all previously removed Criteria methods

Revision d01b74ef (diff)
Added by Andreas Kohlbecker 6 months ago

ref #7525 ref #7523 allowing to use Restriction as exclude filter

History

#1 Updated by Andreas Kohlbecker 6 months ago

  • Status changed from New to In Progress
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

#2 Updated by Andreas Kohlbecker 6 months ago

  • Blocks bug #7523: RegistrationWorkingSetEditor: existing name combobox must only offer names which are not yet registered in phycobank added

#3 Updated by Andreas Kohlbecker 6 months ago

#4 Updated by Andreas Kohlbecker 6 months ago

  • Tags changed from phycobank to phycobank, search

#5 Updated by Andreas Kohlbecker 6 months ago

  • Description updated (diff)

#6 Updated by Andreas Kohlbecker 6 months ago

  • Subject changed from IdentifiableServiceBase findByTitle() and listByTitle() methods support cdm Restrictions instead of Criteria to IdentifiableServiceBase findByTitle(), and listByTitle() methods support cdm Restrictions instead of Criteria
  • Description updated (diff)

#7 Updated by Andreas Kohlbecker 6 months ago

  • Blocks deleted (bug #7523: RegistrationWorkingSetEditor: existing name combobox must only offer names which are not yet registered in phycobank)

#8 Updated by Andreas Kohlbecker 6 months ago

  • Related to task #7527: CdmEntityDaoBase.*ByParam() public and also available in the service layer added

#9 Updated by Andreas Kohlbecker 6 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 50

#10 Updated by Andreas Kohlbecker 6 months ago

  • Subject changed from IdentifiableServiceBase findByTitle(), and listByTitle() methods support cdm Restrictions instead of Criteria to IdentifiableServiceBase findByTitle(), and listByTitle() methods support cdm Restrictions and Criteria
  • Description updated (diff)
  • % Done changed from 50 to 0

The methods with List<Criterion> criteria are offering a different type of flexibility than those with List<Restriction<?>> restrictions so it makes a lot of sense having both of them.

Unfortunately I missed this during my initial investigation and I will restore the removed methods.

#11 Updated by Andreas Müller 6 months ago

Andreas Kohlbecker wrote:

The methods with List<Criterion> criteria are offering a different type of flexibility than those with List<Restriction<?>> restrictions so it makes a lot of sense having both of them.

Unfortunately I missed this during my initial investigation and I will restore the removed methods.

Very much agreed. I also wanted to suggest it already.

#12 Updated by Andreas Kohlbecker 4 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100

all criteria methods restored 024d9b21 and no further problems did popup during the past two months, so we can close this issue.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)