Project

General

Profile

feature request #7518

remaining issues for usage of NatTable for bulkeditor

Added by Katja Luther 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Priority14
Category:
taxeditor
Target version:
Start date:
06/27/2018
Due date:
% Done:

100%

Severity:
normal

Description

  • editable cell content/possibility to copy from a cell content
  • size of the columns should not be 50/50, but depending on the content length (percentage not absolute values)
  • better symbols for target/candidates of deduplication. Additionally offering tooltips saying that a row is target or candidate for deduplication.

Related issues

Copied from Edit - feature request #7439: Use NatTable for BulkEditor Closed 05/28/2018
Copied to Edit - feature request #7659: Implement algorithm to optimize initial column size in NAT tables New 08/17/2018
Copied to Edit - feature request #7660: Indicate the row state in a NAT table via symbols Closed 08/17/2018

Associated revisions

Revision 212da61f (diff)
Added by Patrick Plitzner 5 months ago

ref #7518 re-enable cell text selection (on double-click)

Revision 1c47af77 (diff)
Added by Patrick Plitzner 5 months ago

ref #7518 Adjust visibility of context menu items

Revision 112bb8fd (diff)
Added by Patrick Plitzner 5 months ago

ref #7518 Adjust columns size

Revision 6328df3b (diff)
Added by Patrick Plitzner 5 months ago

ref #7518 Colorize deduplication rows + tooltip

Revision 16a514f4 (diff)
Added by Patrick Plitzner 4 months ago

ref #7518 Reduce size of index column

Revision ec35f482 (diff)
Added by Patrick Plitzner 4 months ago

ref #7518 Soften colors for deduplication

Revision 596ef595 (diff)
Added by Patrick Plitzner 4 months ago

ref #7518 Fix colums sizes -> show horizontal scrollbars

Revision a186543e (diff)
Added by Patrick Plitzner 4 months ago

ref #7518 Pre-load and select previously selected element

History

#1 Updated by Katja Luther 6 months ago

#2 Updated by Patrick Plitzner 5 months ago

  • Description updated (diff)

#3 Updated by Patrick Plitzner 5 months ago

  • Status changed from New to In Progress

#4 Updated by Patrick Plitzner 5 months ago

  • Description updated (diff)
  • Status changed from In Progress to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 0 to 50

#5 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • possibility to copy from a cell content

    • this works now except for the fact that in editing mode the right click menu does not look very nice. But this is a general issue for such fields. A user defined menu would be better
  • size of the rows should not be 50/50, but depending on the content length (percentage not absolute values)

    • now percentage is used and the chosen percentage is reasonable for many use cases. However, the percentage does not yet depend on real content length which might become an important issue once multiple columns are shown. So we should try to implement this.
    • minor issue: the number column is too large now, it takes at least 20% of the size but usually needs only very little space if search result is <1000 records
  • better symbols for target/candidates of deduplication:

    • coloring of the rows works generally fine, the only open issue is that if a row is selected the the row is blue (color for selection), this makes it impossible to see what the deduplication state is. This is an issue because usually when you change the state of a row it is selected, so you can not see immediately if your action was successful. You have to change selection first which is annoying. Don't know what the best solution is. We could either try to additionally add a symbol row or have additional colors for selected targets and selected candidates
    • minor issue: colors look like in the 90th, can we use more modern colors?

#6 Updated by Andreas Müller 4 months ago

By the way, once we have >3 columns we will need horizontal scrolling anyway. So maybe this can already be implemented and the algorithm could include a decision when to make the scrollbar available.

#7 Updated by Andreas Müller 4 months ago

#8 Updated by Andreas Müller 4 months ago

#9 Updated by Andreas Müller 4 months ago

  • Description updated (diff)

The following comment was missing when the ticket was copied from #7439: "Additionally offering tooltips saying that a row is target or candidate for deduplication."

I added it to the ticket description. Still needs to be implemented if possible.

#10 Updated by Andreas Müller 4 months ago

  • Description updated (diff)

#11 Updated by Patrick Plitzner 4 months ago

Andreas Müller wrote:

The following comment was missing when the ticket was copied from #7439: "Additionally offering tooltips saying that a row is target or candidate for deduplication."

I added it to the ticket description. Still needs to be implemented if possible.

The tooltips are already implemented and should work

#12 Updated by Patrick Plitzner 4 months ago

possibility to copy from a cell content: On linux the context menu does not exist at all but CTRL+C works. I think that this is enough. Do you think it is necessary to add a user defined menu? I would guess that it will conflict with the OS context menu for text fields so this would not be easily fixed.

size of the rows should not be 50/50, but depending on the content length (percentage not absolute values): I don't understand what you mean with 50/50. Do you want different row size so that we can show line breaks?

However, the percentage does not yet depend on real content length: I tried auto adjusting the column size depending on the content but if you have one very large entity name the column would be extended to that which may lead to a lot of white space for the rest of the entries. Also, double-clicking on the column will auto adjust the size of the column. I think we can leave it like this and think about it when we add more columns in #7502

the number column is too large now: this is fixed

better symbols for target/candidates of deduplication: this could either be solved by an extra column which has an icon or (as it was earlier) we add a tag to the label ([Target], [Candidate])
colors look like in the 90th: I used a little less neon colors but this is very subjective. If you have two colors in mind I can add the RGB values

once we have >3 columns we will need horizontal scrolling anyway: horizontal scrolling should now happen when resizing the first/entity column

#13 Updated by Patrick Plitzner 4 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

#14 Updated by Andreas Müller 4 months ago

  • Description updated (diff)

#15 Updated by Andreas Müller 4 months ago

Patrick Plitzner wrote:

size of the rows should not be 50/50, but depending on the content length (percentage not absolute values): I don't understand what you mean with 50/50. Do you want different row size so that we can show line breaks?

This was an incorrect copy when the ticket was created. Of course we talk about columns here, not rows. I changed it in the description.

#16 Updated by Andreas Müller 4 months ago

Patrick Plitzner wrote:

once we have >3 columns we will need horizontal scrolling anyway: horizontal scrolling should now happen when resizing the first/entity column

Great! Works fine.

#17 Updated by Andreas Müller 4 months ago

Patrick Plitzner wrote:

colors look like in the 90th: I used a little less neon colors but this is very subjective. If you have two colors in mind I can add the RGB values

Looks better now though the yellow is a bit dirty. But don't have time to check for even better colors now.

#18 Updated by Andreas Müller 4 months ago

Patrick Plitzner wrote:

possibility to copy from a cell content: On linux the context menu does not exist at all but CTRL+C works. I think that this is enough. Do you think it is necessary to add a user defined menu? I would guess that it will conflict with the OS context menu for text fields so this would not be easily fixed.

OK, we keept it as it is for now.

#19 Updated by Andreas Müller 4 months ago

Patrick Plitzner wrote:

However, the percentage does not yet depend on real content length: I tried auto adjusting the column size depending on the content but if you have one very large entity name the column would be extended to that which may lead to a lot of white space for the rest of the entries. Also, double-clicking on the column will auto adjust the size of the column. I think we can leave it like this and think about it when we add more columns in #7502

Auto adjust is probably not the solution, but we need an algorithm to compute the first percentages. Created new ticket: #7659

#20 Updated by Andreas Müller 4 months ago

  • Description updated (diff)

#21 Updated by Andreas Müller 4 months ago

  • Copied to feature request #7659: Implement algorithm to optimize initial column size in NAT tables added

#22 Updated by Andreas Müller 4 months ago

#23 Updated by Andreas Müller 4 months ago

Patrick Plitzner wrote:

better symbols for target/candidates of deduplication: this could either be solved by an extra column which has an icon or (as it was earlier) we add a tag to the label ([Target], [Candidate])

We should check, if the extra column works. Created new ticket for this #7660. Adding tag to label is not a solution I think as we soon want to start to allow editing the cells. Also this requires that the order of the columns is fixed (starting with label).

#24 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • % Done changed from 50 to 100

All issues are either fixed or moved to new ticket so we can close this one.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)