Project

General

Profile

Actions

feature request #7502

closed

Add further columns to bulk editor

Added by Andreas Müller almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Patrick Plitzner
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:

Description

As a start we could always add id, uuid, created, updated. But if possible there should be a way to hide this columns if wanted. (created, updated is less important, if difficult to implement)

Going further it would be nice to have

  • further cache fields (e.g. nameCache and authorshipCache for TaxonName, abbreviatedCache("nomencl. cache") for Reference, nomenclaturalTitle for Person and Team)
  • Important atomized String fields like
    • TaxonName.GenusOrUninomial, .InfraGenericEpi, .specificEpi, .infraSpecificEpi
    • Reference.title, .abbreviatedTitle("nomencl. title")
    • Person.familyName, .otherName, .initials
    • Media.title, Media.description
  • Important boolean values like
    • TaxonBase.publish and Specimen.publish
    • Team.hasMoreMembers
    • protectedXXX fields (behind the respective caches)
  • More difficult are Specimen/FieldUnits, relevant columns here: Country, collector, collecting number, collection, accession number/barcode/..., but they are spread to various classes so don't know if they are easy to handle
  • ...

The above issues are ordered according to importance so feel free to start implementing only the first issues.


Related issues

Related to EDIT - feature request #7659: Implement algorithm to optimize initial column size in NAT tablesNewKatja Luther

Actions
Follows EDIT - feature request #7439: Use NatTable for BulkEditorClosedPatrick Plitzner

Actions
Precedes EDIT - feature request #7503: Make cells in bulk editor editable NewKatja Luther

Actions
Copied to EDIT - bug #7852: NAT table symbols for boolean values change to text if columns are sortedNewKatja Luther

Actions
Copied to EDIT - feature request #7853: Support multi column sort for NAT tables (e.g. in bulk editor)NewKatja Luther

Actions
Actions #1

Updated by Andreas Müller almost 5 years ago

  • Due date set to 05/29/2018
  • Start date changed from 06/20/2018 to 05/29/2018
  • Follows feature request #7439: Use NatTable for BulkEditor added
Actions #2

Updated by Andreas Müller almost 5 years ago

Actions #3

Updated by Andreas Müller almost 5 years ago

  • Target version changed from Release 5.1 to Release 5.2
Actions #4

Updated by Andreas Müller over 4 years ago

  • Due date deleted (05/29/2018)
Actions #5

Updated by Patrick Plitzner over 4 years ago

  • Target version changed from Release 5.2 to Release 5.3
Actions #6

Updated by Andreas Müller over 4 years ago

  • Related to feature request #7659: Implement algorithm to optimize initial column size in NAT tables added
Actions #7

Updated by Patrick Plitzner over 4 years ago

  • Target version changed from Release 5.3 to Release 5.4
Actions #9

Updated by Andreas Müller over 4 years ago

  • Description updated (diff)
  • Priority changed from New to Highest
Actions #10

Updated by Patrick Plitzner over 4 years ago

  • Status changed from New to Feedback
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 0 to 20

@Andreas: Please review the first implementation of this for id and uuid

Actions #11

Updated by Andreas Müller over 4 years ago

  • Status changed from Feedback to In Progress
  • Assignee changed from Andreas Müller to Patrick Plitzner

Patrick Plitzner wrote:

@Andreas: Please review the first implementation of this for id and uuid

Looks ok.

Minor issues:

  • I do not understand the sorting of uuids. Looks like they sort from 8xxx to fxxx and then start from 0xxx to 7xxx. This might be due to the way how they are internally represented. But it would be better to do it more intuitiv for human users.

  • It seems not to be possible to reenable (unhide) single columns, but only all. Is this the only possibility that NAT offers?

  • The right click menu has 3 separators between "New" and "Hide column". It would be nice if they could be deduplicated.

Generally I think you can continue with the implementation.

Actions #12

Updated by Patrick Plitzner over 4 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 20 to 50

I implemented all of the mentioned properties as columns.

Please check all types of bulk editors.

Actions #13

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

The symbol still switches to label if if one sorts by a "protected" boolean field.

Actions #14

Updated by Andreas Müller over 4 years ago

Question: does NAT support multi-sort? E.g. you want to sort first by protected or not protected titleCache, second order should be alphabetic order of titleCache.

Note: Some frameworks implement this by first sorting by the second sort, then by the first. The previous sort order stil exists then but is reordered if and only if it does not fit with the later sorting. Would be nice to have this.

Actions #15

Updated by Andreas Müller over 4 years ago

et al => et al.

Actions #16

Updated by Patrick Plitzner over 4 years ago

Andreas Müller wrote:

Question: does NAT support multi-sort? E.g. you want to sort first by protected or not protected titleCache, second order should be alphabetic order of titleCache.

Note: Some frameworks implement this by first sorting by the second sort, then by the first. The previous sort order stil exists then but is reordered if and only if it does not fit with the later sorting. Would be nice to have this.

NatTable supports multi sort but I have still not tested it yet

Actions #17

Updated by Patrick Plitzner over 4 years ago

Andreas Müller wrote:

The symbol still switches to label if if one sorts by a "protected" boolean field.

I have been playing around with this and it is not an easy fix. Anyway, with the current column size it's not that critical for now because the icon just changes into the sorting arrow and you don't even see the text.

Actions #18

Updated by Andreas Müller over 4 years ago

The view configurations dialog does not disable buttons which are not available. Also "Done" I would relabel to "Close". Or is this an RCP System dialog which can't be changed?

Actions #19

Updated by Andreas Müller over 4 years ago

Patrick Plitzner wrote:

Andreas Müller wrote:

The symbol still switches to label if if one sorts by a "protected" boolean field.

I have been playing around with this and it is not an easy fix. Anyway, with the current column size it's not that critical for now because the icon just changes into the sorting arrow and you don't even see the text.

true, not critical, but we should remember the open issue.

Actions #20

Updated by Andreas Müller over 4 years ago

All the rest works very fine and is great new functionality!!

Actions #21

Updated by Patrick Plitzner over 4 years ago

Andreas Müller wrote:

The view configurations dialog does not disable buttons which are not available. Also "Done" I would relabel to "Close". Or is this an RCP System dialog which can't be changed?

This is a built-in NatTable dialog

Actions #22

Updated by Patrick Plitzner over 4 years ago

  • Assignee changed from Patrick Plitzner to Andreas Müller
Actions #23

Updated by Andreas Müller over 4 years ago

  • Copied to bug #7852: NAT table symbols for boolean values change to text if columns are sorted added
Actions #24

Updated by Andreas Müller over 4 years ago

Andreas Müller wrote:

Patrick Plitzner wrote:

Andreas Müller wrote:

The symbol still switches to label if if one sorts by a "protected" boolean field.

I have been playing around with this and it is not an easy fix. Anyway, with the current column size it's not that critical for now because the icon just changes into the sorting arrow and you don't even see the text.

true, not critical, but we should remember the open issue.

copied to new ticket #7852

Actions #25

Updated by Andreas Müller over 4 years ago

Actions #26

Updated by Andreas Müller over 4 years ago

Patrick Plitzner wrote:

Andreas Müller wrote:

Question: does NAT support multi-sort? E.g. you want to sort first by protected or not protected titleCache, second order should be alphabetic order of titleCache.

Note: Some frameworks implement this by first sorting by the second sort, then by the first. The previous sort order stil exists then but is reordered if and only if it does not fit with the later sorting. Would be nice to have this.

NatTable supports multi sort but I have still not tested it yet

copied to new ticket #7853

Actions #27

Updated by Andreas Müller over 4 years ago

  • Status changed from Feedback to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • % Done changed from 50 to 100

Open issues copied to new tickets. Close this ticket.

Actions

Also available in: Atom PDF